Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies
Date: Tue, 18 Aug 2015 13:16:00 +0200	[thread overview]
Message-ID: <20150818131600.49a206c6@free-electrons.com> (raw)
In-Reply-To: <1439325932-14400-1-git-send-email-yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Tue, 11 Aug 2015 22:45:32 +0200, Yann E. MORIN wrote:
> mosh selects protobuf, so it needs to propagate *all* its dependencies.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/1e7/1e7d28018252fa48ee1ccd68d0a21afb3e0f072f/
>     http://autobuild.buildroot.org/results/a91/a91ea29454a6f8eefc0bf4f0eb137dd8e061f028/
>     http://autobuild.buildroot.org/results/ecb/ecb67c1d1b04a79ad9fbe4a09121ec492fe1501c/
>     [...]
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Christian Stewart <christian@paral.in>
> ---
>  package/mosh/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/mosh/Config.in b/package/mosh/Config.in
> index 4ad7d61..feba023 100644
> --- a/package/mosh/Config.in
> +++ b/package/mosh/Config.in
> @@ -5,7 +5,8 @@ comment "mosh needs a toolchain w/ threads"
>  config BR2_PACKAGE_MOSH
>  	bool "mosh"
>  	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
> -	depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
> +	depends on BR2_INSTALL_LIBSTDCPP # protobuf

And therefore, an update to the comment was needed to indicate that
mosh needs C++ support. I've done that and applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-08-18 11:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 20:45 [Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies Yann E. MORIN
2015-08-11 21:31 ` Christian Stewart
2015-08-18 11:16   ` Thomas Petazzoni
2015-08-18 14:19     ` Christian Stewart
2015-08-18 11:16 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818131600.49a206c6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox