[Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies

[Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies

[Yann E. MORIN]

mosh selects protobuf, so it needs to propagate *all* its dependencies.

Fixes:
    http://autobuild.buildroot.org/results/1e7/1e7d28018252fa48ee1ccd68d0a21afb3e0f072f/
    http://autobuild.buildroot.org/results/a91/a91ea29454a6f8eefc0bf4f0eb137dd8e061f028/
    http://autobuild.buildroot.org/results/ecb/ecb67c1d1b04a79ad9fbe4a09121ec492fe1501c/
    [...]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Christian Stewart <christian@paral.in>
---
 package/mosh/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/mosh/Config.in b/package/mosh/Config.in
index 4ad7d61..feba023 100644
--- a/package/mosh/Config.in
+++ b/package/mosh/Config.in
@@ -5,7 +5,8 @@ comment "mosh needs a toolchain w/ threads"
 config BR2_PACKAGE_MOSH
 	bool "mosh"
 	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
-	depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
+	depends on BR2_INSTALL_LIBSTDCPP # protobuf
+	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" # protobuf
 	select BR2_PACKAGE_PROTOBUF
 	select BR2_PACKAGE_NCURSES
-- 
1.9.1

[Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies

[Christian Stewart]

Yann & All,

Looks good, tested on an ODROID XU3 (ARM).

Signed-off-by: "Christian Stewart" <c <yann.morin.1998@free.fr>
hristian at paral.in>

Christian

On Tue, Aug 11, 2015 at 1:45 PM Yann E. MORIN <yann.morin.1998@free.fr>
wrote:

> mosh selects protobuf, so it needs to propagate *all* its dependencies.
>
> Fixes:
>
> http://autobuild.buildroot.org/results/1e7/1e7d28018252fa48ee1ccd68d0a21afb3e0f072f/
>
> http://autobuild.buildroot.org/results/a91/a91ea29454a6f8eefc0bf4f0eb137dd8e061f028/
>
> http://autobuild.buildroot.org/results/ecb/ecb67c1d1b04a79ad9fbe4a09121ec492fe1501c/
>     [...]
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Christian Stewart <christian@paral.in>
> ---
>  package/mosh/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/mosh/Config.in b/package/mosh/Config.in
> index 4ad7d61..feba023 100644
> --- a/package/mosh/Config.in
> +++ b/package/mosh/Config.in
> @@ -5,7 +5,8 @@ comment "mosh needs a toolchain w/ threads"
>  config BR2_PACKAGE_MOSH
>         bool "mosh"
>         depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 #
> protobuf
> -       depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
> +       depends on BR2_INSTALL_LIBSTDCPP # protobuf
> +       depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
>         depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" #
> protobuf
>         select BR2_PACKAGE_PROTOBUF
>         select BR2_PACKAGE_NCURSES
> --
> 1.9.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150811/a18da630/attachment.html>

[Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Tue, 11 Aug 2015 22:45:32 +0200, Yann E. MORIN wrote:
> mosh selects protobuf, so it needs to propagate *all* its dependencies.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/1e7/1e7d28018252fa48ee1ccd68d0a21afb3e0f072f/
>     http://autobuild.buildroot.org/results/a91/a91ea29454a6f8eefc0bf4f0eb137dd8e061f028/
>     http://autobuild.buildroot.org/results/ecb/ecb67c1d1b04a79ad9fbe4a09121ec492fe1501c/
>     [...]
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Christian Stewart <christian@paral.in>
> ---
>  package/mosh/Config.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/mosh/Config.in b/package/mosh/Config.in
> index 4ad7d61..feba023 100644
> --- a/package/mosh/Config.in
> +++ b/package/mosh/Config.in
> @@ -5,7 +5,8 @@ comment "mosh needs a toolchain w/ threads"
>  config BR2_PACKAGE_MOSH
>  	bool "mosh"
>  	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
> -	depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
> +	depends on BR2_INSTALL_LIBSTDCPP # protobuf

And therefore, an update to the comment was needed to indicate that
mosh needs C++ support. I've done that and applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies

[Thomas Petazzoni]

Dear Christian Stewart,

On Tue, 11 Aug 2015 21:31:30 +0000, Christian Stewart wrote:
> Yann & All,
> 
> Looks good, tested on an ODROID XU3 (ARM).
> 
> Signed-off-by: "Christian Stewart" <c <yann.morin.1998@free.fr>
> hristian at paral.in>

This is a bit messed up, no? Also, you shouldn't give a Signed-off-by
here, but rather a Reviewed-by and/or Tested-by.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] [autobuild] package/mosh: fix dependencies

[Christian Stewart]

Hi Thomas,

Gmail messed it up (again). I've read the docs on signatures and will be
following them accordingly.

Thanks!
Christian

On Tue, Aug 18, 2015, 7:16 AM Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:

> Dear Christian Stewart,
>
> On Tue, 11 Aug 2015 21:31:30 +0000, Christian Stewart wrote:
> > Yann & All,
> >
> > Looks good, tested on an ODROID XU3 (ARM).
> >
> > Signed-off-by: "Christian Stewart" <c <yann.morin.1998@free.fr>
> > hristian at paral.in>
>
> This is a bit messed up, no? Also, you shouldn't give a Signed-off-by
> here, but rather a Reviewed-by and/or Tested-by.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150818/c112bb29/attachment.html>