Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] Add patch to fix linking issue
Date: Tue, 18 Aug 2015 14:13:55 +0200	[thread overview]
Message-ID: <20150818141355.7b89a502@free-electrons.com> (raw)
In-Reply-To: <1439239075-14631-1-git-send-email-simon.marchi@polymtl.ca>

Dear Simon Marchi,

On Mon, 10 Aug 2015 16:37:55 -0400, Simon Marchi wrote:
> This patch fixes this autobuild failure:
> 
>   http://autobuild.buildroot.net/results/e14/e14e1700d4fe359c56be57587bdb509e002e5753/build-end.log
> 
> The problem is caused by the -fvisibility-inlines-hidden switch.
> Removing the switch is probably the least intrusive way we can make the
> problem go away.  The first solution that was considered was to move the
> definition of the offending method to the .cpp file.  However, with
> other combinations of compilers and platforms, I suppose it could happen
> with other methods as well.  Removing the switch ensures we catch them
> all.
> 
> Built-tested with the config from the build bot, as well as with all OLA
> options/plugins enabled.
> 
> Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>

The title of the patch should be:

	ola: add patch to fix linking issue

> diff --git a/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch b/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch
> new file mode 100644
> index 0000000..ac087f4
> --- /dev/null
> +++ b/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch
> @@ -0,0 +1,25 @@
> +From c160119ff3ff595862e7ba2a7b8bcb3302f13f02 Mon Sep 17 00:00:00 2001
> +From: Simon Marchi <simon.marchi@polymtl.ca>
> +Date: Mon, 10 Aug 2015 15:01:42 -0400
> +Subject: [PATCH] Remove -fvisibiliy-inlines-hidden
> +

Missing Signed-off-by here.

Can you respin after fixing those issues?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-08-18 12:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 20:37 [Buildroot] [PATCH v2] Add patch to fix linking issue Simon Marchi
2015-08-18 12:13 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818141355.7b89a502@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox