* [Buildroot] [PATCH 1/1] libpam-tacplus: new package
@ 2015-08-19 20:47 giovanni.zantedeschi
2015-08-19 22:06 ` Ryan Barnett
0 siblings, 1 reply; 3+ messages in thread
From: giovanni.zantedeschi @ 2015-08-19 20:47 UTC (permalink / raw)
To: buildroot
From: "Giovanni Zantedeschi" <giovanni.zantedeschi@datacom.ind.br>
Signed-off-by: Giovanni Zantedeschi <giovanni.zantedeschi@datacom.ind.br>
---
package/Config.in | 1 +
package/libpam-tacplus/Config.in | 5 +++++
package/libpam-tacplus/libpam-tacplus.mk | 18 ++++++++++++++++++
3 files changed, 24 insertions(+)
create mode 100644 package/libpam-tacplus/Config.in
create mode 100644 package/libpam-tacplus/libpam-tacplus.mk
diff --git a/package/Config.in b/package/Config.in
index 47d14d7..9e92023 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1074,6 +1074,7 @@ menu "Other"
source "package/libical/Config.in"
source "package/liblinear/Config.in"
source "package/libnspr/Config.in"
+ source "package/libpam-tacplus/Config.in"
source "package/libpfm4/Config.in"
source "package/libplatform/Config.in"
source "package/libplist/Config.in"
diff --git a/package/libpam-tacplus/Config.in b/package/libpam-tacplus/Config.in
new file mode 100644
index 0000000..88d10ff
--- /dev/null
+++ b/package/libpam-tacplus/Config.in
@@ -0,0 +1,5 @@
+ config BR2_PACKAGE_LIBPAM_TACPLUS
+ bool "libpam-tacplus"
+ help
+ Lib needed to use pam-tacplus
+
diff --git a/package/libpam-tacplus/libpam-tacplus.mk b/package/libpam-tacplus/libpam-tacplus.mk
new file mode 100644
index 0000000..f788f47
--- /dev/null
+++ b/package/libpam-tacplus/libpam-tacplus.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# libpam-tacplus
+#
+################################################################################
+
+LIBPAM_TACPLUS_VERSION = 1.3.9
+LIBPAM_TACPLUS_SITE = https://github.com/jeroennijhof/pam_tacplus.git
+LIBPAM_TACPLUS_SITE_METHOD = git
+
+LIBPAM_TACPLUS_INSTALL_STAGING = YES
+LIBPAM_TACPLUS_AUTORECONF = YES
+LIBPAM_TACPLUS_CONF_OPTS = CC="$(TARGET_CC)" LD="$(TARGET_LD)"
+LIBPAM_TACPLUS_AUTORECONF_OPTS = -I m4
+LIBPAM_TACPLUS_LICENSE = GPLv2+
+LIBPAM_TACPLUS_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libpam-tacplus: new package
2015-08-19 20:47 [Buildroot] [PATCH 1/1] libpam-tacplus: new package giovanni.zantedeschi
@ 2015-08-19 22:06 ` Ryan Barnett
2015-08-20 8:02 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Ryan Barnett @ 2015-08-19 22:06 UTC (permalink / raw)
To: buildroot
Hi Giovanni,
Thanks for your contribution - please see the few preliminary comments
that I have below on the patch. I will try to look into this more
extensively later this week.
On Wed, Aug 19, 2015 at 3:47 PM, giovanni.zantedeschi
<giovanni.zantedeschi@datacom.ind.br> wrote:
> From: "Giovanni Zantedeschi" <giovanni.zantedeschi@datacom.ind.br>
>
> Signed-off-by: Giovanni Zantedeschi <giovanni.zantedeschi@datacom.ind.br>
> ---
> package/Config.in | 1 +
> package/libpam-tacplus/Config.in | 5 +++++
> package/libpam-tacplus/libpam-tacplus.mk | 18 ++++++++++++++++++
> 3 files changed, 24 insertions(+)
> create mode 100644 package/libpam-tacplus/Config.in
> create mode 100644 package/libpam-tacplus/libpam-tacplus.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 47d14d7..9e92023 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1074,6 +1074,7 @@ menu "Other"
> source "package/libical/Config.in"
> source "package/liblinear/Config.in"
> source "package/libnspr/Config.in"
> + source "package/libpam-tacplus/Config.in"
> source "package/libpfm4/Config.in"
> source "package/libplatform/Config.in"
> source "package/libplist/Config.in"
> diff --git a/package/libpam-tacplus/Config.in b/package/libpam-tacplus/Config.in
> new file mode 100644
> index 0000000..88d10ff
> --- /dev/null
> +++ b/package/libpam-tacplus/Config.in
> @@ -0,0 +1,5 @@
> + config BR2_PACKAGE_LIBPAM_TACPLUS
> + bool "libpam-tacplus"
> + help
> + Lib needed to use pam-tacplus
Would spell 'Library' out completely. It would also be good if you
could link to the projects homepage as well.
> +
> diff --git a/package/libpam-tacplus/libpam-tacplus.mk b/package/libpam-tacplus/libpam-tacplus.mk
> new file mode 100644
> index 0000000..f788f47
> --- /dev/null
> +++ b/package/libpam-tacplus/libpam-tacplus.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# libpam-tacplus
> +#
> +################################################################################
> +
> +LIBPAM_TACPLUS_VERSION = 1.3.9
> +LIBPAM_TACPLUS_SITE = https://github.com/jeroennijhof/pam_tacplus.git
> +LIBPAM_TACPLUS_SITE_METHOD = git
It would be preferable to use the github download helper:
http://nightly.buildroot.org/manual.html#github-download-url
> +LIBPAM_TACPLUS_INSTALL_STAGING = YES
> +LIBPAM_TACPLUS_AUTORECONF = YES
> +LIBPAM_TACPLUS_CONF_OPTS = CC="$(TARGET_CC)" LD="$(TARGET_LD)"
I'm not sure if this is needed but I could definitely be wrong since I
haven't had a chance to dig into the package. It seems like this is
something that buildroot's autotools package infrastructure should
take care of passing into in order to ensure that it using the correct
compiler.
> +LIBPAM_TACPLUS_AUTORECONF_OPTS = -I m4
> +LIBPAM_TACPLUS_LICENSE = GPLv2+
> +LIBPAM_TACPLUS_LICENSE_FILES = COPYING
> +
> +$(eval $(autotools-package))
Thanks,
-Ryan
--
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libpam-tacplus: new package
2015-08-19 22:06 ` Ryan Barnett
@ 2015-08-20 8:02 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-08-20 8:02 UTC (permalink / raw)
To: buildroot
Ryan, Giovanni,
On Wed, 19 Aug 2015 17:06:00 -0500, Ryan Barnett wrote:
> > diff --git a/package/libpam-tacplus/Config.in b/package/libpam-tacplus/Config.in
> > new file mode 100644
> > index 0000000..88d10ff
> > --- /dev/null
> > +++ b/package/libpam-tacplus/Config.in
> > @@ -0,0 +1,5 @@
> > + config BR2_PACKAGE_LIBPAM_TACPLUS
> > + bool "libpam-tacplus"
> > + help
> > + Lib needed to use pam-tacplus
>
> Would spell 'Library' out completely. It would also be good if you
> could link to the projects homepage as well.
Agreed, but I believe the description could also be improved by
copy/pasting more from the upstream website:
TACACS+ protocol client library and PAM module in C. This PAM
module support authentication, authorization (account
management) and accounting (session management)performed
using TACACS+ protocol designed by Cisco.
> > +LIBPAM_TACPLUS_INSTALL_STAGING = YES
> > +LIBPAM_TACPLUS_AUTORECONF = YES
Please add a comment above this line:
# Fetching from github, we need to generate the configure script
> > +LIBPAM_TACPLUS_CONF_OPTS = CC="$(TARGET_CC)" LD="$(TARGET_LD)"
>
> I'm not sure if this is needed but I could definitely be wrong since I
> haven't had a chance to dig into the package. It seems like this is
> something that buildroot's autotools package infrastructure should
> take care of passing into in order to ensure that it using the correct
> compiler.
The package is using autoconf, but not automake: it uses a hand-written
Makefile. Due to this, passing some variable at build time might be
required. However, it would be useful to try something like:
LIBPAM_TACPLUS_CONF_ENV = $(TARGET_CONFIGURE_OPTS)
instead.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-20 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 20:47 [Buildroot] [PATCH 1/1] libpam-tacplus: new package giovanni.zantedeschi
2015-08-19 22:06 ` Ryan Barnett
2015-08-20 8:02 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox