Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] zyre: fix static builds
@ 2015-08-24  9:31 Vicente Olivert Riera
  2015-08-26  7:16 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Vicente Olivert Riera @ 2015-08-24  9:31 UTC (permalink / raw)
  To: buildroot

zyre package fails to build statically, so we pass the needed libs
directly in order to fix this problem.

Fixes:

  http://autobuild.buildroot.net/results/0ab/0ab4c6a4bb4942d51e7712073d4731d81ecb5251/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
Changes v1 -> v2: add "Fixes" URL.

 package/zyre/zyre.mk |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/package/zyre/zyre.mk b/package/zyre/zyre.mk
index 661dddc..87ed427 100644
--- a/package/zyre/zyre.mk
+++ b/package/zyre/zyre.mk
@@ -12,6 +12,10 @@ ZYRE_INSTALL_STAGING = YES
 ZYRE_DEPENDENCIES = czmq zeromq
 ZYRE_AUTORECONF = YES
 
+ifeq ($(BR2_STATIC_LIBS),y)
+ZYRE_CONF_ENV += LIBS="-lzmq -lstdc++ -lczmq -pthread"
+endif
+
 define ZYRE_CREATE_CONFIG_DIR
 	mkdir -p $(@D)/config
 endef
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2] zyre: fix static builds
  2015-08-24  9:31 [Buildroot] [PATCH v2] zyre: fix static builds Vicente Olivert Riera
@ 2015-08-26  7:16 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-08-26  7:16 UTC (permalink / raw)
  To: buildroot

Vicente,

On Mon, 24 Aug 2015 10:31:06 +0100, Vicente Olivert Riera wrote:
> zyre package fails to build statically, so we pass the needed libs
> directly in order to fix this problem.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/0ab/0ab4c6a4bb4942d51e7712073d4731d81ecb5251/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> Changes v1 -> v2: add "Fixes" URL.

I've committed a different fix, which consists in bumping the version
of zyre. In the latest (unreleased) version of Zyre, pkg-config is used
to find zmq and czmq, which fixes the static linking scenario.

I've therefore marked your patch as Rejected in patchwork.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-26  7:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-24  9:31 [Buildroot] [PATCH v2] zyre: fix static builds Vicente Olivert Riera
2015-08-26  7:16 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox