Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] package/rpm: bump to version 4.12.0.1
Date: Mon, 31 Aug 2015 21:07:33 +0300	[thread overview]
Message-ID: <20150831180733.GL17874@tarshish> (raw)
In-Reply-To: <1441041977-9160-1-git-send-email-james.knight@rockwellcollins.com>

Hi James,

On Mon, Aug 31, 2015 at 01:26:14PM -0400, James Knight wrote:
> The provided "bump" (suggested by Baruch Siach) switches from the rpm5
> implementation to rpm.org's more active stream.
> 
> Signed-off-by: James Knight <james.knight@rockwellcollins.com>
> ---

[...]

> diff --git a/package/rpm/Config.in b/package/rpm/Config.in
> index c6fc3b7..e79e9ce 100644
> --- a/package/rpm/Config.in
> +++ b/package/rpm/Config.in
> @@ -1,21 +1,29 @@
> -comment "rpm needs a toolchain w/ threads"
> +comment "rpm needs a toolchain w/ threads and beecrypt or libnss"
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_PACKAGE_BEECRYPT && !BR2_PACKAGE_LIBNSS
>  	depends on BR2_USE_MMU # fork()
>  
>  config BR2_PACKAGE_RPM
>  	bool "rpm"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # beecrypt
>  	depends on BR2_USE_MMU # fork()
> -	select BR2_PACKAGE_BEECRYPT
> +	depends on BR2_PACKAGE_BEECRYPT || BR2_PACKAGE_LIBNSS

The convention is to do this instead:

	select BR2_PACKAGE_BEECRYPT if !BR2_PACKAGE_LIBNSS

Assuming that beecrypt is more lightweight then libnss (is it?).

This also obviates the need for the dependency comment change above.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      parent reply	other threads:[~2015-08-31 18:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 17:26 [Buildroot] [PATCH v2 1/4] package/rpm: bump to version 4.12.0.1 James Knight
2015-08-31 17:26 ` [Buildroot] [PATCH v2 2/4] package/berkeleydb: add host variant James Knight
2015-08-31 17:26 ` [Buildroot] [PATCH v2 3/4] package/beecrypt: " James Knight
2015-08-31 17:26 ` [Buildroot] [PATCH v2 4/4] package/rpm: " James Knight
2015-08-31 18:07 ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150831180733.GL17874@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox