[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Waldemar Brodkorb]

Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/uclibc/uClibc-ng.config |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config
index 6523585..c17603d 100644
--- a/package/uclibc/uClibc-ng.config
+++ b/package/uclibc/uClibc-ng.config
@@ -24,8 +24,8 @@ UCLIBC_HAS_LIBNSL_STUB=y
 UCLIBC_HAS_CTYPE_CHECKED=y
 UCLIBC_HAS_HEXADECIMAL_FLOATS=y
 UCLIBC_HAS_GLIBC_CUSTOM_PRINTF=y
-# UCLIBC_HAS_STDIO_GETC_MACRO is not set
-# UCLIBC_HAS_STDIO_PUTC_MACRO is not set
+UCLIBC_HAS_STDIO_GETC_MACRO=y
+UCLIBC_HAS_STDIO_PUTC_MACRO=y
 UCLIBC_HAS_FOPEN_EXCLUSIVE_MODE=y
 UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
 UCLIBC_HAS_PRINTF_M_SPEC=y
-- 
1.7.10.4

[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Peter Korsgaard]

>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099
 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

I slightly tweaked the description to make it clear this is for
uClibc-ng and committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Thomas Petazzoni]

Peter, Waldemar,

On Sun, 06 Sep 2015 11:34:51 +0200, Peter Korsgaard wrote:
> >>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:
> 
>  > Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099
>  > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> 
> I slightly tweaked the description to make it clear this is for
> uClibc-ng and committed, thanks.

This is not only for uClibc-ng, it should also be done in
uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Waldemar Brodkorb]

Hi Thomas,
Thomas Petazzoni wrote,

> Peter, Waldemar,
> 
> On Sun, 06 Sep 2015 11:34:51 +0200, Peter Korsgaard wrote:
> > >>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:
> > 
> >  > Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099
> >  > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> > 
> > I slightly tweaked the description to make it clear this is for
> > uClibc-ng and committed, thanks.
> 
> This is not only for uClibc-ng, it should also be done in
> uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.

Yes, would be required.
What about your idea to deprecate uClibc-0.9.33 and snapshot?

best regards
 Waldemar

[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Thomas Petazzoni]

Waldemar,

On Sun, 6 Sep 2015 15:29:29 +0200, Waldemar Brodkorb wrote:

> Yes, would be required.
> What about your idea to deprecate uClibc-0.9.33 and snapshot?

It's an unrelated decision. For now, they are still supported, so the
fix should also be made for them.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Peter, Waldemar,
 > On Sun, 06 Sep 2015 11:34:51 +0200, Peter Korsgaard wrote:
 >> >>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:
 >> 
 >> > Fixes https://bugs.buildroot.org/show_bug.cgi?id=4099
 >> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
 >> 
 >> I slightly tweaked the description to make it clear this is for
 >> uClibc-ng and committed, thanks.

 > This is not only for uClibc-ng, it should also be done in
 > uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.

Possibly, but that was not what the patch did. If this error and
workaround also applies to 0.9.33 / snapshot, then lets please also
adjust it there. Waldemar?

-- 
Venlig hilsen,
Peter Korsgaard 

[Buildroot] [PATCH 2/3] uclibc: fix coreutils cut bug, enable needed config symbols

[Thomas Petazzoni]

Peter,

On Sun, 06 Sep 2015 15:34:28 +0200, Peter Korsgaard wrote:

>  >> I slightly tweaked the description to make it clear this is for
>  >> uClibc-ng and committed, thanks.
> 
>  > This is not only for uClibc-ng, it should also be done in
>  > uClibc-0.9.33.config and uClibc-snapshot.config, as far as I understand.
> 
> Possibly, but that was not what the patch did.

Well, that's precisely what I'm saying: you changed the commit log to
"make it clear it's for uclibc-ng", and I'm saying that the issue is
not uClibc-ng specific. It also applies to other uClibc versions.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com