[Buildroot] [PATCH v2] Enable vlc to run as root

[Buildroot] [PATCH v2] Enable vlc to run as root

[jpinto]

From: Joao Pinto <jpinto@synopsys.com>

A great number of embedded systems only include the root user.
This patch has the goal of enabling vlc to be ran as root.

Signed-off-by: Joao Pinto <jpinto@synopsys.com>
Tested-by: Joao Pinto <jpinto@synopsys.com>
---
 package/vlc/vlc.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index 6f7fd58..4e84b12 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -54,6 +54,7 @@ VLC_CONF_OPTS += \
 	--disable-mfx \
 	--disable-vdpau \
 	--disable-addonmanagermodules \
+	--enable-run-as-root \
 
 # Building static and shared doesn't work, so force static off.
 ifeq ($(BR2_STATIC_LIBS),)
-- 
1.8.1.5

[Buildroot] [PATCH v2] Enable vlc to run as root

[Thomas Petazzoni]

Hello Joao,

Thanks for this new iteration. It looks good, except for one minor nit
that isn't very important, but worth mentioning.

On Wed, 16 Sep 2015 09:26:49 +0100, jpinto wrote:
> From: Joao Pinto <jpinto@synopsys.com>
> 
> A great number of embedded systems only include the root user.
> This patch has the goal of enabling vlc to be ran as root.
> 
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> Tested-by: Joao Pinto <jpinto@synopsys.com>

It doesn't make sense to include a Tested-by from you on your patch. We
obviously expect that you have tested your own patch. Tested-by tags
(as well as Acked-by or Reviewed-by tags) are meant to be given by
*other* developers, after testing and/or reviewing your patch.

The other minor nit is that the title of the commit still doesn't match
the Buildroot best practice, which consists in using titles having the
following format:

	<package>: <description>

So in your case, it should be:

	vlc: enable to run as root

Both issues can be fixed by the Buildroot maintainer when he applies
the patch, but I wanted to let you know so you can make things better
for your next contribution!

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] Enable vlc to run as root

[Joao Pinto]

Hello Thomas,

On 9/16/2015 11:36 AM, Thomas Petazzoni wrote:
> Hello Joao,
> 
> Thanks for this new iteration. It looks good, except for one minor nit
> that isn't very important, but worth mentioning.
> 
> On Wed, 16 Sep 2015 09:26:49 +0100, jpinto wrote:
>> From: Joao Pinto <jpinto@synopsys.com>
>>
>> A great number of embedded systems only include the root user.
>> This patch has the goal of enabling vlc to be ran as root.
>>
>> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>> Tested-by: Joao Pinto <jpinto@synopsys.com>
> 
> It doesn't make sense to include a Tested-by from you on your patch. We
> obviously expect that you have tested your own patch. Tested-by tags
> (as well as Acked-by or Reviewed-by tags) are meant to be given by
> *other* developers, after testing and/or reviewing your patch.
> 
> The other minor nit is that the title of the commit still doesn't match
> the Buildroot best practice, which consists in using titles having the
> following format:
> 
> 	<package>: <description>
> 
> So in your case, it should be:
> 
> 	vlc: enable to run as root
> 

Understood, I will have it in mind in future contributions.

> Both issues can be fixed by the Buildroot maintainer when he applies
> the patch, but I wanted to let you know so you can make things better
> for your next contribution!
> 
> Thanks!
> 
> Thomas
> 

Thanks,
Joao

[Buildroot] [PATCH v2] Enable vlc to run as root

[Thomas Petazzoni]

Hello,

On Wed, 16 Sep 2015 09:26:49 +0100, jpinto wrote:
> From: Joao Pinto <jpinto@synopsys.com>
> 
> A great number of embedded systems only include the root user.
> This patch has the goal of enabling vlc to be ran as root.
> 
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> Tested-by: Joao Pinto <jpinto@synopsys.com>
> ---
>  package/vlc/vlc.mk | 1 +
>  1 file changed, 1 insertion(+)

Thanks, I've applied after tweaking the commit.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] Enable vlc to run as root

[Joao Pinto]

Hi Thomas,

Something strange indeed. I will send you a new one in a sec.

Thanks,
Joao

-----Original Message-----
From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com] 
Sent: Wednesday, September 16, 2015 9:35 PM
To: jpinto
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH v2] Enable vlc to run as root

Hello,

On Wed, 16 Sep 2015 09:26:49 +0100, jpinto wrote:
> From: Joao Pinto <jpinto@synopsys.com>
> 
> A great number of embedded systems only include the root user.
> This patch has the goal of enabling vlc to be ran as root.
> 
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> Tested-by: Joao Pinto <jpinto@synopsys.com>
> ---
>  package/vlc/vlc.mk | 1 +
>  1 file changed, 1 insertion(+)

Thanks, I've applied after tweaking the commit.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering http://free-electrons.com