Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libseccomp: Add new config option to build and install tests
Date: Sun, 20 Sep 2015 14:46:37 +0200	[thread overview]
Message-ID: <20150920144637.25230558@free-electrons.com> (raw)
In-Reply-To: <1442564371-10498-1-git-send-email-markos.chandras@imgtec.com>

Markos,

On Fri, 18 Sep 2015 09:19:31 +0100, Markos Chandras wrote:

> +ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
> +
> +LIBSECCOMP_MAKE_OPTS += check-build
> +
> +define LIBSECCOMP_TESTS_INSTALL
> +	mkdir -p $(TARGET_DIR)/usr/libseccomp/{tests,tools} && \
> +	for x in tests tools; do \
> +		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) \
> +			-type f -exec cp {} $(TARGET_DIR)/usr/libseccomp/$$x/ \; ; \

This has the effect of installing one .py file for each test even if
Python is not installed on the target. They are pretty small, so maybe
we don't care, but it doesn't look really nice.

Also, this whole thing seems pretty crappy in libseccomp. Why don't
they have simply a --enable-tests option, which will simply do the
right thing?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-09-20 12:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 13:53 [Buildroot] [PATCH] libseccomp: Add new config option to build and install tests Markos Chandras
2015-09-17 17:02 ` Vicente Olivert Riera
2015-09-18  8:19   ` [Buildroot] [PATCH v2] " Markos Chandras
2015-09-18  8:36     ` Vicente Olivert Riera
2015-09-18  8:39       ` Vicente Olivert Riera
2015-09-20 12:46     ` Thomas Petazzoni [this message]
2015-09-21  8:39       ` Markos Chandras
2015-09-21  9:28       ` [Buildroot] [PATCH v3] " Markos Chandras
2015-09-21 10:40         ` Vicente Olivert Riera
2015-10-02  8:24         ` Markos Chandras
2015-11-10  9:49           ` Markos Chandras
2015-11-10 10:00             ` Thomas Petazzoni
2015-11-10 10:14               ` Markos Chandras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150920144637.25230558@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox