Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libseccomp: Add new config option to build and install tests
@ 2015-09-17 13:53 Markos Chandras
  2015-09-17 17:02 ` Vicente Olivert Riera
  0 siblings, 1 reply; 13+ messages in thread
From: Markos Chandras @ 2015-09-17 13:53 UTC (permalink / raw)
  To: buildroot

Add new config option to allow building and installing the libseccomp
testsuite on the target. It's useful for testing the kernels'
seccomp behavior for the target architecture.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 package/libseccomp/Config.in     |  9 +++++++++
 package/libseccomp/libseccomp.mk | 19 +++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/package/libseccomp/Config.in b/package/libseccomp/Config.in
index 4c34c5466592..760a6f321142 100644
--- a/package/libseccomp/Config.in
+++ b/package/libseccomp/Config.in
@@ -15,6 +15,15 @@ config BR2_PACKAGE_LIBSECCOMP
 
 	  https://github.com/seccomp/libseccomp
 
+config BR2_PACKAGE_LIBSECCOMP_TESTS
+	bool "Install libseccomp tests"
+	depends on BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
+	help
+	  Build and install the libseccomp testsuite.
+
+comment "libseccomp testsuite needs bash as running shell"
+	depends on !BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
+
 comment "libseccomp needs a toolchain w/ headers >= 3.12"
 	depends on BR2_aarch64 || BR2_mips || BR2_mipsel || BR2_mips64 || \
 		BR2_mips64el || BR2_i386 || BR2_x86_64
diff --git a/package/libseccomp/libseccomp.mk b/package/libseccomp/libseccomp.mk
index a188298006b1..6edf96f92bfa 100644
--- a/package/libseccomp/libseccomp.mk
+++ b/package/libseccomp/libseccomp.mk
@@ -17,4 +17,23 @@ define LIBSECCOMP_FIXUP_M4_DIR
 endef
 LIBSECCOMP_POST_EXTRACT_HOOKS += LIBSECCOMP_FIXUP_M4_DIR
 
+ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
+
+define LIBSECCOMP_TESTS_BUILD
+	$(MAKE) -C $(@D)/tests check-build
+endef
+
+define LIBSECCOMP_TESTS_INSTALL
+	mkdir -p $(TARGET_DIR)/usr/libseccomp/{tests,tools} && \
+	for x in tests tools; do \
+		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) \
+			-type f -exec cp {} $(TARGET_DIR)/usr/libseccomp/$$x/ \; ; \
+	done
+endef
+
+LIBSECCOMP_POST_BUILD_HOOKS += LIBSECCOMP_TESTS_BUILD
+LIBSECCOMP_POST_INSTALL_TARGET_HOOKS += LIBSECCOMP_TESTS_INSTALL
+
+endif
+
 $(eval $(autotools-package))
-- 
2.5.2

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] libseccomp: Add new config option to build and install tests
  2015-09-17 13:53 [Buildroot] [PATCH] libseccomp: Add new config option to build and install tests Markos Chandras
@ 2015-09-17 17:02 ` Vicente Olivert Riera
  2015-09-18  8:19   ` [Buildroot] [PATCH v2] " Markos Chandras
  0 siblings, 1 reply; 13+ messages in thread
From: Vicente Olivert Riera @ 2015-09-17 17:02 UTC (permalink / raw)
  To: buildroot

Dear Markos Chandras,

On 09/17/2015 02:53 PM, Markos Chandras wrote:
[snip]
> diff --git a/package/libseccomp/libseccomp.mk b/package/libseccomp/libseccomp.mk
> index a188298006b1..6edf96f92bfa 100644
> --- a/package/libseccomp/libseccomp.mk
> +++ b/package/libseccomp/libseccomp.mk
> @@ -17,4 +17,23 @@ define LIBSECCOMP_FIXUP_M4_DIR
>  endef
>  LIBSECCOMP_POST_EXTRACT_HOOKS += LIBSECCOMP_FIXUP_M4_DIR
>  
> +ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
> +
> +define LIBSECCOMP_TESTS_BUILD
> +	$(MAKE) -C $(@D)/tests check-build

You should be adding $(TARGET_MAKE_ENV) in front of $(MAKE). Anyway,
there is a better solution which will make this define unnecessary. See
comments below.

> +endef

Instead of doing a define to build the tests, you can change the target
and use the 'check-build' one, which will not only build the tests and
tools, but also will trigger the 'all' target. So:

ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
# The 'check-build' target builds the tests and tools, and also
# triggers the 'all' target.
LIBSECCOMP_MAKE_OPTS += check-build

> +define LIBSECCOMP_TESTS_INSTALL
> +	mkdir -p $(TARGET_DIR)/usr/libseccomp/{tests,tools} && \
> +	for x in tests tools; do \
> +		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) \
> +			-type f -exec cp {} $(TARGET_DIR)/usr/libseccomp/$$x/ \; ; \
> +	done
> +endef
> +

I would remove this empty line since you are adding to the hooks
variable the define immediately above.

> +LIBSECCOMP_POST_BUILD_HOOKS += LIBSECCOMP_TESTS_BUILD

This post-build hook is not needed since the define has been replaced by
the LIBSECCOMP_MAKE_OPTS line.

> +LIBSECCOMP_POST_INSTALL_TARGET_HOOKS += LIBSECCOMP_TESTS_INSTALL
> +

And I would remove this empty line as well.

Regards,

Vincent.

> +endif
> +
>  $(eval $(autotools-package))
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] libseccomp: Add new config option to build and install tests
  2015-09-17 17:02 ` Vicente Olivert Riera
@ 2015-09-18  8:19   ` Markos Chandras
  2015-09-18  8:36     ` Vicente Olivert Riera
  2015-09-20 12:46     ` Thomas Petazzoni
  0 siblings, 2 replies; 13+ messages in thread
From: Markos Chandras @ 2015-09-18  8:19 UTC (permalink / raw)
  To: buildroot

Add new config option to allow building and installing the libseccomp
testsuite on the target. It's useful for testing the kernels'
seccomp behavior for the target architecture.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
changes since v1:
- Drop compile hook for tests and use MAKE_OPTS instead
---
 package/libseccomp/Config.in     |  9 +++++++++
 package/libseccomp/libseccomp.mk | 16 ++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/package/libseccomp/Config.in b/package/libseccomp/Config.in
index 4c34c5466592..760a6f321142 100644
--- a/package/libseccomp/Config.in
+++ b/package/libseccomp/Config.in
@@ -15,6 +15,15 @@ config BR2_PACKAGE_LIBSECCOMP
 
 	  https://github.com/seccomp/libseccomp
 
+config BR2_PACKAGE_LIBSECCOMP_TESTS
+	bool "Install libseccomp tests"
+	depends on BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
+	help
+	  Build and install the libseccomp testsuite.
+
+comment "libseccomp testsuite needs bash as running shell"
+	depends on !BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
+
 comment "libseccomp needs a toolchain w/ headers >= 3.12"
 	depends on BR2_aarch64 || BR2_mips || BR2_mipsel || BR2_mips64 || \
 		BR2_mips64el || BR2_i386 || BR2_x86_64
diff --git a/package/libseccomp/libseccomp.mk b/package/libseccomp/libseccomp.mk
index a188298006b1..5ebd8c54ac1f 100644
--- a/package/libseccomp/libseccomp.mk
+++ b/package/libseccomp/libseccomp.mk
@@ -17,4 +17,20 @@ define LIBSECCOMP_FIXUP_M4_DIR
 endef
 LIBSECCOMP_POST_EXTRACT_HOOKS += LIBSECCOMP_FIXUP_M4_DIR
 
+ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
+
+LIBSECCOMP_MAKE_OPTS += check-build
+
+define LIBSECCOMP_TESTS_INSTALL
+	mkdir -p $(TARGET_DIR)/usr/libseccomp/{tests,tools} && \
+	for x in tests tools; do \
+		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) \
+			-type f -exec cp {} $(TARGET_DIR)/usr/libseccomp/$$x/ \; ; \
+	done
+endef
+
+LIBSECCOMP_POST_INSTALL_TARGET_HOOKS += LIBSECCOMP_TESTS_INSTALL
+
+endif
+
 $(eval $(autotools-package))
-- 
2.5.2

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] libseccomp: Add new config option to build and install tests
  2015-09-18  8:19   ` [Buildroot] [PATCH v2] " Markos Chandras
@ 2015-09-18  8:36     ` Vicente Olivert Riera
  2015-09-18  8:39       ` Vicente Olivert Riera
  2015-09-20 12:46     ` Thomas Petazzoni
  1 sibling, 1 reply; 13+ messages in thread
From: Vicente Olivert Riera @ 2015-09-18  8:36 UTC (permalink / raw)
  To: buildroot

Dear Markos Chandras,

On 09/18/2015 09:19 AM, Markos Chandras wrote:
> Add new config option to allow building and installing the libseccomp
> testsuite on the target. It's useful for testing the kernels'
> seccomp behavior for the target architecture.
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> Tested-by:
Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Build test for MIPS architecture:

$ file output/target/usr/libseccomp/tests/01-sim-allow
output/target/usr/libseccomp/tests/01-sim-allow: ELF 32-bit MSB
executable, MIPS, MIPS32 rel2 version 1 (SYSV), dynamically linked (uses
shared libs), for GNU/Linux 2.6.32, with unknown capability 0x41000000 =
0xf676e75, with unknown capability 0x10000 = 0x70403, stripped

Regards,

Vincent.

> ---
> changes since v1:
> - Drop compile hook for tests and use MAKE_OPTS instead
> ---
>  package/libseccomp/Config.in     |  9 +++++++++
>  package/libseccomp/libseccomp.mk | 16 ++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/package/libseccomp/Config.in b/package/libseccomp/Config.in
> index 4c34c5466592..760a6f321142 100644
> --- a/package/libseccomp/Config.in
> +++ b/package/libseccomp/Config.in
> @@ -15,6 +15,15 @@ config BR2_PACKAGE_LIBSECCOMP
>  
>  	  https://github.com/seccomp/libseccomp
>  
> +config BR2_PACKAGE_LIBSECCOMP_TESTS
> +	bool "Install libseccomp tests"
> +	depends on BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
> +	help
> +	  Build and install the libseccomp testsuite.
> +
> +comment "libseccomp testsuite needs bash as running shell"
> +	depends on !BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
> +
>  comment "libseccomp needs a toolchain w/ headers >= 3.12"
>  	depends on BR2_aarch64 || BR2_mips || BR2_mipsel || BR2_mips64 || \
>  		BR2_mips64el || BR2_i386 || BR2_x86_64
> diff --git a/package/libseccomp/libseccomp.mk b/package/libseccomp/libseccomp.mk
> index a188298006b1..5ebd8c54ac1f 100644
> --- a/package/libseccomp/libseccomp.mk
> +++ b/package/libseccomp/libseccomp.mk
> @@ -17,4 +17,20 @@ define LIBSECCOMP_FIXUP_M4_DIR
>  endef
>  LIBSECCOMP_POST_EXTRACT_HOOKS += LIBSECCOMP_FIXUP_M4_DIR
>  
> +ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
> +
> +LIBSECCOMP_MAKE_OPTS += check-build
> +
> +define LIBSECCOMP_TESTS_INSTALL
> +	mkdir -p $(TARGET_DIR)/usr/libseccomp/{tests,tools} && \
> +	for x in tests tools; do \
> +		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) \
> +			-type f -exec cp {} $(TARGET_DIR)/usr/libseccomp/$$x/ \; ; \
> +	done
> +endef
> +
> +LIBSECCOMP_POST_INSTALL_TARGET_HOOKS += LIBSECCOMP_TESTS_INSTALL
> +
> +endif
> +
>  $(eval $(autotools-package))
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] libseccomp: Add new config option to build and install tests
  2015-09-18  8:36     ` Vicente Olivert Riera
@ 2015-09-18  8:39       ` Vicente Olivert Riera
  0 siblings, 0 replies; 13+ messages in thread
From: Vicente Olivert Riera @ 2015-09-18  8:39 UTC (permalink / raw)
  To: buildroot

Sorry all,

my email client did something weird with my tested-by tag and patchwork
is not detecting it correctly. Now it will.

Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Regards,

Vincent.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] libseccomp: Add new config option to build and install tests
  2015-09-18  8:19   ` [Buildroot] [PATCH v2] " Markos Chandras
  2015-09-18  8:36     ` Vicente Olivert Riera
@ 2015-09-20 12:46     ` Thomas Petazzoni
  2015-09-21  8:39       ` Markos Chandras
  2015-09-21  9:28       ` [Buildroot] [PATCH v3] " Markos Chandras
  1 sibling, 2 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2015-09-20 12:46 UTC (permalink / raw)
  To: buildroot

Markos,

On Fri, 18 Sep 2015 09:19:31 +0100, Markos Chandras wrote:

> +ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
> +
> +LIBSECCOMP_MAKE_OPTS += check-build
> +
> +define LIBSECCOMP_TESTS_INSTALL
> +	mkdir -p $(TARGET_DIR)/usr/libseccomp/{tests,tools} && \
> +	for x in tests tools; do \
> +		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) \
> +			-type f -exec cp {} $(TARGET_DIR)/usr/libseccomp/$$x/ \; ; \

This has the effect of installing one .py file for each test even if
Python is not installed on the target. They are pretty small, so maybe
we don't care, but it doesn't look really nice.

Also, this whole thing seems pretty crappy in libseccomp. Why don't
they have simply a --enable-tests option, which will simply do the
right thing?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] libseccomp: Add new config option to build and install tests
  2015-09-20 12:46     ` Thomas Petazzoni
@ 2015-09-21  8:39       ` Markos Chandras
  2015-09-21  9:28       ` [Buildroot] [PATCH v3] " Markos Chandras
  1 sibling, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2015-09-21  8:39 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

On 09/20/2015 01:46 PM, Thomas Petazzoni wrote:
> Markos,
> 
> On Fri, 18 Sep 2015 09:19:31 +0100, Markos Chandras wrote:
> 
>> +ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
>> +
>> +LIBSECCOMP_MAKE_OPTS += check-build
>> +
>> +define LIBSECCOMP_TESTS_INSTALL
>> +	mkdir -p $(TARGET_DIR)/usr/libseccomp/{tests,tools} && \
>> +	for x in tests tools; do \
>> +		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) \
>> +			-type f -exec cp {} $(TARGET_DIR)/usr/libseccomp/$$x/ \; ; \
> 
> This has the effect of installing one .py file for each test even if
> Python is not installed on the target. They are pretty small, so maybe
> we don't care, but it doesn't look really nice.

Hmm makes sense. I will rework it then.

> 
> Also, this whole thing seems pretty crappy in libseccomp. Why don't
> they have simply a --enable-tests option, which will simply do the
> right thing?

It's probably because this is yet another testsuite and like any other
package testsuite you don't really need it installed. it's supposed to
run as part of package verification during build and installation. but
for cross-builds, it's useful to have it on the target.

-- 
markos

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] libseccomp: Add new config option to build and install tests
  2015-09-20 12:46     ` Thomas Petazzoni
  2015-09-21  8:39       ` Markos Chandras
@ 2015-09-21  9:28       ` Markos Chandras
  2015-09-21 10:40         ` Vicente Olivert Riera
  2015-10-02  8:24         ` Markos Chandras
  1 sibling, 2 replies; 13+ messages in thread
From: Markos Chandras @ 2015-09-21  9:28 UTC (permalink / raw)
  To: buildroot

Add new config option to allow building and installing the libseccomp
testsuite on the target. It's useful for testing the kernels'
seccomp behavior for the target architecture.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
changes since v2:
- Move installation path for tests to /usr/share/libseccomp
- Do not install python files. We don't support python + libseccomp
at the moment so there is no point in installing these tests yet.

changes since v1:
- Drop compile hook for tests and use MAKE_OPTS instead
---
 package/libseccomp/Config.in     |  9 +++++++++
 package/libseccomp/libseccomp.mk | 16 ++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/package/libseccomp/Config.in b/package/libseccomp/Config.in
index 4c34c5466592..760a6f321142 100644
--- a/package/libseccomp/Config.in
+++ b/package/libseccomp/Config.in
@@ -15,6 +15,15 @@ config BR2_PACKAGE_LIBSECCOMP
 
 	  https://github.com/seccomp/libseccomp
 
+config BR2_PACKAGE_LIBSECCOMP_TESTS
+	bool "Install libseccomp tests"
+	depends on BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
+	help
+	  Build and install the libseccomp testsuite.
+
+comment "libseccomp testsuite needs bash as running shell"
+	depends on !BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
+
 comment "libseccomp needs a toolchain w/ headers >= 3.12"
 	depends on BR2_aarch64 || BR2_mips || BR2_mipsel || BR2_mips64 || \
 		BR2_mips64el || BR2_i386 || BR2_x86_64
diff --git a/package/libseccomp/libseccomp.mk b/package/libseccomp/libseccomp.mk
index a188298006b1..e6e578b85561 100644
--- a/package/libseccomp/libseccomp.mk
+++ b/package/libseccomp/libseccomp.mk
@@ -17,4 +17,20 @@ define LIBSECCOMP_FIXUP_M4_DIR
 endef
 LIBSECCOMP_POST_EXTRACT_HOOKS += LIBSECCOMP_FIXUP_M4_DIR
 
+ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
+
+LIBSECCOMP_MAKE_OPTS += check-build
+
+define LIBSECCOMP_TESTS_INSTALL
+	mkdir -p $(TARGET_DIR)/usr/share/libseccomp/{tests,tools} && \
+	for x in tests tools; do \
+		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) -a ! -name "*.py" \
+			-type f -exec cp {} $(TARGET_DIR)/usr/share/libseccomp/$$x/ \; ; \
+	done
+endef
+
+LIBSECCOMP_POST_INSTALL_TARGET_HOOKS += LIBSECCOMP_TESTS_INSTALL
+
+endif
+
 $(eval $(autotools-package))
-- 
2.5.2

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] libseccomp: Add new config option to build and install tests
  2015-09-21  9:28       ` [Buildroot] [PATCH v3] " Markos Chandras
@ 2015-09-21 10:40         ` Vicente Olivert Riera
  2015-10-02  8:24         ` Markos Chandras
  1 sibling, 0 replies; 13+ messages in thread
From: Vicente Olivert Riera @ 2015-09-21 10:40 UTC (permalink / raw)
  To: buildroot

Dear Markos Chandras,

could you please mark your previous patch as superseded?

http://patchwork.ozlabs.org/patch/519170/

On 09/21/2015 10:28 AM, Markos Chandras wrote:
> Add new config option to allow building and installing the libseccomp
> testsuite on the target. It's useful for testing the kernels'
> seccomp behavior for the target architecture.
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Build test for MIPS architecture. All fine. Binary files built for the
right architecture and no more .py files installed on target. Checked
that now the tests and tools are installed in /usr/share/libseccomp/.

Regards,

Vincent.

> ---
> changes since v2:
> - Move installation path for tests to /usr/share/libseccomp
> - Do not install python files. We don't support python + libseccomp
> at the moment so there is no point in installing these tests yet.
> 
> changes since v1:
> - Drop compile hook for tests and use MAKE_OPTS instead
> ---
>  package/libseccomp/Config.in     |  9 +++++++++
>  package/libseccomp/libseccomp.mk | 16 ++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/package/libseccomp/Config.in b/package/libseccomp/Config.in
> index 4c34c5466592..760a6f321142 100644
> --- a/package/libseccomp/Config.in
> +++ b/package/libseccomp/Config.in
> @@ -15,6 +15,15 @@ config BR2_PACKAGE_LIBSECCOMP
>  
>  	  https://github.com/seccomp/libseccomp
>  
> +config BR2_PACKAGE_LIBSECCOMP_TESTS
> +	bool "Install libseccomp tests"
> +	depends on BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
> +	help
> +	  Build and install the libseccomp testsuite.
> +
> +comment "libseccomp testsuite needs bash as running shell"
> +	depends on !BR2_PACKAGE_BASH && BR2_PACKAGE_LIBSECCOMP
> +
>  comment "libseccomp needs a toolchain w/ headers >= 3.12"
>  	depends on BR2_aarch64 || BR2_mips || BR2_mipsel || BR2_mips64 || \
>  		BR2_mips64el || BR2_i386 || BR2_x86_64
> diff --git a/package/libseccomp/libseccomp.mk b/package/libseccomp/libseccomp.mk
> index a188298006b1..e6e578b85561 100644
> --- a/package/libseccomp/libseccomp.mk
> +++ b/package/libseccomp/libseccomp.mk
> @@ -17,4 +17,20 @@ define LIBSECCOMP_FIXUP_M4_DIR
>  endef
>  LIBSECCOMP_POST_EXTRACT_HOOKS += LIBSECCOMP_FIXUP_M4_DIR
>  
> +ifeq ($(BR2_PACKAGE_LIBSECCOMP_TESTS),y)
> +
> +LIBSECCOMP_MAKE_OPTS += check-build
> +
> +define LIBSECCOMP_TESTS_INSTALL
> +	mkdir -p $(TARGET_DIR)/usr/share/libseccomp/{tests,tools} && \
> +	for x in tests tools; do \
> +		find $(@D)/$$x -maxdepth 1 \( -name "*.tests" -o -perm -a=x \) -a ! -name "*.py" \
> +			-type f -exec cp {} $(TARGET_DIR)/usr/share/libseccomp/$$x/ \; ; \
> +	done
> +endef
> +
> +LIBSECCOMP_POST_INSTALL_TARGET_HOOKS += LIBSECCOMP_TESTS_INSTALL
> +
> +endif
> +
>  $(eval $(autotools-package))
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] libseccomp: Add new config option to build and install tests
  2015-09-21  9:28       ` [Buildroot] [PATCH v3] " Markos Chandras
  2015-09-21 10:40         ` Vicente Olivert Riera
@ 2015-10-02  8:24         ` Markos Chandras
  2015-11-10  9:49           ` Markos Chandras
  1 sibling, 1 reply; 13+ messages in thread
From: Markos Chandras @ 2015-10-02  8:24 UTC (permalink / raw)
  To: buildroot

On 09/21/2015 10:28 AM, Markos Chandras wrote:
> Add new config option to allow building and installing the libseccomp
> testsuite on the target. It's useful for testing the kernels'
> seccomp behavior for the target architecture.
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> changes since v2:
> - Move installation path for tests to /usr/share/libseccomp
> - Do not install python files. We don't support python + libseccomp
> at the moment so there is no point in installing these tests yet.
> 
> changes since v1:
> - Drop compile hook for tests and use MAKE_OPTS instead
> ---

ping?

-- 
markos

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] libseccomp: Add new config option to build and install tests
  2015-10-02  8:24         ` Markos Chandras
@ 2015-11-10  9:49           ` Markos Chandras
  2015-11-10 10:00             ` Thomas Petazzoni
  0 siblings, 1 reply; 13+ messages in thread
From: Markos Chandras @ 2015-11-10  9:49 UTC (permalink / raw)
  To: buildroot

On 10/02/2015 09:24 AM, Markos Chandras wrote:
> On 09/21/2015 10:28 AM, Markos Chandras wrote:
>> Add new config option to allow building and installing the libseccomp
>> testsuite on the target. It's useful for testing the kernels'
>> seccomp behavior for the target architecture.
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> changes since v2:
>> - Move installation path for tests to /usr/share/libseccomp
>> - Do not install python files. We don't support python + libseccomp
>> at the moment so there is no point in installing these tests yet.
>>
>> changes since v1:
>> - Drop compile hook for tests and use MAKE_OPTS instead
>> ---
> 
> ping?
> 
ping?

-- 
markos

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] libseccomp: Add new config option to build and install tests
  2015-11-10  9:49           ` Markos Chandras
@ 2015-11-10 10:00             ` Thomas Petazzoni
  2015-11-10 10:14               ` Markos Chandras
  0 siblings, 1 reply; 13+ messages in thread
From: Thomas Petazzoni @ 2015-11-10 10:00 UTC (permalink / raw)
  To: buildroot

Markos,

On Tue, 10 Nov 2015 09:49:45 +0000, Markos Chandras wrote:

> ping?

I think the reason I still don't apply this patch is because I'm not
happy with Buildroot doing all this complicated logic to install the
tests, and that it should be part of the libseccomp build system to
provide a mechanism to do that easily.

So if you want to see this integrated, I would recommend to work with
upstream libseccomp to implement something allowing the installation of
tests, and then use it in Buildroot.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] libseccomp: Add new config option to build and install tests
  2015-11-10 10:00             ` Thomas Petazzoni
@ 2015-11-10 10:14               ` Markos Chandras
  0 siblings, 0 replies; 13+ messages in thread
From: Markos Chandras @ 2015-11-10 10:14 UTC (permalink / raw)
  To: buildroot

On 11/10/2015 10:00 AM, Thomas Petazzoni wrote:
> Markos,
> 
> On Tue, 10 Nov 2015 09:49:45 +0000, Markos Chandras wrote:
> 
>> ping?
> 
> I think the reason I still don't apply this patch is because I'm not
> happy with Buildroot doing all this complicated logic to install the
> tests, and that it should be part of the libseccomp build system to
> provide a mechanism to do that easily.
> 
> So if you want to see this integrated, I would recommend to work with
> upstream libseccomp to implement something allowing the installation of
> tests, and then use it in Buildroot.

Hi Thomas,

Ok fair enough

-- 
markos

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2015-11-10 10:14 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-17 13:53 [Buildroot] [PATCH] libseccomp: Add new config option to build and install tests Markos Chandras
2015-09-17 17:02 ` Vicente Olivert Riera
2015-09-18  8:19   ` [Buildroot] [PATCH v2] " Markos Chandras
2015-09-18  8:36     ` Vicente Olivert Riera
2015-09-18  8:39       ` Vicente Olivert Riera
2015-09-20 12:46     ` Thomas Petazzoni
2015-09-21  8:39       ` Markos Chandras
2015-09-21  9:28       ` [Buildroot] [PATCH v3] " Markos Chandras
2015-09-21 10:40         ` Vicente Olivert Riera
2015-10-02  8:24         ` Markos Chandras
2015-11-10  9:49           ` Markos Chandras
2015-11-10 10:00             ` Thomas Petazzoni
2015-11-10 10:14               ` Markos Chandras

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox