Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/2] Early boot fixes
@ 2015-09-21 16:29 Luca Ceresoli
  2015-09-21 16:29 ` [Buildroot] [PATCH 1/2] busybox: inittab: don't redirect output to /dev/null Luca Ceresoli
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Luca Ceresoli @ 2015-09-21 16:29 UTC (permalink / raw)
  To: buildroot

Hi,

my mdev-without-devtmpfs highlighted a couple errors that are not strictly
related to that work. And since that work might or not have a v2, and is
not very likely to be merged at all, let's have the two small fixes rolling
on their own.

Enjoy!

Luca Ceresoli (2):
  busybox: inittab: don't redirect output to /dev/null
  skeleton: fix absence of /dev/shm on static, read-only systems

 package/busybox/inittab        | 12 ++++++------
 system/skeleton/dev/shm/.empty |  0
 2 files changed, 6 insertions(+), 6 deletions(-)
 create mode 100644 system/skeleton/dev/shm/.empty

-- 
1.9.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2] busybox: inittab: don't redirect output to /dev/null
  2015-09-21 16:29 [Buildroot] [PATCH 0/2] Early boot fixes Luca Ceresoli
@ 2015-09-21 16:29 ` Luca Ceresoli
  2015-09-21 20:57   ` Yann E. MORIN
  2015-09-21 16:29 ` [Buildroot] [PATCH 2/2] skeleton: fix absence of /dev/shm on static, read-only systems Luca Ceresoli
  2015-10-03 13:35 ` [Buildroot] [PATCH 0/2] Early boot fixes Peter Korsgaard
  2 siblings, 1 reply; 6+ messages in thread
From: Luca Ceresoli @ 2015-09-21 16:29 UTC (permalink / raw)
  To: buildroot

Several inittab steps are redirected to /dev/null. This means any error or
warning printed by these crucial commands would be hidden from the user.
There is no evident reason to hide this output, so stop doing that.

Suggested by Thomas Petazzoni:
http://lists.busybox.net/pipermail/buildroot/2015-September/139146.html

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/busybox/inittab | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/package/busybox/inittab b/package/busybox/inittab
index b1892c1..24d9199 100644
--- a/package/busybox/inittab
+++ b/package/busybox/inittab
@@ -14,12 +14,12 @@
 # process   == program to run
 
 # Startup the system
-null::sysinit:/bin/mount -t proc proc /proc
-null::sysinit:/bin/mount -o remount,rw /
-null::sysinit:/bin/mkdir -p /dev/pts
-null::sysinit:/bin/mkdir -p /dev/shm
-null::sysinit:/bin/mount -a
-null::sysinit:/bin/hostname -F /etc/hostname
+::sysinit:/bin/mount -t proc proc /proc
+::sysinit:/bin/mount -o remount,rw /
+::sysinit:/bin/mkdir -p /dev/pts
+::sysinit:/bin/mkdir -p /dev/shm
+::sysinit:/bin/mount -a
+::sysinit:/bin/hostname -F /etc/hostname
 # now run any rc scripts
 ::sysinit:/etc/init.d/rcS
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] skeleton: fix absence of /dev/shm on static, read-only systems
  2015-09-21 16:29 [Buildroot] [PATCH 0/2] Early boot fixes Luca Ceresoli
  2015-09-21 16:29 ` [Buildroot] [PATCH 1/2] busybox: inittab: don't redirect output to /dev/null Luca Ceresoli
@ 2015-09-21 16:29 ` Luca Ceresoli
  2015-09-21 20:59   ` Yann E. MORIN
  2015-10-03 13:35 ` [Buildroot] [PATCH 0/2] Early boot fixes Peter Korsgaard
  2 siblings, 1 reply; 6+ messages in thread
From: Luca Ceresoli @ 2015-09-21 16:29 UTC (permalink / raw)
  To: buildroot

/dev/shm is needed for systems using shared memory. On init-based systems
this directory is usually created in the inittab along with /dev/pts, by
the lines:

package/busybox/inittab:
  ::sysinit:/bin/mkdir -p /dev/pts
  ::sysinit:/bin/mkdir -p /dev/shm

package/sysvinit/inittab:
  si2::sysinit:/bin/mkdir -p /dev/pts
  si3::sysinit:/bin/mkdir -p /dev/shm

However this is broken when static /dev management is selected and the root
filesystem is read-only, showing during boot the error:

  mkdir: can't create directory '/dev/shm': Read-only file system

Fix by creating the empth /dev/shm directory, just like /dev/pts.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 system/skeleton/dev/shm/.empty | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 system/skeleton/dev/shm/.empty

diff --git a/system/skeleton/dev/shm/.empty b/system/skeleton/dev/shm/.empty
new file mode 100644
index 0000000..e69de29
-- 
1.9.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2] busybox: inittab: don't redirect output to /dev/null
  2015-09-21 16:29 ` [Buildroot] [PATCH 1/2] busybox: inittab: don't redirect output to /dev/null Luca Ceresoli
@ 2015-09-21 20:57   ` Yann E. MORIN
  0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2015-09-21 20:57 UTC (permalink / raw)
  To: buildroot

Luca, All,

On 2015-09-21 18:29 +0200, Luca Ceresoli spake thusly:
> Several inittab steps are redirected to /dev/null. This means any error or
> warning printed by these crucial commands would be hidden from the user.
> There is no evident reason to hide this output, so stop doing that.
> 
> Suggested by Thomas Petazzoni:
> http://lists.busybox.net/pipermail/buildroot/2015-September/139146.html
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/busybox/inittab | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/package/busybox/inittab b/package/busybox/inittab
> index b1892c1..24d9199 100644
> --- a/package/busybox/inittab
> +++ b/package/busybox/inittab
> @@ -14,12 +14,12 @@
>  # process   == program to run
>  
>  # Startup the system
> -null::sysinit:/bin/mount -t proc proc /proc
> -null::sysinit:/bin/mount -o remount,rw /
> -null::sysinit:/bin/mkdir -p /dev/pts
> -null::sysinit:/bin/mkdir -p /dev/shm
> -null::sysinit:/bin/mount -a
> -null::sysinit:/bin/hostname -F /etc/hostname
> +::sysinit:/bin/mount -t proc proc /proc
> +::sysinit:/bin/mount -o remount,rw /
> +::sysinit:/bin/mkdir -p /dev/pts
> +::sysinit:/bin/mkdir -p /dev/shm
> +::sysinit:/bin/mount -a
> +::sysinit:/bin/hostname -F /etc/hostname
>  # now run any rc scripts
>  ::sysinit:/etc/init.d/rcS
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] skeleton: fix absence of /dev/shm on static, read-only systems
  2015-09-21 16:29 ` [Buildroot] [PATCH 2/2] skeleton: fix absence of /dev/shm on static, read-only systems Luca Ceresoli
@ 2015-09-21 20:59   ` Yann E. MORIN
  0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2015-09-21 20:59 UTC (permalink / raw)
  To: buildroot

Luca, All,

On 2015-09-21 18:29 +0200, Luca Ceresoli spake thusly:
> /dev/shm is needed for systems using shared memory. On init-based systems
> this directory is usually created in the inittab along with /dev/pts, by
> the lines:
> 
> package/busybox/inittab:
>   ::sysinit:/bin/mkdir -p /dev/pts
>   ::sysinit:/bin/mkdir -p /dev/shm
> 
> package/sysvinit/inittab:
>   si2::sysinit:/bin/mkdir -p /dev/pts
>   si3::sysinit:/bin/mkdir -p /dev/shm
> 
> However this is broken when static /dev management is selected and the root
> filesystem is read-only, showing during boot the error:
> 
>   mkdir: can't create directory '/dev/shm': Read-only file system
> 
> Fix by creating the empth /dev/shm directory, just like /dev/pts.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  system/skeleton/dev/shm/.empty | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 system/skeleton/dev/shm/.empty
> 
> diff --git a/system/skeleton/dev/shm/.empty b/system/skeleton/dev/shm/.empty
> new file mode 100644
> index 0000000..e69de29
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 0/2] Early boot fixes
  2015-09-21 16:29 [Buildroot] [PATCH 0/2] Early boot fixes Luca Ceresoli
  2015-09-21 16:29 ` [Buildroot] [PATCH 1/2] busybox: inittab: don't redirect output to /dev/null Luca Ceresoli
  2015-09-21 16:29 ` [Buildroot] [PATCH 2/2] skeleton: fix absence of /dev/shm on static, read-only systems Luca Ceresoli
@ 2015-10-03 13:35 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2015-10-03 13:35 UTC (permalink / raw)
  To: buildroot

>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:

 > Hi,
 > my mdev-without-devtmpfs highlighted a couple errors that are not strictly
 > related to that work. And since that work might or not have a v2, and is
 > not very likely to be merged at all, let's have the two small fixes rolling
 > on their own.

 > Enjoy!

 > Luca Ceresoli (2):
 >   busybox: inittab: don't redirect output to /dev/null
 >   skeleton: fix absence of /dev/shm on static, read-only systems

Committed both, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-10-03 13:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-21 16:29 [Buildroot] [PATCH 0/2] Early boot fixes Luca Ceresoli
2015-09-21 16:29 ` [Buildroot] [PATCH 1/2] busybox: inittab: don't redirect output to /dev/null Luca Ceresoli
2015-09-21 20:57   ` Yann E. MORIN
2015-09-21 16:29 ` [Buildroot] [PATCH 2/2] skeleton: fix absence of /dev/shm on static, read-only systems Luca Ceresoli
2015-09-21 20:59   ` Yann E. MORIN
2015-10-03 13:35 ` [Buildroot] [PATCH 0/2] Early boot fixes Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox