From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/4] Config.in.legacy: add missing select BR2_LEGACY
Date: Fri, 9 Oct 2015 23:06:40 +0200 [thread overview]
Message-ID: <20151009230640.3401fe4c@gmx.net> (raw)
In-Reply-To: <20151009153212.36448f22@free-electrons.com>
Hello Thomas,
On Fri, 9 Oct 2015 15:32:12 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Dear Peter Seiderer,
>
> On Wed, 7 Oct 2015 23:56:49 +0200, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> This patch was actually wrong: doing a "select BR2_LEGACY" on string
> options is not correct. This was causing a number of warnings when
> running menuconfig:
>
> Config.in.legacy:1175:warning: config symbol 'BR2_PACKAGE_TZDATA_ZONELIST' uses select, but is not boolean or tristate
> Config.in.legacy:1530:warning: config symbol 'BR2_TARGET_UBOOT_CUSTOM_GIT_REPO_URL' uses select, but is not boolean or tristate
> Config.in.legacy:1545:warning: config symbol 'BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION' uses select, but is not boolean or tristate
> Config.in.legacy:1560:warning: config symbol 'BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL' uses select, but is not boolean or tristate
> Config.in.legacy:1576:warning: config symbol 'BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION' uses select, but is not boolean or tristate
>
> I've fixed that up in commit http://git.buildroot.net/buildroot/commit/?id=37ad0f8d7000c0be5ea47c4b968241311cc27560.
>
> Please at least test such patches by doing a "make menuconfig" :-)
Sorry for this one, will do better next time...
Regards,
Peter
>
> Thomas
next prev parent reply other threads:[~2015-10-09 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 21:56 [Buildroot] [PATCH v2 1/4] libv4l: update v4l-utils help text (add more listed tools) Peter Seiderer
2015-10-07 21:56 ` [Buildroot] [PATCH v2 2/4] media-ctl: remove package Peter Seiderer
2015-10-10 9:47 ` Thomas Petazzoni
2015-10-07 21:56 ` [Buildroot] [PATCH v2 3/4] Config.in.legacy: add missing select BR2_LEGACY Peter Seiderer
2015-10-07 23:11 ` Gustavo Zacarias
2015-10-09 13:28 ` Thomas Petazzoni
2015-10-09 13:32 ` Thomas Petazzoni
2015-10-09 21:06 ` Peter Seiderer [this message]
2015-10-07 21:56 ` [Buildroot] [PATCH v2 4/4] libv4l: bump version to 1.8.0 Peter Seiderer
2015-10-10 9:52 ` Thomas Petazzoni
2015-10-11 21:41 ` Peter Seiderer
2015-10-10 9:46 ` [Buildroot] [PATCH v2 1/4] libv4l: update v4l-utils help text (add more listed tools) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009230640.3401fe4c@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox