[Buildroot] [PATCH v2 1/4] libv4l: update v4l-utils help text (add more listed tools)

[Buildroot] [PATCH v2 1/4] libv4l: update v4l-utils help text (add more listed tools)

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - no changes
---
 package/libv4l/Config.in | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/package/libv4l/Config.in b/package/libv4l/Config.in
index d137613..5a55b2b 100644
--- a/package/libv4l/Config.in
+++ b/package/libv4l/Config.in
@@ -26,8 +26,16 @@ config BR2_PACKAGE_LIBV4L_UTILS
 	help
 	  v4l-utils is a collection of various video4linux and DVB utilities.
 	  Enable this if you want to build the following tools:
-	  cx18-ctl, ir-keytable, ivtv-ctl, v4l2-ctl, v4l2-sysfs-path and
-	  others.
+	  - cx18-ctl
+	  - dvb-fe-tool, dvbv5-zap, dvbv5-scan, dvb-format-convert
+	  - decode_tm6000
+	  - ir-keytable
+	  - media-ctl
+	  - v4l2-compliance
+	  - v4l2-ctl, cx18-ctl, ivtv-ctl
+	  - v4l2-sysfs-path
+	  - rds-ctl
+	  - qv4l2 (if Qt is enabled)
 
 endif
 
-- 
2.1.4

[Buildroot] [PATCH v2 2/4] media-ctl: remove package

[Peter Seiderer]

Package media-ctl is out-dated, source (and developement) have been moved
to v4l-utils since June 2014. Up-to-date version is available in
the libv4l package (BR2_PACKAGE_LIBV4L/BR2_PACKAGE_LIBV4L_UTILS).

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - fix legacy entry: select BR2_LEGACY, BR2_PACKAGE_LIBV4L and
    BR2_PACKAGE_LIBV4L_UTILS (suggested by Arnout Vandecappelle)
---
 Config.in.legacy                                   |  10 +
 package/Config.in                                  |   1 -
 ...ers-for-compatibility-with-old-toolchains.patch | 303 ---------------------
 package/media-ctl/Config.in                        |   9 -
 package/media-ctl/media-ctl.mk                     |  17 --
 5 files changed, 10 insertions(+), 330 deletions(-)
 delete mode 100644 package/media-ctl/0001-add-kernel-headers-for-compatibility-with-old-toolchains.patch
 delete mode 100644 package/media-ctl/Config.in
 delete mode 100644 package/media-ctl/media-ctl.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index 3c7fe36..af92b72 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,16 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_MEDIA_CTL
+	bool "media-ctl package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_LIBV4L
+	select BR2_PACKAGE_LIBV4L_UTILS
+	help
+	  media-ctl source and developement have been moved to
+	  v4l-utils since June 2014. For an up-to-date media-ctl
+	  version select BR2_PACKAGE_LIBV4L and BR2_PACKAGE_LIBV4L_UTILS.
+
 config BR2_PACKAGE_SCHIFRA
 	bool "schifra package has been removed"
 	help
diff --git a/package/Config.in b/package/Config.in
index 3794f44..74f1ffc 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -376,7 +376,6 @@ endif
 	source "package/lsuio/Config.in"
 	source "package/lvm2/Config.in"
 	source "package/mdadm/Config.in"
-	source "package/media-ctl/Config.in"
 	source "package/memtest86/Config.in"
 	source "package/memtester/Config.in"
 	source "package/minicom/Config.in"
diff --git a/package/media-ctl/0001-add-kernel-headers-for-compatibility-with-old-toolchains.patch b/package/media-ctl/0001-add-kernel-headers-for-compatibility-with-old-toolchains.patch
deleted file mode 100644
index 17b52ce..0000000
--- a/package/media-ctl/0001-add-kernel-headers-for-compatibility-with-old-toolchains.patch
+++ /dev/null
@@ -1,303 +0,0 @@
-From 480b9effa08541b5df369dd6516013282cf28bd8 Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Date: Sun, 6 Oct 2013 17:24:04 +0200
-Subject: [PATCH] Add kernel headers for compatibility with old toolchains
-
-The media controller mechanism is relatively new in the Linux kernel,
-and therefore all toolchains don't yet have the necessary
-headers. This patch makes sure that media-ctl provides such headers,
-as was already the case with v4l2-common.h, v4l2-subdev.h and
-videodev2.h.
-
-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
----
- configure.ac              |   6 +--
- src/linux/media.h         | 132 ++++++++++++++++++++++++++++++++++++++++++++++
- src/linux/v4l2-mediabus.h | 119 +++++++++++++++++++++++++++++++++++++++++
- 3 files changed, 252 insertions(+), 5 deletions(-)
- create mode 100644 src/linux/media.h
- create mode 100644 src/linux/v4l2-mediabus.h
-
-diff --git a/configure.ac b/configure.ac
-index a749794..56eb71f 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -51,11 +51,7 @@ AC_ARG_WITH(kernel-headers,
- CPPFLAGS="$CPPFLAGS -I$KERNEL_HEADERS_DIR/include"
- 
- # Checks for header files.
--AC_CHECK_HEADERS([linux/media.h \
--		  linux/types.h \
--		  linux/v4l2-mediabus.h \
--		  linux/v4l2-subdev.h \
--		  linux/videodev2.h],
-+AC_CHECK_HEADERS([linux/types.h],
- 		  [],
- 		  [echo "ERROR: Kernel header file not found or not usable!"; exit 1])
- 
-diff --git a/src/linux/media.h b/src/linux/media.h
-new file mode 100644
-index 0000000..410e7cc
---- /dev/null
-+++ b/src/linux/media.h
-@@ -0,0 +1,132 @@
-+/*
-+ * Multimedia device API
-+ *
-+ * Copyright (C) 2010 Nokia Corporation
-+ *
-+ * Contacts: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-+ *	     Sakari Ailus <sakari.ailus@iki.fi>
-+ *
-+ * This program is free software; you can redistribute it and/or modify
-+ * it under the terms of the GNU General Public License version 2 as
-+ * published by the Free Software Foundation.
-+ *
-+ * This program is distributed in the hope that it will be useful,
-+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
-+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-+ * GNU General Public License for more details.
-+ *
-+ * You should have received a copy of the GNU General Public License
-+ * along with this program; if not, write to the Free Software
-+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
-+ */
-+
-+#ifndef __LINUX_MEDIA_H
-+#define __LINUX_MEDIA_H
-+
-+#include <linux/ioctl.h>
-+#include <linux/types.h>
-+#include <linux/version.h>
-+
-+#define MEDIA_API_VERSION	KERNEL_VERSION(0, 1, 0)
-+
-+struct media_device_info {
-+	char driver[16];
-+	char model[32];
-+	char serial[40];
-+	char bus_info[32];
-+	__u32 media_version;
-+	__u32 hw_revision;
-+	__u32 driver_version;
-+	__u32 reserved[31];
-+};
-+
-+#define MEDIA_ENT_ID_FLAG_NEXT		(1 << 31)
-+
-+#define MEDIA_ENT_TYPE_SHIFT		16
-+#define MEDIA_ENT_TYPE_MASK		0x00ff0000
-+#define MEDIA_ENT_SUBTYPE_MASK		0x0000ffff
-+
-+#define MEDIA_ENT_T_DEVNODE		(1 << MEDIA_ENT_TYPE_SHIFT)
-+#define MEDIA_ENT_T_DEVNODE_V4L		(MEDIA_ENT_T_DEVNODE + 1)
-+#define MEDIA_ENT_T_DEVNODE_FB		(MEDIA_ENT_T_DEVNODE + 2)
-+#define MEDIA_ENT_T_DEVNODE_ALSA	(MEDIA_ENT_T_DEVNODE + 3)
-+#define MEDIA_ENT_T_DEVNODE_DVB		(MEDIA_ENT_T_DEVNODE + 4)
-+
-+#define MEDIA_ENT_T_V4L2_SUBDEV		(2 << MEDIA_ENT_TYPE_SHIFT)
-+#define MEDIA_ENT_T_V4L2_SUBDEV_SENSOR	(MEDIA_ENT_T_V4L2_SUBDEV + 1)
-+#define MEDIA_ENT_T_V4L2_SUBDEV_FLASH	(MEDIA_ENT_T_V4L2_SUBDEV + 2)
-+#define MEDIA_ENT_T_V4L2_SUBDEV_LENS	(MEDIA_ENT_T_V4L2_SUBDEV + 3)
-+
-+#define MEDIA_ENT_FL_DEFAULT		(1 << 0)
-+
-+struct media_entity_desc {
-+	__u32 id;
-+	char name[32];
-+	__u32 type;
-+	__u32 revision;
-+	__u32 flags;
-+	__u32 group_id;
-+	__u16 pads;
-+	__u16 links;
-+
-+	__u32 reserved[4];
-+
-+	union {
-+		/* Node specifications */
-+		struct {
-+			__u32 major;
-+			__u32 minor;
-+		} v4l;
-+		struct {
-+			__u32 major;
-+			__u32 minor;
-+		} fb;
-+		struct {
-+			__u32 card;
-+			__u32 device;
-+			__u32 subdevice;
-+		} alsa;
-+		int dvb;
-+
-+		/* Sub-device specifications */
-+		/* Nothing needed yet */
-+		__u8 raw[184];
-+	};
-+};
-+
-+#define MEDIA_PAD_FL_SINK		(1 << 0)
-+#define MEDIA_PAD_FL_SOURCE		(1 << 1)
-+
-+struct media_pad_desc {
-+	__u32 entity;		/* entity ID */
-+	__u16 index;		/* pad index */
-+	__u32 flags;		/* pad flags */
-+	__u32 reserved[2];
-+};
-+
-+#define MEDIA_LNK_FL_ENABLED		(1 << 0)
-+#define MEDIA_LNK_FL_IMMUTABLE		(1 << 1)
-+#define MEDIA_LNK_FL_DYNAMIC		(1 << 2)
-+
-+struct media_link_desc {
-+	struct media_pad_desc source;
-+	struct media_pad_desc sink;
-+	__u32 flags;
-+	__u32 reserved[2];
-+};
-+
-+struct media_links_enum {
-+	__u32 entity;
-+	/* Should have enough room for pads elements */
-+	struct media_pad_desc *pads;
-+	/* Should have enough room for links elements */
-+	struct media_link_desc *links;
-+	__u32 reserved[4];
-+};
-+
-+#define MEDIA_IOC_DEVICE_INFO		_IOWR('|', 0x00, struct media_device_info)
-+#define MEDIA_IOC_ENUM_ENTITIES		_IOWR('|', 0x01, struct media_entity_desc)
-+#define MEDIA_IOC_ENUM_LINKS		_IOWR('|', 0x02, struct media_links_enum)
-+#define MEDIA_IOC_SETUP_LINK		_IOWR('|', 0x03, struct media_link_desc)
-+
-+#endif /* __LINUX_MEDIA_H */
-diff --git a/src/linux/v4l2-mediabus.h b/src/linux/v4l2-mediabus.h
-new file mode 100644
-index 0000000..7d64e0e
---- /dev/null
-+++ b/src/linux/v4l2-mediabus.h
-@@ -0,0 +1,119 @@
-+/*
-+ * Media Bus API header
-+ *
-+ * Copyright (C) 2009, Guennadi Liakhovetski <g.liakhovetski@gmx.de>
-+ *
-+ * This program is free software; you can redistribute it and/or modify
-+ * it under the terms of the GNU General Public License version 2 as
-+ * published by the Free Software Foundation.
-+ */
-+
-+#ifndef __LINUX_V4L2_MEDIABUS_H
-+#define __LINUX_V4L2_MEDIABUS_H
-+
-+#include <linux/types.h>
-+#include <linux/videodev2.h>
-+
-+/*
-+ * These pixel codes uniquely identify data formats on the media bus. Mostly
-+ * they correspond to similarly named V4L2_PIX_FMT_* formats, format 0 is
-+ * reserved, V4L2_MBUS_FMT_FIXED shall be used by host-client pairs, where the
-+ * data format is fixed. Additionally, "2X8" means that one pixel is transferred
-+ * in two 8-bit samples, "BE" or "LE" specify in which order those samples are
-+ * transferred over the bus: "LE" means that the least significant bits are
-+ * transferred first, "BE" means that the most significant bits are transferred
-+ * first, and "PADHI" and "PADLO" define which bits - low or high, in the
-+ * incomplete high byte, are filled with padding bits.
-+ *
-+ * The pixel codes are grouped by type, bus_width, bits per component, samples
-+ * per pixel and order of subsamples. Numerical values are sorted using generic
-+ * numerical sort order (8 thus comes before 10).
-+ *
-+ * As their value can't change when a new pixel code is inserted in the
-+ * enumeration, the pixel codes are explicitly given a numerical value. The next
-+ * free values for each category are listed below, update them when inserting
-+ * new pixel codes.
-+ */
-+enum v4l2_mbus_pixelcode {
-+	V4L2_MBUS_FMT_FIXED = 0x0001,
-+
-+	/* RGB - next is 0x1009 */
-+	V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE = 0x1001,
-+	V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE = 0x1002,
-+	V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE = 0x1003,
-+	V4L2_MBUS_FMT_RGB555_2X8_PADHI_LE = 0x1004,
-+	V4L2_MBUS_FMT_BGR565_2X8_BE = 0x1005,
-+	V4L2_MBUS_FMT_BGR565_2X8_LE = 0x1006,
-+	V4L2_MBUS_FMT_RGB565_2X8_BE = 0x1007,
-+	V4L2_MBUS_FMT_RGB565_2X8_LE = 0x1008,
-+
-+	/* YUV (including grey) - next is 0x2014 */
-+	V4L2_MBUS_FMT_Y8_1X8 = 0x2001,
-+	V4L2_MBUS_FMT_UYVY8_1_5X8 = 0x2002,
-+	V4L2_MBUS_FMT_VYUY8_1_5X8 = 0x2003,
-+	V4L2_MBUS_FMT_YUYV8_1_5X8 = 0x2004,
-+	V4L2_MBUS_FMT_YVYU8_1_5X8 = 0x2005,
-+	V4L2_MBUS_FMT_UYVY8_2X8 = 0x2006,
-+	V4L2_MBUS_FMT_VYUY8_2X8 = 0x2007,
-+	V4L2_MBUS_FMT_YUYV8_2X8 = 0x2008,
-+	V4L2_MBUS_FMT_YVYU8_2X8 = 0x2009,
-+	V4L2_MBUS_FMT_Y10_1X10 = 0x200a,
-+	V4L2_MBUS_FMT_YUYV10_2X10 = 0x200b,
-+	V4L2_MBUS_FMT_YVYU10_2X10 = 0x200c,
-+	V4L2_MBUS_FMT_Y12_1X12 = 0x2013,
-+	V4L2_MBUS_FMT_UYVY8_1X16 = 0x200f,
-+	V4L2_MBUS_FMT_VYUY8_1X16 = 0x2010,
-+	V4L2_MBUS_FMT_YUYV8_1X16 = 0x2011,
-+	V4L2_MBUS_FMT_YVYU8_1X16 = 0x2012,
-+	V4L2_MBUS_FMT_YUYV10_1X20 = 0x200d,
-+	V4L2_MBUS_FMT_YVYU10_1X20 = 0x200e,
-+
-+	/* Bayer - next is 0x3015 */
-+	V4L2_MBUS_FMT_SBGGR8_1X8 = 0x3001,
-+	V4L2_MBUS_FMT_SGBRG8_1X8 = 0x3013,
-+	V4L2_MBUS_FMT_SGRBG8_1X8 = 0x3002,
-+	V4L2_MBUS_FMT_SRGGB8_1X8 = 0x3014,
-+	V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8 = 0x300b,
-+	V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8 = 0x300c,
-+	V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8 = 0x3009,
-+	V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8 = 0x300d,
-+	V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_BE = 0x3003,
-+	V4L2_MBUS_FMT_SBGGR10_2X8_PADHI_LE = 0x3004,
-+	V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_BE = 0x3005,
-+	V4L2_MBUS_FMT_SBGGR10_2X8_PADLO_LE = 0x3006,
-+	V4L2_MBUS_FMT_SBGGR10_1X10 = 0x3007,
-+	V4L2_MBUS_FMT_SGBRG10_1X10 = 0x300e,
-+	V4L2_MBUS_FMT_SGRBG10_1X10 = 0x300a,
-+	V4L2_MBUS_FMT_SRGGB10_1X10 = 0x300f,
-+	V4L2_MBUS_FMT_SBGGR12_1X12 = 0x3008,
-+	V4L2_MBUS_FMT_SGBRG12_1X12 = 0x3010,
-+	V4L2_MBUS_FMT_SGRBG12_1X12 = 0x3011,
-+	V4L2_MBUS_FMT_SRGGB12_1X12 = 0x3012,
-+
-+	/* JPEG compressed formats - next is 0x4002 */
-+	V4L2_MBUS_FMT_JPEG_1X8 = 0x4001,
-+
-+	/* Vendor specific formats - next is 0x5002 */
-+
-+	/* S5C73M3 sensor specific interleaved UYVY and JPEG */
-+	V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 = 0x5001,
-+};
-+
-+/**
-+ * struct v4l2_mbus_framefmt - frame format on the media bus
-+ * @width:	frame width
-+ * @height:	frame height
-+ * @code:	data format code (from enum v4l2_mbus_pixelcode)
-+ * @field:	used interlacing type (from enum v4l2_field)
-+ * @colorspace:	colorspace of the data (from enum v4l2_colorspace)
-+ */
-+struct v4l2_mbus_framefmt {
-+	__u32			width;
-+	__u32			height;
-+	__u32			code;
-+	__u32			field;
-+	__u32			colorspace;
-+	__u32			reserved[7];
-+};
-+
-+#endif
--- 
-1.8.1.2
-
diff --git a/package/media-ctl/Config.in b/package/media-ctl/Config.in
deleted file mode 100644
index 8d1beda..0000000
--- a/package/media-ctl/Config.in
+++ /dev/null
@@ -1,9 +0,0 @@
-config BR2_PACKAGE_MEDIA_CTL
-	bool "media-ctl"
-	help
-	  Media controller control application
-
-	  Useful mostly with ARM OMAP processors to configure and
-	  control the image subsystem
-
-	  http://git.ideasonboard.org/media-ctl.git
diff --git a/package/media-ctl/media-ctl.mk b/package/media-ctl/media-ctl.mk
deleted file mode 100644
index ae0d470..0000000
--- a/package/media-ctl/media-ctl.mk
+++ /dev/null
@@ -1,17 +0,0 @@
-################################################################################
-#
-# media-ctl
-#
-################################################################################
-
-MEDIA_CTL_VERSION = 87f58c2ed885d636229f7209fde883058433a1ce
-MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
-MEDIA_CTL_INSTALL_STAGING = YES
-MEDIA_CTL_LICENSE = LGPLv2.1+
-MEDIA_CTL_LICENSE_FILES = COPYING.LIB
-
-MEDIA_CTL_AUTORECONF = YES
-MEDIA_CTL_CONF_OPTS = --with-kernel-headers=$(STAGING_DIR)/usr/include
-MEDIA_CTL_DEPENDENCIES = host-pkgconf
-
-$(eval $(autotools-package))
-- 
2.1.4

[Buildroot] [PATCH v2 3/4] Config.in.legacy: add missing select BR2_LEGACY

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - new patch to fix missing select BR2_LEGACY (suggested by Arnout Vandecappelle)
---
 Config.in.legacy | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/Config.in.legacy b/Config.in.legacy
index af92b72..007e598 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -119,6 +119,7 @@ config BR2_PACKAGE_MEDIA_CTL
 
 config BR2_PACKAGE_SCHIFRA
 	bool "schifra package has been removed"
+	select BR2_LEGACY
 	help
 	  Schifra package has been maked broken since 2014.11 release and
 	  haven't been fixed since then.
@@ -136,6 +137,7 @@ config BR2_PACKAGE_ZXING
 config BR2_PACKAGE_FREERDP_CLIENT
 	bool "freerdp client option renamed"
 	depends on BR2_PACKAGE_FREERDP
+	select BR2_LEGACY
 	select BR2_PACKAGE_FREERDP_CLIENT_X11
 
 config BR2_PACKAGE_BLACKBOX
@@ -187,6 +189,7 @@ config BR2_KERNEL_HEADERS_3_15
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_ANDI
 	bool "DirectFB example df_andi has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -195,6 +198,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_ANDI
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_BLTLOAD
 	bool "DirectFB example df_bltload has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -203,6 +207,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_BLTLOAD
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_CPULOAD
 	bool "DirectFB example df_cpuload has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -211,6 +216,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_CPULOAD
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_DATABUFFER
 	bool "DirectFB example df_databuffer has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -219,6 +225,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_DATABUFFER
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_DIOLOAD
 	bool "DirectFB example df_dioload has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -227,6 +234,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_DIOLOAD
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_DOK
 	bool "DirectFB example df_dok has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -235,6 +243,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_DOK
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_DRIVERTEST
 	bool "DirectFB example df_drivertest has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -244,6 +253,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_DRIVERTEST
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_FIRE
 	bool "DirectFB example df_fire has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -252,6 +262,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_FIRE
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_FLIP
 	bool "DirectFB example df_flip has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -260,6 +271,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_FLIP
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_FONTS
 	bool "DirectFB example df_fonts has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -268,6 +280,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_FONTS
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_INPUT
 	bool "DirectFB example df_input has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -276,6 +289,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_INPUT
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_JOYSTICK
 	bool "DirectFB example df_joystick has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -284,6 +298,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_JOYSTICK
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_KNUCKLES
 	bool "DirectFB example df_knuckles has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -292,6 +307,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_KNUCKLES
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_LAYER
 	bool "DirectFB example df_layer has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -300,6 +316,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_LAYER
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_MATRIX
 	bool "DirectFB example df_matrix has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -308,6 +325,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_MATRIX
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_MATRIX_WATER
 	bool "DirectFB example df_matrix_water has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -316,6 +334,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_MATRIX_WATER
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_NEO
 	bool "DirectFB example df_neo has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -324,6 +343,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_NEO
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_NETLOAD
 	bool "DirectFB example df_netload has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -340,6 +360,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_PALETTE
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_PARTICLE
 	bool "DirectFB example df_particle has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -348,6 +369,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_PARTICLE
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_PORTER
 	bool "DirectFB example df_porter has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -364,6 +386,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_STRESS
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_TEXTURE
 	bool "DirectFB example df_texture has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -372,6 +395,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_TEXTURE
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_VIDEO
 	bool "DirectFB example df_video has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -380,6 +404,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_VIDEO
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_VIDEO_PARTICLE
 	bool "DirectFB example df_video_particle has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -388,6 +413,7 @@ config BR2_PACKAGE_DIRECTFB_EXAMPLES_VIDEO_PARTICLE
 
 config BR2_PACKAGE_DIRECTFB_EXAMPLES_WINDOW
 	bool "DirectFB example df_window has been removed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_DIRECTFB_EXAMPLES
 	help
 	  The per-DirectFB example options have been removed. The
@@ -502,6 +528,7 @@ config BR2_PACKAGE_GPU_VIV_BIN_MX6Q
 config BR2_PACKAGE_LIBSEMANAGE_PYTHON_BINDINGS
 	depends on BR2_PACKAGE_PYTHON
 	bool "libsemanage python bindings removed"
+	select BR2_LEGACY
 	help
 	  This option has been removed, since the libsemanage Python
 	  bindings on the target were not useful.
@@ -579,6 +606,7 @@ config BR2_PACKAGE_TIFF_TIFFCP
 
 config BR2_LINUX_KERNEL_EXT_RTAI_PATCH
 	bool "RTAI patch file path has been removed"
+	select BR2_LEGACY
 	help
 	  This option has never worked, so it has been removed.
 
@@ -913,6 +941,7 @@ config BR2_PACKAGE_XLIB_LIBPCIACCESS
 
 config BR2_PACKAGE_LINUX_FIRMWARE_XC5000
 	bool "Xceive xc5000 option has been renamed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_LINUX_FIRMWARE_XCx000
 	help
 	  The Xceive xc5000 option now also handles older firmwares from
@@ -921,6 +950,7 @@ config BR2_PACKAGE_LINUX_FIRMWARE_XC5000
 
 config BR2_PACKAGE_LINUX_FIRMWARE_CXGB4
 	bool "Chelsio T4 option has been renamed"
+	select BR2_LEGACY
 	select BR2_PACKAGE_LINUX_FIRMWARE_CXGB4_T4
 	help
 	  The Chelsio T4 option BR2_PACKAGE_LINUX_FIRMWARE_CXGB4
@@ -929,6 +959,7 @@ config BR2_PACKAGE_LINUX_FIRMWARE_CXGB4
 
 config BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160_7260_7
 	bool "BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160_7260_7 has been renamed"
+	select BR2_LEGACY
 	help
 	  The option BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160_7260_7 was
 	  renamed to BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_REV_7. You must
@@ -939,6 +970,7 @@ config BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160_7260_7
 
 config BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160_7260_8
 	bool "BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160_7260_8 has been renamed"
+	select BR2_LEGACY
 	help
 	  The option BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160_7260_8 was
 	  renamed to BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_REV_8. You must
@@ -1150,6 +1182,7 @@ config BR2_TARGET_TZ_ZONELIST
 
 config BR2_PACKAGE_TZDATA_ZONELIST
 	string "tzdata: the timezone list option has been renamed"
+	select BR2_LEGACY
 	help
 	  The option BR2_PACKAGE_TZDATA_ZONELIST has been renamed to
 	  BR2_TARGET_TZ_ZONELIST, and moved to the "System configuration"
@@ -1276,18 +1309,21 @@ comment "Legacy options removed in 2014.02"
 
 config BR2_sh2
 	bool "sh2 support removed"
+	select BR2_LEGACY
 	help
 	  Due to an inexistent user base and generally poor Linux
 	  support, the support for the SH2 architecture was removed.
 
 config BR2_sh3
 	bool "sh3 support removed"
+	select BR2_LEGACY
 	help
 	  Due to an inexistent user base and generally poor Linux
 	  support, the support for the SH3 architecture was removed.
 
 config BR2_sh3eb
 	bool "sh3eb support removed"
+	select BR2_LEGACY
 	help
 	  Due to an inexistent user base and generally poor Linux
 	  support, the support for the SH3eb architecture was removed.
@@ -1501,6 +1537,7 @@ config BR2_PACKAGE_MODULE_INIT_TOOLS
 
 config BR2_TARGET_UBOOT_CUSTOM_GIT_REPO_URL
 	string "u-boot: the git repository URL option has been renamed"
+	select BR2_LEGACY
 	help
 	  The option BR2_TARGET_UBOOT_CUSTOM_GIT_REPO_URL has
 	  been renamed to BR2_TARGET_UBOOT_CUSTOM_REPO_URL.
@@ -1515,6 +1552,7 @@ config BR2_TARGET_UBOOT_CUSTOM_GIT_REPO_URL_WRAP
 
 config BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION
 	string "u-boot: the git repository version option has been renamed"
+	select BR2_LEGACY
 	help
 	  The option BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION has
 	  been renamed to BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION.
@@ -1529,6 +1567,7 @@ config BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION_WRAP
 
 config BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL
 	string "linux: the git repository URL option has been renamed"
+	select BR2_LEGACY
 	help
 	  The option BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL has
 	  been renamed to
@@ -1544,6 +1583,7 @@ config BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL_WRAP
 
 config BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION
 	string "linux: the git repository version option has been renamed"
+	select BR2_LEGACY
 	help
 	  The option BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION has
 	  been renamed to
-- 
2.1.4

[Buildroot] [PATCH v2 4/4] libv4l: bump version to 1.8.0

[Peter Seiderer]

And add proper qt5base/qt dependency (needed for qv4l2, qt5 support
added since 1.8.0).

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - fix typo in commit comment (depndency vs. dependency)
---
 package/libv4l/libv4l.hash | 2 +-
 package/libv4l/libv4l.mk   | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/package/libv4l/libv4l.hash b/package/libv4l/libv4l.hash
index 3371d34..1395eda 100644
--- a/package/libv4l/libv4l.hash
+++ b/package/libv4l/libv4l.hash
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256 164abf5c1befcd27e8e6ef824a82d4015bdfb5d99ae82daa00e77d895ff9864c  v4l-utils-1.6.3.tar.bz2
+sha256 50c7be033636d878e902dad0a207fc9f6d831bec27f1b410f1102acddaa5565e  v4l-utils-1.8.0.tar.bz2
diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
index edb2a36..7978341 100644
--- a/package/libv4l/libv4l.mk
+++ b/package/libv4l/libv4l.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBV4L_VERSION = 1.6.3
+LIBV4L_VERSION = 1.8.0
 LIBV4L_SOURCE = v4l-utils-$(LIBV4L_VERSION).tar.bz2
 LIBV4L_SITE = http://linuxtv.org/downloads/v4l-utils
 LIBV4L_INSTALL_STAGING = YES
@@ -40,6 +40,9 @@ LIBV4L_CONF_OPTS += --without-libudev
 endif
 
 ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
+ifneq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT),)
+LIBV4L_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE),qt5base,qt)
+endif
 LIBV4L_CONF_OPTS += --enable-v4l-utils
 # clock_gettime is used, which is provided by librt for glibc < 2.17
 LIBV4L_LIBS += -lrt
-- 
2.1.4

[Buildroot] [PATCH v2 3/4] Config.in.legacy: add missing select BR2_LEGACY

[Gustavo Zacarias]

On 07/10/15 18:56, Peter Seiderer wrote:

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

[Buildroot] [PATCH v2 3/4] Config.in.legacy: add missing select BR2_LEGACY

[Thomas Petazzoni]

Dear Peter Seiderer,

On Wed,  7 Oct 2015 23:56:49 +0200, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - new patch to fix missing select BR2_LEGACY (suggested by Arnout Vandecappelle)
> ---
>  Config.in.legacy | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 3/4] Config.in.legacy: add missing select BR2_LEGACY

[Thomas Petazzoni]

Dear Peter Seiderer,

On Wed,  7 Oct 2015 23:56:49 +0200, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

This patch was actually wrong: doing a "select BR2_LEGACY" on string
options is not correct. This was causing a number of warnings when
running menuconfig:

Config.in.legacy:1175:warning: config symbol 'BR2_PACKAGE_TZDATA_ZONELIST' uses select, but is not boolean or tristate
Config.in.legacy:1530:warning: config symbol 'BR2_TARGET_UBOOT_CUSTOM_GIT_REPO_URL' uses select, but is not boolean or tristate
Config.in.legacy:1545:warning: config symbol 'BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION' uses select, but is not boolean or tristate
Config.in.legacy:1560:warning: config symbol 'BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL' uses select, but is not boolean or tristate
Config.in.legacy:1576:warning: config symbol 'BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION' uses select, but is not boolean or tristate

I've fixed that up in commit http://git.buildroot.net/buildroot/commit/?id=37ad0f8d7000c0be5ea47c4b968241311cc27560.

Please at least test such patches by doing a "make menuconfig" :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 3/4] Config.in.legacy: add missing select BR2_LEGACY

[Peter Seiderer]

Hello Thomas,

On Fri, 9 Oct 2015 15:32:12 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Dear Peter Seiderer,
> 
> On Wed,  7 Oct 2015 23:56:49 +0200, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> 
> This patch was actually wrong: doing a "select BR2_LEGACY" on string
> options is not correct. This was causing a number of warnings when
> running menuconfig:
> 
> Config.in.legacy:1175:warning: config symbol 'BR2_PACKAGE_TZDATA_ZONELIST' uses select, but is not boolean or tristate
> Config.in.legacy:1530:warning: config symbol 'BR2_TARGET_UBOOT_CUSTOM_GIT_REPO_URL' uses select, but is not boolean or tristate
> Config.in.legacy:1545:warning: config symbol 'BR2_TARGET_UBOOT_CUSTOM_GIT_VERSION' uses select, but is not boolean or tristate
> Config.in.legacy:1560:warning: config symbol 'BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL' uses select, but is not boolean or tristate
> Config.in.legacy:1576:warning: config symbol 'BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION' uses select, but is not boolean or tristate
> 
> I've fixed that up in commit http://git.buildroot.net/buildroot/commit/?id=37ad0f8d7000c0be5ea47c4b968241311cc27560.
> 
> Please at least test such patches by doing a "make menuconfig" :-)

Sorry for this one, will do better next time...

Regards,
Peter

> 
> Thomas

[Buildroot] [PATCH v2 1/4] libv4l: update v4l-utils help text (add more listed tools)

[Thomas Petazzoni]

Dear Peter Seiderer,

On Wed,  7 Oct 2015 23:56:47 +0200, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - no changes
> ---
>  package/libv4l/Config.in | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 2/4] media-ctl: remove package

[Thomas Petazzoni]

Dear Peter Seiderer,

On Wed,  7 Oct 2015 23:56:48 +0200, Peter Seiderer wrote:
> Package media-ctl is out-dated, source (and developement) have been moved
> to v4l-utils since June 2014. Up-to-date version is available in
> the libv4l package (BR2_PACKAGE_LIBV4L/BR2_PACKAGE_LIBV4L_UTILS).
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - fix legacy entry: select BR2_LEGACY, BR2_PACKAGE_LIBV4L and
>     BR2_PACKAGE_LIBV4L_UTILS (suggested by Arnout Vandecappelle)
> ---
>  Config.in.legacy                                   |  10 +
>  package/Config.in                                  |   1 -
>  ...ers-for-compatibility-with-old-toolchains.patch | 303 ---------------------
>  package/media-ctl/Config.in                        |   9 -
>  package/media-ctl/media-ctl.mk                     |  17 --
>  5 files changed, 10 insertions(+), 330 deletions(-)
>  delete mode 100644 package/media-ctl/0001-add-kernel-headers-for-compatibility-with-old-toolchains.patch
>  delete mode 100644 package/media-ctl/Config.in
>  delete mode 100644 package/media-ctl/media-ctl.mk

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 4/4] libv4l: bump version to 1.8.0

[Thomas Petazzoni]

Dear Peter Seiderer,

On Wed,  7 Oct 2015 23:56:50 +0200, Peter Seiderer wrote:

>  ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
> +ifneq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT),)
> +LIBV4L_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE),qt5base,qt)

This doesn't seem quite right for Qt5. According to the configure.ac,
much more than qt5base is needed:

PKG_CHECK_MODULES(QT5, [Qt5Core >= 5.0 Qt5Gui >= 5.0 Qt5Widgets >= 5.0], [qt_pkgconfig=true], [qt_pkgconfig=false])

So it looks like that for Qt5, we need to depend on qt5base, qt5gui and
qt5widgets. Note that it can also depend on Qt5OpenGL:

PKG_CHECK_MODULES(QT5GL, [Qt5OpenGL >= 5.0 gl], [qt_pkgconfig_gl=true], [qt_pkgconfig_gl=false])

So maybe we need an explicit option to enable Qt support in libv4l,
sometihng like (I haven't checked all Config.in options, so do not
copy/paste the below) :

config BR2_PACKAGE_LIBV4L_UTILS_QT
	bool "qt-based tools"
	depends on BR2_PACKAGE_QT || BR2_PACKAGE_QT5
	select BR2_PACKAGE_QT5BASE if BR2_PACKAGE_QT5
	select BR2_PACKAGE_QT5GUI if BR2_PACKAGE_QT5
	select BR2_PACKAGE_QT5WIDGETS if BR2_PACKAGE_QT5
	select BR2_PACKAGE_QT_<something> if BR2_PACKAGE_QT

and then, in the .mk file:

ifeq ($(BR2_PACKAGE_LIBV4L_UTILS_QT),y)
ifeq ($(BR2_PACKAGE_QT),y)
LIBV4L_DEPENDENCIES += qt
else ifeq ($(BR2_PACKAGE_QT5),y)
LIBV4L_DEPENDENCIES += qt5base qt5gui qt5widgets
ifeq ($(BR2_PACKAGE_QT5OPENGL),y)
LIBV4L_DEPENDENCIES += qt5opengl
endif
endif

Or, alternatively, if you don't want to add a new Config.in option,
then you should improve the .mk file logic with all the proper
dependencies.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 4/4] libv4l: bump version to 1.8.0

[Peter Seiderer]

Hello Thomas,

On Sat, 10 Oct 2015 11:52:42 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Dear Peter Seiderer,
> 
> On Wed,  7 Oct 2015 23:56:50 +0200, Peter Seiderer wrote:
> 
> >  ifeq ($(BR2_PACKAGE_LIBV4L_UTILS),y)
> > +ifneq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT),)
> > +LIBV4L_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE),qt5base,qt)
> 
> This doesn't seem quite right for Qt5. According to the configure.ac,
> much more than qt5base is needed:
> 
> PKG_CHECK_MODULES(QT5, [Qt5Core >= 5.0 Qt5Gui >= 5.0 Qt5Widgets >= 5.0], [qt_pkgconfig=true], [qt_pkgconfig=false])
> 
> So it looks like that for Qt5, we need to depend on qt5base, qt5gui and
> qt5widgets. Note that it can also depend on Qt5OpenGL:
> 
> PKG_CHECK_MODULES(QT5GL, [Qt5OpenGL >= 5.0 gl], [qt_pkgconfig_gl=true], [qt_pkgconfig_gl=false])
>

Yes, you are right...
 
> So maybe we need an explicit option to enable Qt support in libv4l,
> sometihng like (I haven't checked all Config.in options, so do not
> copy/paste the below) :
> 
> config BR2_PACKAGE_LIBV4L_UTILS_QT
> 	bool "qt-based tools"
> 	depends on BR2_PACKAGE_QT || BR2_PACKAGE_QT5
> 	select BR2_PACKAGE_QT5BASE if BR2_PACKAGE_QT5
> 	select BR2_PACKAGE_QT5GUI if BR2_PACKAGE_QT5
> 	select BR2_PACKAGE_QT5WIDGETS if BR2_PACKAGE_QT5
> 	select BR2_PACKAGE_QT_<something> if BR2_PACKAGE_QT
> 
> and then, in the .mk file:
> 
> ifeq ($(BR2_PACKAGE_LIBV4L_UTILS_QT),y)
> ifeq ($(BR2_PACKAGE_QT),y)
> LIBV4L_DEPENDENCIES += qt
> else ifeq ($(BR2_PACKAGE_QT5),y)
> LIBV4L_DEPENDENCIES += qt5base qt5gui qt5widgets
> ifeq ($(BR2_PACKAGE_QT5OPENGL),y)
> LIBV4L_DEPENDENCIES += qt5opengl
> endif
> endif
> 
> Or, alternatively, if you don't want to add a new Config.in option,
> then you should improve the .mk file logic with all the proper
> dependencies.
> 

O.k. will cook up a follow up patch...

Regards,
Peter

> Best regards,
> 
> Thomas