Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1
Date: Sun, 11 Oct 2015 23:20:11 +0200	[thread overview]
Message-ID: <20151011212011.GF24916@free.fr> (raw)
In-Reply-To: <1444597880.3974.0.camel@embedded.rocks>

J?rg, All,

On 2015-10-11 23:11 +0200, J?rg Krause spake thusly:
> On So, 2015-10-11 at 23:07 +0200, Yann E. MORIN wrote:
> > J?rg, All,
> > 
> > On 2015-10-11 23:02 +0200, J?rg Krause spake thusly:
> > > Remove backported from upstream patch.
> > 
> > You could have added something like:
> > 
> > ????Fix autoreconf comment that was wrong.
> > 
> > (No need to resend, it can be fixed at commit time by a maintainer).
> > 
> > > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > 
> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > Regards,
> > Yann E. MORIN.
> > 
> > > ---
> > > Changes v1 -> v2:
> > > ? - Fix autoreconf comment (Baruch Siach)
> 
> I did it in the changelog...

Yeah, I saw that. However, the commit-changelog in good for noting
changes between versions of the patch, so that reviewers quickly notice
what has changed between those two revisions of the patch.

The commitlog proper is good for historical records, like "why on Earth
did we change that comment 6 months ago?".

The commit-changelog does not end-up in the history of the project
(i.e. it is dropped when a maintainer applies the patch), while the
commitlog is preserved.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-10-11 21:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 21:02 [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1 Jörg Krause
2015-10-11 21:07 ` Yann E. MORIN
2015-10-11 21:11   ` Jörg Krause
2015-10-11 21:20     ` Yann E. MORIN [this message]
2015-10-12 15:56 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151011212011.GF24916@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox