* [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1
@ 2015-10-11 21:02 Jörg Krause
2015-10-11 21:07 ` Yann E. MORIN
2015-10-12 15:56 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Jörg Krause @ 2015-10-11 21:02 UTC (permalink / raw)
To: buildroot
Remove backported from upstream patch.
Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
Changes v1 -> v2:
- Fix autoreconf comment (Baruch Siach)
---
package/shairport-sync/shairport-sync.mk | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk
index 36d5b82..fa7100a 100644
--- a/package/shairport-sync/shairport-sync.mk
+++ b/package/shairport-sync/shairport-sync.mk
@@ -4,15 +4,14 @@
#
################################################################################
-SHAIRPORT_SYNC_VERSION = 2.4
+SHAIRPORT_SYNC_VERSION = 2.4.1
SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
SHAIRPORT_SYNC_LICENSE_FILES = LICENSES
SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf
-SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch
-# Touching configure.ac with the patches
+# git clone, no configure
SHAIRPORT_SYNC_AUTORECONF = YES
SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \
--
2.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1
2015-10-11 21:02 [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1 Jörg Krause
@ 2015-10-11 21:07 ` Yann E. MORIN
2015-10-11 21:11 ` Jörg Krause
2015-10-12 15:56 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2015-10-11 21:07 UTC (permalink / raw)
To: buildroot
J?rg, All,
On 2015-10-11 23:02 +0200, J?rg Krause spake thusly:
> Remove backported from upstream patch.
You could have added something like:
Fix autoreconf comment that was wrong.
(No need to resend, it can be fixed at commit time by a maintainer).
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2:
> - Fix autoreconf comment (Baruch Siach)
> ---
> package/shairport-sync/shairport-sync.mk | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk
> index 36d5b82..fa7100a 100644
> --- a/package/shairport-sync/shairport-sync.mk
> +++ b/package/shairport-sync/shairport-sync.mk
> @@ -4,15 +4,14 @@
> #
> ################################################################################
>
> -SHAIRPORT_SYNC_VERSION = 2.4
> +SHAIRPORT_SYNC_VERSION = 2.4.1
> SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
>
> SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
> SHAIRPORT_SYNC_LICENSE_FILES = LICENSES
> SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf
> -SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch
>
> -# Touching configure.ac with the patches
> +# git clone, no configure
> SHAIRPORT_SYNC_AUTORECONF = YES
>
> SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \
> --
> 2.6.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1
2015-10-11 21:07 ` Yann E. MORIN
@ 2015-10-11 21:11 ` Jörg Krause
2015-10-11 21:20 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Jörg Krause @ 2015-10-11 21:11 UTC (permalink / raw)
To: buildroot
Dear Yann,
On So, 2015-10-11 at 23:07 +0200, Yann E. MORIN wrote:
> J?rg, All,
>
> On 2015-10-11 23:02 +0200, J?rg Krause spake thusly:
> > Remove backported from upstream patch.
>
> You could have added something like:
>
> ????Fix autoreconf comment that was wrong.
>
> (No need to resend, it can be fixed at commit time by a maintainer).
>
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Regards,
> Yann E. MORIN.
>
> > ---
> > Changes v1 -> v2:
> > ? - Fix autoreconf comment (Baruch Siach)
I did it in the changelog...
Best regards
J?rg Krause
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1
2015-10-11 21:11 ` Jörg Krause
@ 2015-10-11 21:20 ` Yann E. MORIN
0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2015-10-11 21:20 UTC (permalink / raw)
To: buildroot
J?rg, All,
On 2015-10-11 23:11 +0200, J?rg Krause spake thusly:
> On So, 2015-10-11 at 23:07 +0200, Yann E. MORIN wrote:
> > J?rg, All,
> >
> > On 2015-10-11 23:02 +0200, J?rg Krause spake thusly:
> > > Remove backported from upstream patch.
> >
> > You could have added something like:
> >
> > ????Fix autoreconf comment that was wrong.
> >
> > (No need to resend, it can be fixed at commit time by a maintainer).
> >
> > > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> >
> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Regards,
> > Yann E. MORIN.
> >
> > > ---
> > > Changes v1 -> v2:
> > > ? - Fix autoreconf comment (Baruch Siach)
>
> I did it in the changelog...
Yeah, I saw that. However, the commit-changelog in good for noting
changes between versions of the patch, so that reviewers quickly notice
what has changed between those two revisions of the patch.
The commitlog proper is good for historical records, like "why on Earth
did we change that comment 6 months ago?".
The commit-changelog does not end-up in the history of the project
(i.e. it is dropped when a maintainer applies the patch), while the
commitlog is preserved.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1
2015-10-11 21:02 [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1 Jörg Krause
2015-10-11 21:07 ` Yann E. MORIN
@ 2015-10-12 15:56 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-10-12 15:56 UTC (permalink / raw)
To: buildroot
Dear J?rg Krause,
On Sun, 11 Oct 2015 23:02:49 +0200, J?rg Krause wrote:
> Remove backported from upstream patch.
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
> Changes v1 -> v2:
> - Fix autoreconf comment (Baruch Siach)
> ---
> package/shairport-sync/shairport-sync.mk | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied after tweaking the commit log as suggested by Yann, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-12 15:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-11 21:02 [Buildroot] [PATCH v2 1/1] package/shairport-sync: bump to version 2.4.1 Jörg Krause
2015-10-11 21:07 ` Yann E. MORIN
2015-10-11 21:11 ` Jörg Krause
2015-10-11 21:20 ` Yann E. MORIN
2015-10-12 15:56 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox