* [Buildroot] [PATCH 1/2] package/bitstream: new package
@ 2015-10-16 13:54 Julian Scheel
2015-10-16 13:54 ` [Buildroot] [PATCH 2/2] dvblast: " Julian Scheel
2015-10-17 20:18 ` [Buildroot] [PATCH 1/2] package/bitstream: " Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Julian Scheel @ 2015-10-16 13:54 UTC (permalink / raw)
To: buildroot
BiTStream is a set of headers to ease processing of mpeg ts streams. It is
used by dvblast.
Signed-off-by: Julian Scheel <julian@jusst.de>
---
package/Config.in | 1 +
package/bitstream/Config.in | 8 ++++++++
package/bitstream/bitstream.mk | 19 +++++++++++++++++++
3 files changed, 28 insertions(+)
create mode 100644 package/bitstream/Config.in
create mode 100644 package/bitstream/bitstream.mk
diff --git a/package/Config.in b/package/Config.in
index 98dcd78..53a312c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -954,6 +954,7 @@ menu "Logging"
endmenu
menu "Multimedia"
+ source "package/bitstream/Config.in"
source "package/libass/Config.in"
source "package/libbluray/Config.in"
source "package/libdcadec/Config.in"
diff --git a/package/bitstream/Config.in b/package/bitstream/Config.in
new file mode 100644
index 0000000..3a7ad43
--- /dev/null
+++ b/package/bitstream/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_BITSTREAM
+ bool "biTStream"
+ help
+ biTStream is a set of C headers allowing a simpler access to
+ binary structures such as specified by MPEG, DVB, IETF, SMPTE,
+ IEEE, SCTE, etc.
+
+ http://www.videolan.org/developers/bitstream.html
diff --git a/package/bitstream/bitstream.mk b/package/bitstream/bitstream.mk
new file mode 100644
index 0000000..cdca80f
--- /dev/null
+++ b/package/bitstream/bitstream.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# biTStream
+#
+################################################################################
+
+BITSTREAM_VERSION = 1.1
+BITSTREAM_SOURCE = bitstream-$(BITSTREAM_VERSION).tar.bz2
+BITSTREAM_SITE = https://get.videolan.org/bitstream/$(BITSTREAM_VERSION)
+BITSTREAM_LICENSE = MIT
+
+BITSTREAM_INSTALL_STAGING = YES
+BITSTREAM_INSTALL_TARGET = NO
+
+define BITSTREAM_INSTALL_STAGING_CMDS
+ (cd $(@D); $(MAKE) PREFIX=$(STAGING_DIR)/usr install)
+endef
+
+$(eval $(generic-package))
--
2.6.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] dvblast: new package
2015-10-16 13:54 [Buildroot] [PATCH 1/2] package/bitstream: new package Julian Scheel
@ 2015-10-16 13:54 ` Julian Scheel
2015-10-17 20:41 ` Yann E. MORIN
2015-10-17 20:18 ` [Buildroot] [PATCH 1/2] package/bitstream: " Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Julian Scheel @ 2015-10-16 13:54 UTC (permalink / raw)
To: buildroot
DVBlast is a simple and powerful MPEG-2/TS demux and streaming application.
Signed-off-by: Julian Scheel <julian@jusst.de>
---
package/Config.in | 1 +
package/dvblast/Config.in | 9 +++++++++
package/dvblast/dvblast.mk | 25 +++++++++++++++++++++++++
3 files changed, 35 insertions(+)
create mode 100644 package/dvblast/Config.in
create mode 100644 package/dvblast/dvblast.mk
diff --git a/package/Config.in b/package/Config.in
index 53a312c..cf0e46d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -7,6 +7,7 @@ menu "Audio and video applications"
source "package/alsa-utils/Config.in"
source "package/aumix/Config.in"
source "package/bellagio/Config.in"
+ source "package/dvblast/Config.in"
source "package/dvdauthor/Config.in"
source "package/dvdrw-tools/Config.in"
source "package/espeak/Config.in"
diff --git a/package/dvblast/Config.in b/package/dvblast/Config.in
new file mode 100644
index 0000000..769d86f
--- /dev/null
+++ b/package/dvblast/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_DVBLAST
+ bool "dvblast"
+ select BR2_PACKAGE_BITSTREAM
+ select BR2_PACKAGE_LIBEV
+ help
+ DVBlast is a simple and powerful MPEG-2/TS demux and streaming
+ application.
+
+ http://www.videolan.org/projects/dvblast.html
diff --git a/package/dvblast/dvblast.mk b/package/dvblast/dvblast.mk
new file mode 100644
index 0000000..bcf3c69
--- /dev/null
+++ b/package/dvblast/dvblast.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# dvblast
+#
+################################################################################
+
+DVBLAST_VERSION = 3.0
+DVBLAST_SOURCE = dvblast-$(DVBLAST_VERSION).tar.bz2
+DVBLAST_SITE = https://get.videolan.org/dvblast/$(DVBLAST_VERSION)
+DVBLAST_LICENSE = GPLv2
+
+DVBLAST_DEPENDENCIES = bitstream libev
+
+DVBLAST_INSTALL_STAGING = NO
+DVBLAST_INSTALL_TARGET = YES
+
+define DVBLAST_BUILD_CMDS
+ $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define DVBLAST_INSTALL_TARGET_CMDS
+ (cd $(@D); $(MAKE) PREFIX=$(TARGET_DIR)/usr install)
+endef
+
+$(eval $(generic-package))
--
2.6.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] package/bitstream: new package
2015-10-16 13:54 [Buildroot] [PATCH 1/2] package/bitstream: new package Julian Scheel
2015-10-16 13:54 ` [Buildroot] [PATCH 2/2] dvblast: " Julian Scheel
@ 2015-10-17 20:18 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-10-17 20:18 UTC (permalink / raw)
To: buildroot
Julain, All,
On 2015-10-16 15:54 +0200, Julian Scheel spake thusly:
> BiTStream is a set of headers to ease processing of mpeg ts streams. It is
> used by dvblast.
>
> Signed-off-by: Julian Scheel <julian@jusst.de>
Thanks for this new package. :-)
It is pretty good, but there are a few minor hickups to fix, see
below...
[--SNIP--]
> diff --git a/package/bitstream/Config.in b/package/bitstream/Config.in
> new file mode 100644
> index 0000000..3a7ad43
> --- /dev/null
> +++ b/package/bitstream/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_BITSTREAM
> + bool "biTStream"
We write package names only in lower-case, even in the prompts.
> + help
> + biTStream is a set of C headers allowing a simpler access to
> + binary structures such as specified by MPEG, DVB, IETF, SMPTE,
> + IEEE, SCTE, etc.
> +
> + http://www.videolan.org/developers/bitstream.html
> diff --git a/package/bitstream/bitstream.mk b/package/bitstream/bitstream.mk
> new file mode 100644
> index 0000000..cdca80f
> --- /dev/null
> +++ b/package/bitstream/bitstream.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# biTStream
> +#
> +################################################################################
> +
> +BITSTREAM_VERSION = 1.1
> +BITSTREAM_SOURCE = bitstream-$(BITSTREAM_VERSION).tar.bz2
> +BITSTREAM_SITE = https://get.videolan.org/bitstream/$(BITSTREAM_VERSION)
> +BITSTREAM_LICENSE = MIT
> +
> +BITSTREAM_INSTALL_STAGING = YES
> +BITSTREAM_INSTALL_TARGET = NO
Even though it seems obvious from the help text, you should also state
here why it is only installed in staging and not intargetm, like so:
# Only installs headers files:
BITSTREAM_INSTALL_STAGING = YES
BITSTREAM_INSTALL_TARGET = NO
> +define BITSTREAM_INSTALL_STAGING_CMDS
> + (cd $(@D); $(MAKE) PREFIX=$(STAGING_DIR)/usr install)
Even if this is working, the proper solution is to pass DESTDIR and
PREFIX, like so:
$(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) PREFIX=/usr install
Also note the little trick to avoid 'cd' ;-)
Care to fix and resend, please? Thanks! :-)
Regards,
Yann E. MORIN.
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.6.0
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] dvblast: new package
2015-10-16 13:54 ` [Buildroot] [PATCH 2/2] dvblast: " Julian Scheel
@ 2015-10-17 20:41 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-10-17 20:41 UTC (permalink / raw)
To: buildroot
Julain, All,
On 2015-10-16 15:54 +0200, Julian Scheel spake thusly:
> DVBlast is a simple and powerful MPEG-2/TS demux and streaming application.
>
> Signed-off-by: Julian Scheel <julian@jusst.de>
See below for a few comments...
[--SNIP--]
> diff --git a/package/dvblast/Config.in b/package/dvblast/Config.in
> new file mode 100644
> index 0000000..769d86f
> --- /dev/null
> +++ b/package/dvblast/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_DVBLAST
> + bool "dvblast"
> + select BR2_PACKAGE_BITSTREAM
> + select BR2_PACKAGE_LIBEV
libev us not available for the Blackfin architecture, so you need to
propagate its dependencies to dvblast, like so:
depends on !BR2_bfin # libev
The comment helps understand that the dependency is inherited from libev
(so we find it more easily if we one day update to a libev without that
dependency).
> + help
> + DVBlast is a simple and powerful MPEG-2/TS demux and streaming
> + application.
> +
> + http://www.videolan.org/projects/dvblast.html
> diff --git a/package/dvblast/dvblast.mk b/package/dvblast/dvblast.mk
> new file mode 100644
> index 0000000..bcf3c69
> --- /dev/null
> +++ b/package/dvblast/dvblast.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# dvblast
> +#
> +################################################################################
> +
> +DVBLAST_VERSION = 3.0
> +DVBLAST_SOURCE = dvblast-$(DVBLAST_VERSION).tar.bz2
> +DVBLAST_SITE = https://get.videolan.org/dvblast/$(DVBLAST_VERSION)
> +DVBLAST_LICENSE = GPLv2
It's actually a bit more complex than that:
- most of the code is "GPLv2 or later", so you need to indicate that
as: GPLv2+;
- parts of the code is under the WTFPL, so you also need to indicate
it;
- you must also define the license files.
DVBLAST_LICENSE = GPLv2+, WTFPL
DVBLAST_LICENSE_FILES = COPYING COPYING.WTFPL
> +DVBLAST_DEPENDENCIES = bitstream libev
> +
> +DVBLAST_INSTALL_STAGING = NO
INSTALL_STAGING = NO is the default, so you do not need to specify it.
> +DVBLAST_INSTALL_TARGET = YES
> +
> +define DVBLAST_BUILD_CMDS
> + $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
You may want to use TARGET_CONFIGURE_OPTS instead; 'all' is the first
rule, so is the default rule, so you need not specify it either:
$(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS)
> +endef
> +
> +define DVBLAST_INSTALL_TARGET_CMDS
> + (cd $(@D); $(MAKE) PREFIX=$(TARGET_DIR)/usr install)
Same as for bitstream, you should use DESTDIR and PREFIX.
Care to fix and resend, please? Thanks! ;-)
In the meantime, I've marked both patches as "changes requested" on our
patch tracking system.
Regards,
Yann E. MORIN.
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.6.0
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-17 20:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 13:54 [Buildroot] [PATCH 1/2] package/bitstream: new package Julian Scheel
2015-10-16 13:54 ` [Buildroot] [PATCH 2/2] dvblast: " Julian Scheel
2015-10-17 20:41 ` Yann E. MORIN
2015-10-17 20:18 ` [Buildroot] [PATCH 1/2] package/bitstream: " Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox