[Buildroot] [PATCH v1 1/1] gmediarender: new package

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[kei-k at ca2.so-net.ne.jp]

gmediarender is UPnP (DLNA) rendere based on gstreamer.

Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
---
 package/Config.in                      |    1 +
 package/gmediarender/Config.in         |   15 +++++++++++++++
 package/gmediarender/gmediarender.hash |    2 ++
 package/gmediarender/gmediarender.mk   |   16 ++++++++++++++++
 4 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 package/gmediarender/Config.in
 create mode 100644 package/gmediarender/gmediarender.hash
 create mode 100644 package/gmediarender/gmediarender.mk

diff --git a/package/Config.in b/package/Config.in
index 8e3c64a..396d757 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -14,6 +14,7 @@ menu "Audio and video applications"
 	source "package/ffmpeg/Config.in"
 	source "package/flac/Config.in"
 	source "package/flite/Config.in"
+	source "package/gmediarender/Config.in"
 	source "package/gstreamer/Config.in"
 	source "package/gstreamer1/Config.in"
 	source "package/jack2/Config.in"
diff --git a/package/gmediarender/Config.in b/package/gmediarender/Config.in
new file mode 100644
index 0000000..d2cd9d7
--- /dev/null
+++ b/package/gmediarender/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_GMEDIARENDER
+	bool "gmediarender"
+	depends on BR2_USE_WCHAR # gstreamer
+	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
+	depends on BR2_USE_MMU # gstreamer
+	select BR2_PACKAGE_GSTREAMER
+	select BR2_PACKAGE_LIBUPNP
+	help
+	  UPnP (DLNA) media renderer based on gstreamer
+
+	  http://gmrender.nongnu.org/
+
+comment "gmediarender needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/gmediarender/gmediarender.hash b/package/gmediarender/gmediarender.hash
new file mode 100644
index 0000000..f181770
--- /dev/null
+++ b/package/gmediarender/gmediarender.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 85d3251ce3095394d389b56f8b47e7f79e906022e51ce92a4cf822ee2a5fee2c  gmediarender-0.0.6.tar.bz2
diff --git a/package/gmediarender/gmediarender.mk b/package/gmediarender/gmediarender.mk
new file mode 100644
index 0000000..e383786
--- /dev/null
+++ b/package/gmediarender/gmediarender.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# gmediarender
+#
+################################################################################
+
+GMEDIARENDER_VERSION = 0.0.6
+GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
+GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
+GMEDIARENDER_AUTORECONF = YES
+GMEDIARENDER_LICENSE = GPLv2
+GMEDIARENDER_LICENSE_FILES = COPYING
+GMEDIARENDER_DEPENDENCIES = gstreamer libupnp
+GMEDIARENDER_CONF_OPTS = --with-libupnp=$(STAGING_DIR)/usr LIBS="-lixml"
+
+$(eval $(autotools-package))
-- 
1.7.1

============================================================
    Hiroshi Kawashima

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[Thomas Petazzoni]

Hello,

Thanks for this new contribution! It looks pretty good, but as usual I
have some comments/questions.

First, can you fix your e-mail client or git send-email configuration
so that your "From:" is:

	Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>

instead of just:

	kei-k at ca2.so-net.ne.jp

The From: field is used to indicate the author of the patch in the Git
history, so it's nicer when there's a full name rather than just the
e-mail address.

On Fri, 16 Oct 2015 21:54:41 +0900, kei-k at ca2.so-net.ne.jp wrote:

> diff --git a/package/Config.in b/package/Config.in
> index 8e3c64a..396d757 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -14,6 +14,7 @@ menu "Audio and video applications"
>  	source "package/ffmpeg/Config.in"
>  	source "package/flac/Config.in"
>  	source "package/flite/Config.in"
> +	source "package/gmediarender/Config.in"
>  	source "package/gstreamer/Config.in"
>  	source "package/gstreamer1/Config.in"
>  	source "package/jack2/Config.in"
> diff --git a/package/gmediarender/Config.in b/package/gmediarender/Config.in
> new file mode 100644
> index 0000000..d2cd9d7
> --- /dev/null
> +++ b/package/gmediarender/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_GMEDIARENDER
> +	bool "gmediarender"
> +	depends on BR2_USE_WCHAR # gstreamer
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
> +	depends on BR2_USE_MMU # gstreamer
> +	select BR2_PACKAGE_GSTREAMER

So it really only supports GStreamer 0.10.x (which is deprecated) and
not GStreamer 1.x ?

> +	select BR2_PACKAGE_LIBUPNP
> +	help
> +	  UPnP (DLNA) media renderer based on gstreamer
> +
> +	  http://gmrender.nongnu.org/
> +
> +comment "gmediarender needs a toolchain w/ wchar, threads"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/gmediarender/gmediarender.hash b/package/gmediarender/gmediarender.hash
> new file mode 100644
> index 0000000..f181770
> --- /dev/null
> +++ b/package/gmediarender/gmediarender.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 85d3251ce3095394d389b56f8b47e7f79e906022e51ce92a4cf822ee2a5fee2c  gmediarender-0.0.6.tar.bz2
> diff --git a/package/gmediarender/gmediarender.mk b/package/gmediarender/gmediarender.mk
> new file mode 100644
> index 0000000..e383786
> --- /dev/null
> +++ b/package/gmediarender/gmediarender.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# gmediarender
> +#
> +################################################################################
> +
> +GMEDIARENDER_VERSION = 0.0.6
> +GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
> +GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
> +GMEDIARENDER_AUTORECONF = YES

Can you add a justification for the AUTORECONF = YES here (in a comment
above the line) ?

> +GMEDIARENDER_LICENSE = GPLv2

License is actually GPLv2+.

> +GMEDIARENDER_LICENSE_FILES = COPYING
> +GMEDIARENDER_DEPENDENCIES = gstreamer libupnp
> +GMEDIARENDER_CONF_OPTS = --with-libupnp=$(STAGING_DIR)/usr LIBS="-lixml"

Which package provides the ixml library ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[Hiroshi Kawashima]

Dear Thomas.
Thank you for your comment.

Thomas Petazzoni writes:
> Hello,
> 
> Thanks for this new contribution! It looks pretty good, but as usual I
> have some comments/questions.
> 
> First, can you fix your e-mail client or git send-email configuration
> so that your "From:" is:
> 
> 	Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> 
> instead of just:
> 
> 	kei-k at ca2.so-net.ne.jp
> 
> The From: field is used to indicate the author of the patch in the Git
> history, so it's nicer when there's a full name rather than just the
> e-mail address.
Sure.
I think fixed it since this e-mail.

[snip]
> > +config BR2_PACKAGE_GMEDIARENDER
> > +	bool "gmediarender"
> > +	depends on BR2_USE_WCHAR # gstreamer
> > +	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
> > +	depends on BR2_USE_MMU # gstreamer
> > +	select BR2_PACKAGE_GSTREAMER
> 
> So it really only supports GStreamer 0.10.x (which is deprecated) and
> not GStreamer 1.x ?
Ok, let me check.

[snip]
> > +GMEDIARENDER_VERSION = 0.0.6
> > +GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
> > +GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
> > +GMEDIARENDER_AUTORECONF = YES
> 
> Can you add a justification for the AUTORECONF = YES here (in a comment
> above the line) ?
Ok, let me check again if really need this.

> > +GMEDIARENDER_LICENSE = GPLv2
> 
> License is actually GPLv2+.
Thank you, I will correct this.

> > +GMEDIARENDER_LICENSE_FILES = COPYING
> > +GMEDIARENDER_DEPENDENCIES = gstreamer libupnp
> > +GMEDIARENDER_CONF_OPTS = --with-libupnp=$(STAGING_DIR)/usr LIBS="-lixml"
> 
> Which package provides the ixml library ?
libixml is provided by libupnp package.

Regards,
Kawashima
============================================================
    Hiroshi Kawashima

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[Hiroshi Kawashima]

Dear Thomas.
Thank you for your review and comment.

1) This project is old and last update is 2007, so it still depsnds on
   gstreamer 0.10.x.
2) AUTORECONF is not needed actually.

I will send new v2 patch later.

Regards,
Kawashima

> [snip]
> > > +config BR2_PACKAGE_GMEDIARENDER
> > > +	bool "gmediarender"
> > > +	depends on BR2_USE_WCHAR # gstreamer
> > > +	depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer, libupnp
> > > +	depends on BR2_USE_MMU # gstreamer
> > > +	select BR2_PACKAGE_GSTREAMER
> > 
> > So it really only supports GStreamer 0.10.x (which is deprecated) and
> > not GStreamer 1.x ?
> Ok, let me check.
> 
> [snip]
> > > +GMEDIARENDER_VERSION = 0.0.6
> > > +GMEDIARENDER_SOURCE = gmediarender-$(GMEDIARENDER_VERSION).tar.bz2
> > > +GMEDIARENDER_SITE = http://savannah.nongnu.org/download/gmrender
> > > +GMEDIARENDER_AUTORECONF = YES
> > 
> > Can you add a justification for the AUTORECONF = YES here (in a comment
> > above the line) ?
> Ok, let me check again if really need this.
============================================================
    Hiroshi Kawashima

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[Thomas Petazzoni]

Hiroshi,

On Sun, 18 Oct 2015 09:49:13 +0900, Hiroshi Kawashima wrote:

> Thank you for your review and comment.

Thanks for your feedback.

> 1) This project is old and last update is 2007, so it still depsnds on
>    gstreamer 0.10.x.

Then is it really useful to package this in Buildroot? I'm a bit
worried about adding packages that rely only on GStreamer 0.10.
GStreamer 0.10 is deprecated, and we should rather start thinking of
removing it from Buildroot rather than adding more packages that depend
on it.

Maybe you should consider some other application than gmediarender for
your project ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[Hiroshi Kawashima]

Dear Thomas.

Thank you for your comment and suggestion.
I agree with your opinion, abondon this.

I find out good successor project of gmediarender, gmrender-resurrect
hosted on github.

It is maintained and has improved functionarity (eg. OpenHome support etc),
of course it is compatible with gstreamer v1.0.x.

I will send patch later for this.

Thank you,
Kawashima

Thomas Petazzoni writes:
> Hiroshi,
> 
> On Sun, 18 Oct 2015 09:49:13 +0900, Hiroshi Kawashima wrote:
> 
> > Thank you for your review and comment.
> 
> Thanks for your feedback.
> 
> > 1) This project is old and last update is 2007, so it still depsnds on
> >    gstreamer 0.10.x.
> 
> Then is it really useful to package this in Buildroot? I'm a bit
> worried about adding packages that rely only on GStreamer 0.10.
> GStreamer 0.10 is deprecated, and we should rather start thinking of
> removing it from Buildroot rather than adding more packages that depend
> on it.
> 
> Maybe you should consider some other application than gmediarender for
> your project ?
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
============================================================
    Hiroshi Kawashima

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[Thomas Petazzoni]

Dear Hiroshi Kawashima,

On Mon, 19 Oct 2015 21:03:13 +0900, Hiroshi Kawashima wrote:
> Dear Thomas.
> 
> Thank you for your comment and suggestion.
> I agree with your opinion, abondon this.
> 
> I find out good successor project of gmediarender, gmrender-resurrect
> hosted on github.
> 
> It is maintained and has improved functionarity (eg. OpenHome support etc),
> of course it is compatible with gstreamer v1.0.x.
> 
> I will send patch later for this.

Thanks! Can you mark your patch as "Rejected" in patchwork then?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v1 1/1] gmediarender: new package

[kei]

Sure, done.

> 2015/10/19 21:06?Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ?????
> 
> Dear Hiroshi Kawashima,
> 
> On Mon, 19 Oct 2015 21:03:13 +0900, Hiroshi Kawashima wrote:
>> Dear Thomas.
>> 
>> Thank you for your comment and suggestion.
>> I agree with your opinion, abondon this.
>> 
>> I find out good successor project of gmediarender, gmrender-resurrect
>> hosted on github.
>> 
>> It is maintained and has improved functionarity (eg. OpenHome support etc),
>> of course it is compatible with gstreamer v1.0.x.
>> 
>> I will send patch later for this.
> 
> Thanks! Can you mark your patch as "Rejected" in patchwork then?
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com