From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/kodi-visualisation-goom: new package
Date: Sun, 18 Oct 2015 23:24:14 +0200 [thread overview]
Message-ID: <20151018232414.72103d46@free-electrons.com> (raw)
In-Reply-To: <1445170286-12871-1-git-send-email-bernd.kuhls@t-online.de>
Bernd,
On Sun, 18 Oct 2015 14:11:25 +0200, Bernd Kuhls wrote:
> diff --git a/package/kodi-visualisation-goom/0001-cross-compile.patch b/package/kodi-visualisation-goom/0001-cross-compile.patch
> new file mode 100644
> index 0000000..3b051f2
> --- /dev/null
> +++ b/package/kodi-visualisation-goom/0001-cross-compile.patch
> @@ -0,0 +1,29 @@
> +Fix cross-compilation
> +
> +Use the cross-compiler and not the host version.
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +
> +diff -uNr visualization.goom-fb5933ba5b2143d055cc7749dc60a82f6002b305.org/CMakeLists.txt visualization.goom-fb5933ba5b2143d055cc7749dc60a82f6002b305/CMakeLists.txt
> +--- visualization.goom-fb5933ba5b2143d055cc7749dc60a82f6002b305.org/CMakeLists.txt 2014-10-31 11:34:21.000000000 +0100
> ++++ visualization.goom-fb5933ba5b2143d055cc7749dc60a82f6002b305/CMakeLists.txt 2015-07-19 19:49:43.340054342 +0200
> +@@ -13,6 +13,10 @@
> + ${KODI_INCLUDE_DIR}
> + ${PROJECT_SOURCE_DIR}/lib/goom2k4-0/src)
> +
> ++get_filename_component( COMPILER_FILENAME "${CMAKE_C_COMPILER}" NAME )
> ++string( REGEX REPLACE "-[^-]+$" ""
> ++ TOOLCHAIN_NAME "${COMPILER_FILENAME}" )
Yerk, this is really horrible. But I guess you don't have much choice
here: a CMake build system that calls into an autotools build system
has high chances of requiring ugly things. But ok, we can take your
proposal (did you submit it upstream?).
> +KODI_VISUALISATION_GOOM_VERSION = 98137474683e7a4e18c61cd3710ea4bfebad9759
> +KODI_VISUALISATION_GOOM_SITE = $(call github,notspiff,visualization.goom,$(KODI_VISUALISATION_GOOM_VERSION))
> +KODI_VISUALISATION_GOOM_LICENSE = GPLv2+
Yes according to src/Main.cpp
> +KODI_VISUALISATION_GOOM_LICENSE_FILES = COPYING
But this file contains the text of the GPLv3. Can you report the issue
upstream?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-10-18 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 12:11 [Buildroot] [PATCH v2 1/2] package/kodi-visualisation-goom: new package Bernd Kuhls
2015-10-18 12:11 ` [Buildroot] [PATCH v2 2/2] package/kodi-screensaver-rsxs: " Bernd Kuhls
2015-10-18 12:21 ` Baruch Siach
2015-10-18 21:26 ` Thomas Petazzoni
2015-10-18 21:24 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018232414.72103d46@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox