Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] package/kodi-screensaver-rsxs: new package
Date: Sun, 18 Oct 2015 23:26:35 +0200	[thread overview]
Message-ID: <20151018232635.554b8862@free-electrons.com> (raw)
In-Reply-To: <1445170286-12871-2-git-send-email-bernd.kuhls@t-online.de>

Bernd,

On Sun, 18 Oct 2015 14:11:26 +0200, Bernd Kuhls wrote:

> ++get_filename_component( COMPILER_FILENAME "${CMAKE_C_COMPILER}" NAME )
> ++string( REGEX REPLACE "-[^-]+$" ""
> ++        TOOLCHAIN_NAME "${COMPILER_FILENAME}" )
> ++

Same as for the goom one: can you submit this upstream?

> diff --git a/package/kodi-screensaver-rsxs/kodi-screensaver-rsxs.mk b/package/kodi-screensaver-rsxs/kodi-screensaver-rsxs.mk
> new file mode 100644
> index 0000000..2df7683
> --- /dev/null
> +++ b/package/kodi-screensaver-rsxs/kodi-screensaver-rsxs.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# kodi-screensaver-rsxs
> +#
> +################################################################################
> +
> +KODI_SCREENSAVER_RSXS_VERSION = 195e0ec3fbbcb2ee2012cd560e42d05167f0f259
> +KODI_SCREENSAVER_RSXS_SITE = $(call github,notspiff,screensavers.rsxs,$(KODI_SCREENSAVER_RSXS_VERSION))

Can you add the licensing information? I know there is none in the
upstream package, but this is not normal. Can you ask upstream to add
licensing details ?

Also, for github packages, we now what to have a hash file. Can you add
one (for both this one and goom) ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-10-18 21:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 12:11 [Buildroot] [PATCH v2 1/2] package/kodi-visualisation-goom: new package Bernd Kuhls
2015-10-18 12:11 ` [Buildroot] [PATCH v2 2/2] package/kodi-screensaver-rsxs: " Bernd Kuhls
2015-10-18 12:21   ` Baruch Siach
2015-10-18 21:26   ` Thomas Petazzoni [this message]
2015-10-18 21:24 ` [Buildroot] [PATCH v2 1/2] package/kodi-visualisation-goom: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151018232635.554b8862@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox