Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] musl: Make only shared libraries conditional
@ 2015-10-15 15:27 Charles Duffy
  2015-10-19 21:05 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Charles Duffy @ 2015-10-15 15:27 UTC (permalink / raw)
  To: buildroot

From: Charles Duffy <charles@dyfis.net>

External toolchain use requires a static libc (as buildroot uses
`gcc --print-file-name libc.a` to find the sysroot); thus, the static portion
of a musl build should not be conditional.

Signed-off-by: Charles Duffy <chaduffy@cisco.com>
---
 package/musl/musl.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/musl/musl.mk b/package/musl/musl.mk
index f0c45f5..2f43aab 100644
--- a/package/musl/musl.mk
+++ b/package/musl/musl.mk
@@ -29,7 +29,8 @@ define MUSL_CONFIGURE_CMDS
 			--prefix=/usr \
 			--libdir=/lib \
 			--disable-gcc-wrapper \
-			$(SHARED_STATIC_LIBS_OPTS))
+			--enable-static \
+			$(if $(BR2_STATIC_LIBS),--disable-shared,--enable-shared))
 endef
 
 define MUSL_BUILD_CMDS
-- 
2.0.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] musl: Make only shared libraries conditional
  2015-10-15 15:27 [Buildroot] [PATCH 1/1] musl: Make only shared libraries conditional Charles Duffy
@ 2015-10-19 21:05 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-10-19 21:05 UTC (permalink / raw)
  To: buildroot

Dear Charles Duffy,

On Thu, 15 Oct 2015 10:27:18 -0500, Charles Duffy wrote:
> From: Charles Duffy <charles@dyfis.net>
> 
> External toolchain use requires a static libc (as buildroot uses
> `gcc --print-file-name libc.a` to find the sysroot); thus, the static portion
> of a musl build should not be conditional.
> 
> Signed-off-by: Charles Duffy <chaduffy@cisco.com>
> ---
>  package/musl/musl.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-19 21:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 15:27 [Buildroot] [PATCH 1/1] musl: Make only shared libraries conditional Charles Duffy
2015-10-19 21:05 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox