* [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)
@ 2015-10-20 14:05 Vicente Olivert Riera
2015-10-20 14:05 ` [Buildroot] [PATCH 2/3] dhcpdump: add project URL Vicente Olivert Riera
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Vicente Olivert Riera @ 2015-10-20 14:05 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/dhcpdump/dhcpdump.mk | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/dhcpdump/dhcpdump.mk b/package/dhcpdump/dhcpdump.mk
index 6b677a6..3584f4f 100644
--- a/package/dhcpdump/dhcpdump.mk
+++ b/package/dhcpdump/dhcpdump.mk
@@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
endif
define DHCPDUMP_BUILD_CMDS
- $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \
- LIBS="$(DHCPDUMP_LIBS)"
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \
+ -D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)"
endef
define DHCPDUMP_INSTALL_TARGET_CMDS
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 2/3] dhcpdump: add project URL
2015-10-20 14:05 [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Vicente Olivert Riera
@ 2015-10-20 14:05 ` Vicente Olivert Riera
2015-10-20 20:19 ` Peter Korsgaard
2015-10-20 20:23 ` Peter Korsgaard
2015-10-20 14:05 ` [Buildroot] [PATCH 3/3] dhcpdump: add a hash file Vicente Olivert Riera
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Vicente Olivert Riera @ 2015-10-20 14:05 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/dhcpdump/Config.in | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/dhcpdump/Config.in b/package/dhcpdump/Config.in
index 1840e34..2368a46 100644
--- a/package/dhcpdump/Config.in
+++ b/package/dhcpdump/Config.in
@@ -3,3 +3,5 @@ config BR2_PACKAGE_DHCPDUMP
select BR2_PACKAGE_LIBPCAP
help
A tool for monitoring dhcp requests using tcpdump.
+
+ http://www.mavetju.org/
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 2/3] dhcpdump: add project URL
2015-10-20 14:05 ` [Buildroot] [PATCH 2/3] dhcpdump: add project URL Vicente Olivert Riera
@ 2015-10-20 20:19 ` Peter Korsgaard
2015-10-20 20:23 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2015-10-20 20:19 UTC (permalink / raw)
To: buildroot
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/3] dhcpdump: add project URL
2015-10-20 14:05 ` [Buildroot] [PATCH 2/3] dhcpdump: add project URL Vicente Olivert Riera
2015-10-20 20:19 ` Peter Korsgaard
@ 2015-10-20 20:23 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2015-10-20 20:23 UTC (permalink / raw)
To: buildroot
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/dhcpdump/Config.in | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> diff --git a/package/dhcpdump/Config.in b/package/dhcpdump/Config.in
> index 1840e34..2368a46 100644
> --- a/package/dhcpdump/Config.in
> +++ b/package/dhcpdump/Config.in
> @@ -3,3 +3,5 @@ config BR2_PACKAGE_DHCPDUMP
> select BR2_PACKAGE_LIBPCAP
> help
> A tool for monitoring dhcp requests using tcpdump.
> +
> + http://www.mavetju.org/
Actually, this is more like a personal page. I've changed it to
http://www.mavetju.org/unix/general.php instead.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/3] dhcpdump: add a hash file
2015-10-20 14:05 [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Vicente Olivert Riera
2015-10-20 14:05 ` [Buildroot] [PATCH 2/3] dhcpdump: add project URL Vicente Olivert Riera
@ 2015-10-20 14:05 ` Vicente Olivert Riera
2015-10-20 20:22 ` Peter Korsgaard
2015-10-20 20:18 ` [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Peter Korsgaard
2015-10-21 20:11 ` Thomas Petazzoni
3 siblings, 1 reply; 9+ messages in thread
From: Vicente Olivert Riera @ 2015-10-20 14:05 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/dhcpdump/dhcpdump.hash | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
create mode 100644 package/dhcpdump/dhcpdump.hash
diff --git a/package/dhcpdump/dhcpdump.hash b/package/dhcpdump/dhcpdump.hash
new file mode 100644
index 0000000..36040c8
--- /dev/null
+++ b/package/dhcpdump/dhcpdump.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 6d5eb9418162fb738bc56e4c1682ce7f7392dd96e568cc996e44c28de7f77190 dhcpdump-1.8.tar.gz
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)
2015-10-20 14:05 [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Vicente Olivert Riera
2015-10-20 14:05 ` [Buildroot] [PATCH 2/3] dhcpdump: add project URL Vicente Olivert Riera
2015-10-20 14:05 ` [Buildroot] [PATCH 3/3] dhcpdump: add a hash file Vicente Olivert Riera
@ 2015-10-20 20:18 ` Peter Korsgaard
2015-10-21 9:20 ` Vicente Olivert Riera
2015-10-21 20:11 ` Thomas Petazzoni
3 siblings, 1 reply; 9+ messages in thread
From: Peter Korsgaard @ 2015-10-20 20:18 UTC (permalink / raw)
To: buildroot
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
A more detailed commit message would be good. Is this just for
consistency or does it fix anything? (E.G. does the build system execute
anything from HOST_DIR)?
> ---
> package/dhcpdump/dhcpdump.mk | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> diff --git a/package/dhcpdump/dhcpdump.mk b/package/dhcpdump/dhcpdump.mk
> index 6b677a6..3584f4f 100644
> --- a/package/dhcpdump/dhcpdump.mk
> +++ b/package/dhcpdump/dhcpdump.mk
> @@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
> endif
> define DHCPDUMP_BUILD_CMDS
> - $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \
> - LIBS="$(DHCPDUMP_LIBS)"
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \
> + -D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)"
> endef
> define DHCPDUMP_INSTALL_TARGET_CMDS
> --
> 1.7.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)
2015-10-20 20:18 ` [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Peter Korsgaard
@ 2015-10-21 9:20 ` Vicente Olivert Riera
0 siblings, 0 replies; 9+ messages in thread
From: Vicente Olivert Riera @ 2015-10-21 9:20 UTC (permalink / raw)
To: buildroot
Hello Peter,
On 10/20/2015 09:18 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> A more detailed commit message would be good. Is this just for
> consistency or does it fix anything? (E.G. does the build system execute
> anything from HOST_DIR)?
No, it's just for consistency.
Regards,
Vincent.
>
>> ---
> > package/dhcpdump/dhcpdump.mk | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
>
> > diff --git a/package/dhcpdump/dhcpdump.mk b/package/dhcpdump/dhcpdump.mk
> > index 6b677a6..3584f4f 100644
> > --- a/package/dhcpdump/dhcpdump.mk
> > +++ b/package/dhcpdump/dhcpdump.mk
> > @@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
> > endif
>
> > define DHCPDUMP_BUILD_CMDS
> > - $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \
> > - LIBS="$(DHCPDUMP_LIBS)"
> > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \
> > + -D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)"
> > endef
>
> > define DHCPDUMP_INSTALL_TARGET_CMDS
> > --
> > 1.7.1
>
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)
2015-10-20 14:05 [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Vicente Olivert Riera
` (2 preceding siblings ...)
2015-10-20 20:18 ` [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Peter Korsgaard
@ 2015-10-21 20:11 ` Thomas Petazzoni
3 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2015-10-21 20:11 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Tue, 20 Oct 2015 15:05:52 +0100, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/dhcpdump/dhcpdump.mk | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied after slightly tweaking the commit log following Peter's
comment, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-10-21 20:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-20 14:05 [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Vicente Olivert Riera
2015-10-20 14:05 ` [Buildroot] [PATCH 2/3] dhcpdump: add project URL Vicente Olivert Riera
2015-10-20 20:19 ` Peter Korsgaard
2015-10-20 20:23 ` Peter Korsgaard
2015-10-20 14:05 ` [Buildroot] [PATCH 3/3] dhcpdump: add a hash file Vicente Olivert Riera
2015-10-20 20:22 ` Peter Korsgaard
2015-10-20 20:18 ` [Buildroot] [PATCH 1/3] dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE) Peter Korsgaard
2015-10-21 9:20 ` Vicente Olivert Riera
2015-10-21 20:11 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox