Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wf111: fix overwriting module files during install
Date: Wed, 4 Nov 2015 11:00:34 +0100	[thread overview]
Message-ID: <20151104100034.GB24888@kwain> (raw)
In-Reply-To: <64CA5C49A43E314D9F7DAE05370E2F7B06771305@hed-dc01.hed.local>

On Tue, Nov 03, 2015 at 11:38:35AM -0600, Matthew Starr wrote:
> 
> The problem with this is the wf111 package depends on the manufacturer's
> build and install method through their makefile included in the binary
> file they
> provide as an input to the wf111 package.  This is a single step build
> and install
> process.  You could make a new set of steps to build and install in the
> wf111.mk file, but then any manufacturer changes in future versions of
> the
> software could and most likely will break the wf111.mk file.

I agree with Matthew, it is not possible to separate the build task from
the install one using the wf111 top Makefile as is. I see 3 solutions
here:

- We keep it this way, it's not the best solution from a Buildroot point
  of view but the package maintenance is easier.
- We make a patch to modify the top Makefile, separating properly the
  step phase from the install one.
- We explicitly do the compilation and installation in the wf111.mk
  file, by copying what is done in the Makefile (the install_static
  target calls other Makefile, and performs some actions to copy some
  files to destdir).

What do you recommend?

Thanks,

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-11-04 10:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 16:52 [Buildroot] [PATCH] wf111: fix overwriting module files during install Antoine Tenart
2015-11-03 17:34 ` Thomas Petazzoni
2015-11-03 18:38   ` Matthew Starr
     [not found]   ` <64CA5C49A43E314D9F7DAE05370E2F7B06771305@hed-dc01.hed.local>
2015-11-04 10:00     ` Antoine Tenart [this message]
2016-04-25 22:05 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151104100034.GB24888@kwain \
    --to=antoine.tenart@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox