From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wf111: fix overwriting module files during install
Date: Tue, 26 Apr 2016 00:05:23 +0200 [thread overview]
Message-ID: <20160426000523.06d9b9aa@free-electrons.com> (raw)
In-Reply-To: <1446569533-25368-1-git-send-email-antoine.tenart@free-electrons.com>
Hello,
On Tue, 3 Nov 2015 17:52:13 +0100, Antoine Tenart wrote:
> From: Matthew Starr <mstarr@hedonline.com>
>
> When installing the WF111 modules, the module.* files generated
> during the kernel compilation were overrided. This ended up having
> the wrong information about the modules compiled in a given image
> (and only the one about the WF111 module). This could be verified
> using the "modprobe -l" command, with only the wf111 module showing
> up.
>
> This patch fixes this, by removing the manual copy of the generated
> files (in WF111_INSTALL_TARGET_CMDS) and by instead using the build
> command to populate our target directory, containing the module.*
> files. This way the files are not overrided but instead updated
> with the additional WF111 informations.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> Tested-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> package/wf111/wf111.mk | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Sorry for the long delay. I've applied this patch, after changing it so
that the entire process takes place in the install-target step rather
than the build step. The rationale is mainly that for statistics
reasons, we do some tracking of which package installs what, and this
tracking is done around the install-target step, so it is quite
important that the build step doesn't install anything.
Also, I've done two other commits:
- One that makes a proper use of the WF111_VERSION variable
https://git.buildroot.net/buildroot/commit/?id=4389b88695ae01d0fd9e0ec69680b69c3d565095
- One that updates the wf111 package to version 5.2.2-r2, which is
needed for the driver to build with a modern kernel.
https://git.buildroot.net/buildroot/commit/?id=47b9c8ae2265179bd215742fda5f572e1b1aa394
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-04-25 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 16:52 [Buildroot] [PATCH] wf111: fix overwriting module files during install Antoine Tenart
2015-11-03 17:34 ` Thomas Petazzoni
2015-11-03 18:38 ` Matthew Starr
[not found] ` <64CA5C49A43E314D9F7DAE05370E2F7B06771305@hed-dc01.hed.local>
2015-11-04 10:00 ` Antoine Tenart
2016-04-25 22:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426000523.06d9b9aa@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox