* [Buildroot] [PATCH] toolchain/external:: Fix gdbserver install with linaro 2015.08
@ 2015-11-05 19:45 Trent Piepho
2015-11-05 19:55 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Trent Piepho @ 2015-11-05 19:45 UTC (permalink / raw)
To: buildroot
It's now in bin/gdbserver from the install dir of the toolchain.
Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
---
toolchain/toolchain-external/toolchain-external.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index 958ab18..843b1f8 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -645,7 +645,7 @@ define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS
if test "$(BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY)" = "y"; then \
$(call MESSAGE,"Copying gdbserver") ; \
gdbserver_found=0 ; \
- for d in $${ARCH_SYSROOT_DIR}/usr $${ARCH_SYSROOT_DIR}/../debug-root/usr $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} ; do \
+ for d in $${ARCH_SYSROOT_DIR}/usr $${ARCH_SYSROOT_DIR}/../debug-root/usr $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} ${TOOLCHAIN_EXTERNAL_INSTALL_DIR}; do \
if test -f $${d}/bin/gdbserver ; then \
install -m 0755 -D $${d}/bin/gdbserver $(TARGET_DIR)/usr/bin/gdbserver ; \
gdbserver_found=1 ; \
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] toolchain/external:: Fix gdbserver install with linaro 2015.08
2015-11-05 19:45 [Buildroot] [PATCH] toolchain/external:: Fix gdbserver install with linaro 2015.08 Trent Piepho
@ 2015-11-05 19:55 ` Yann E. MORIN
2015-11-05 20:12 ` [Buildroot] [PATCH v2] " Trent Piepho
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2015-11-05 19:55 UTC (permalink / raw)
To: buildroot
Trent, All,
On 2015-11-05 19:45 +0000, Trent Piepho spake thusly:
> It's now in bin/gdbserver from the install dir of the toolchain.
Indeed...
> Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
> ---
> toolchain/toolchain-external/toolchain-external.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index 958ab18..843b1f8 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -645,7 +645,7 @@ define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS
> if test "$(BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY)" = "y"; then \
> $(call MESSAGE,"Copying gdbserver") ; \
> gdbserver_found=0 ; \
> - for d in $${ARCH_SYSROOT_DIR}/usr $${ARCH_SYSROOT_DIR}/../debug-root/usr $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} ; do \
> + for d in $${ARCH_SYSROOT_DIR}/usr $${ARCH_SYSROOT_DIR}/../debug-root/usr $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} ${TOOLCHAIN_EXTERNAL_INSTALL_DIR}; do \
It might be time to split this overly-long line, like so:
for d in $${ARCH_SYSROOT_DIR}/usr \
$${ARCH_SYSROOT_DIR}/../debug-root/usr \
$${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} \
${TOOLCHAIN_EXTERNAL_INSTALL_DIR}; do \
Also, we use the $(FOO) construct when refering to Makefile variables,
and TOOLCHAIN_EXTERNAL_INSTALL_DIR *is* a Makefile variable. Care to fix
and respin, please?
Thank you! :-)
Regards,
Yann E. MORIN.
> if test -f $${d}/bin/gdbserver ; then \
> install -m 0755 -D $${d}/bin/gdbserver $(TARGET_DIR)/usr/bin/gdbserver ; \
> gdbserver_found=1 ; \
> --
> 1.8.3.1
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2] toolchain/external:: Fix gdbserver install with linaro 2015.08
2015-11-05 19:55 ` Yann E. MORIN
@ 2015-11-05 20:12 ` Trent Piepho
2015-11-05 20:29 ` Yann E. MORIN
2015-11-05 22:25 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Trent Piepho @ 2015-11-05 20:12 UTC (permalink / raw)
To: buildroot
It's now in bin/gdbserver from the install dir of the toolchain.
Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
---
toolchain/toolchain-external/toolchain-external.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index 958ab18..613ce50 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -645,7 +645,10 @@ define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS
if test "$(BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY)" = "y"; then \
$(call MESSAGE,"Copying gdbserver") ; \
gdbserver_found=0 ; \
- for d in $${ARCH_SYSROOT_DIR}/usr $${ARCH_SYSROOT_DIR}/../debug-root/usr $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} ; do \
+ for d in $${ARCH_SYSROOT_DIR}/usr \
+ $${ARCH_SYSROOT_DIR}/../debug-root/usr \
+ $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} \
+ $(TOOLCHAIN_EXTERNAL_INSTALL_DIR); do \
if test -f $${d}/bin/gdbserver ; then \
install -m 0755 -D $${d}/bin/gdbserver $(TARGET_DIR)/usr/bin/gdbserver ; \
gdbserver_found=1 ; \
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2] toolchain/external:: Fix gdbserver install with linaro 2015.08
2015-11-05 20:12 ` [Buildroot] [PATCH v2] " Trent Piepho
@ 2015-11-05 20:29 ` Yann E. MORIN
2015-11-05 22:25 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2015-11-05 20:29 UTC (permalink / raw)
To: buildroot
Trent, All,
On 2015-11-05 20:12 +0000, Trent Piepho spake thusly:
> It's now in bin/gdbserver from the install dir of the toolchain.
You could have said:
In the latest Linaro toolchain, the gdbserver has moved (surprise!)
and is now located side-by-side with the toolchain executables.
And this path as a new location where to search for a gdbserver.
Note: wrapping the long line at the same time.
;-)
> Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
Otherwise:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> toolchain/toolchain-external/toolchain-external.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index 958ab18..613ce50 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -645,7 +645,10 @@ define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS
> if test "$(BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY)" = "y"; then \
> $(call MESSAGE,"Copying gdbserver") ; \
> gdbserver_found=0 ; \
> - for d in $${ARCH_SYSROOT_DIR}/usr $${ARCH_SYSROOT_DIR}/../debug-root/usr $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} ; do \
> + for d in $${ARCH_SYSROOT_DIR}/usr \
> + $${ARCH_SYSROOT_DIR}/../debug-root/usr \
> + $${ARCH_SYSROOT_DIR}/usr/$${ARCH_LIB_DIR} \
> + $(TOOLCHAIN_EXTERNAL_INSTALL_DIR); do \
> if test -f $${d}/bin/gdbserver ; then \
> install -m 0755 -D $${d}/bin/gdbserver $(TARGET_DIR)/usr/bin/gdbserver ; \
> gdbserver_found=1 ; \
> --
> 1.8.3.1
>
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v2] toolchain/external:: Fix gdbserver install with linaro 2015.08
2015-11-05 20:12 ` [Buildroot] [PATCH v2] " Trent Piepho
2015-11-05 20:29 ` Yann E. MORIN
@ 2015-11-05 22:25 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-11-05 22:25 UTC (permalink / raw)
To: buildroot
Dear Trent Piepho,
On Thu, 5 Nov 2015 20:12:32 +0000, Trent Piepho wrote:
> It's now in bin/gdbserver from the install dir of the toolchain.
>
> Signed-off-by: Trent Piepho <tpiepho@kymetacorp.com>
> ---
> toolchain/toolchain-external/toolchain-external.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied after tweaking the commit title and commit log, in part using
the suggestion from Yann E. Morin.
See:
http://git.buildroot.net/buildroot/commit/?id=d7a92aa2fbe1cfd13c8d0bf7c7942b2ead747ffe
for the final commit.
Thanks a lot for this contribution!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-05 22:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-05 19:45 [Buildroot] [PATCH] toolchain/external:: Fix gdbserver install with linaro 2015.08 Trent Piepho
2015-11-05 19:55 ` Yann E. MORIN
2015-11-05 20:12 ` [Buildroot] [PATCH v2] " Trent Piepho
2015-11-05 20:29 ` Yann E. MORIN
2015-11-05 22:25 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox