[Buildroot] [PATCH] system: Fix warning when selecting systemd

[Buildroot] [PATCH] system: Fix warning when selecting systemd

[Maxime Hadjinlian]

With systemd and a custom skeleton, you end up with the following
warning:
warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has
unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/Config.in b/system/Config.in
index 4d07010..92712a8 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
-	select BR2_ROOTFS_MERGED_USR
+	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT
 	select BR2_PACKAGE_SYSTEMD
 
 comment "systemd needs (e)glibc toolchain, headers >= 3.10"
-- 
2.6.1

[Buildroot] [PATCH] system: Fix warning when selecting systemd

[Yann E. MORIN]

Maxime, All,

On 2015-11-06 19:23 +0100, Maxime Hadjinlian spake thusly:
> With systemd and a custom skeleton, you end up with the following
> warning:
> warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has
> unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  system/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 4d07010..92712a8 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
>  	depends on BR2_USE_MMU
>  	depends on !BR2_STATIC_LIBS
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
> -	select BR2_ROOTFS_MERGED_USR
> +	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT
>  	select BR2_PACKAGE_SYSTEMD
>  
>  comment "systemd needs (e)glibc toolchain, headers >= 3.10"
> -- 
> 2.6.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] system: Fix warning when selecting systemd

[Thomas Petazzoni]

Dear Maxime Hadjinlian,

On Fri,  6 Nov 2015 19:23:45 +0100, Maxime Hadjinlian wrote:
> With systemd and a custom skeleton, you end up with the following
> warning:
> warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has
> unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  system/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] system: Fix warning when selecting systemd

[Peter Korsgaard]

>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > With systemd and a custom skeleton, you end up with the following
 > warning:
 > warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has
 > unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)

 > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
 > ---
 >  system/Config.in | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/system/Config.in b/system/Config.in
 > index 4d07010..92712a8 100644
 > --- a/system/Config.in
 > +++ b/system/Config.in
 > @@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
 >  	depends on BR2_USE_MMU
 >  	depends on !BR2_STATIC_LIBS
 >  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
 > -	select BR2_ROOTFS_MERGED_USR
 > +	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT

Hmm, we have a number of workarounds for merged /usr under package/, so
those packages will break with a custom skeleton (that contains a merged
/usr as required by systemd) as those workarounds are not performed.

Perhaps we should instead introduce a hidden BR2_ROOTFS_MERGED_USR
kconfig option for the !BR2_ROOTFS_SKELETON_DEFAULT case?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] system: Fix warning when selecting systemd

[Yann E. MORIN]

Peter, All,

On 2015-11-09 21:31 +0100, Peter Korsgaard spake thusly:
> >>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
> 
>  > With systemd and a custom skeleton, you end up with the following
>  > warning:
>  > warning: (BR2_INIT_SYSTEMD) selects BR2_ROOTFS_MERGED_USR which has
>  > unmet direct dependencies (BR2_ROOTFS_SKELETON_DEFAULT)
> 
>  > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>  > ---
>  >  system/Config.in | 2 +-
>  >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>  > diff --git a/system/Config.in b/system/Config.in
>  > index 4d07010..92712a8 100644
>  > --- a/system/Config.in
>  > +++ b/system/Config.in
>  > @@ -92,7 +92,7 @@ config BR2_INIT_SYSTEMD
>  >  	depends on BR2_USE_MMU
>  >  	depends on !BR2_STATIC_LIBS
>  >  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
>  > -	select BR2_ROOTFS_MERGED_USR
>  > +	select BR2_ROOTFS_MERGED_USR if BR2_ROOTFS_SKELETON_DEFAULT
> 
> Hmm, we have a number of workarounds for merged /usr under package/, so
> those packages will break with a custom skeleton (that contains a merged
> /usr as required by systemd) as those workarounds are not performed.
> 
> Perhaps we should instead introduce a hidden BR2_ROOTFS_MERGED_USR
> kconfig option for the !BR2_ROOTFS_SKELETON_DEFAULT case?

Hmm... Good point. I'll see to work on it...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'