From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] valgrind: fix musl compile
Date: Thu, 12 Nov 2015 22:48:49 +0100 [thread overview]
Message-ID: <20151112224849.6d683112@gmx.net> (raw)
In-Reply-To: <56437591.1090806@openwide.fr>
Hello Romain,
On Wed, 11 Nov 2015 18:06:25 +0100, Romain Naour <romain.naour@openwide.fr> wrote:
[...]
> > +--- a/configure.ac
> > ++++ b/configure.ac
> > +@@ -1066,8 +1066,9 @@ case "${GLIBC_VERSION}" in
> > + ;;
> > + 2.0|2.1|*)
> > + AC_MSG_RESULT([unsupported version ${GLIBC_VERSION}])
> > +- AC_MSG_ERROR([Valgrind requires glibc version 2.2 or later,])
> > +- AC_MSG_ERROR([Darwin libc, Bionic libc or Solaris libc])
> > ++ AC_MSG_WARN([Valgrind requires glibc version 2.2 or later,])
> > ++ AC_MSG_WARN([Darwin libc, Bionic libc or Solaris libc])
> > ++ GLIBC_VERSION=musl
>
> This part of this patch break the glibc check for unsupported version 2.0 and 2.1.
Yes I know, its only a workaround for the buildroot build...
>
> If you want to upstream the patch, maybe you can check if GLIBC_VERSION is empty
> and use the toolchain tuple instead ?
>
> Something like:
>
> # GLIBC_VERSION is empty if a musl libc is used, so use the toolchain tuple
> # in this case.
> if test x$GLIBC_VERSION = x; then
> TUPLE=`$CC -dumpmachine | grep musl`
> if test -n $TUPLE; then
> GLIBC_VERSION=musl
> fi
> fi
>
> AC_MSG_CHECKING([the glibc version])
>
> case "${GLIBC_VERSION}" in
> ...
> musl)
> AC_MSG_RESULT(Musl)
> ;;
> ...
>
> Thoughts?
>
Many thanks for the suggestion, will try to cook up a patch...
Regards,
Peter
> Best regards,
> Romain Naour
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2015-11-12 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 18:59 [Buildroot] [PATCH v1] valgrind: fix musl compile Peter Seiderer
2015-11-11 17:06 ` Romain Naour
2015-11-11 23:31 ` Arnout Vandecappelle
2015-11-12 21:48 ` Peter Seiderer [this message]
2015-12-19 13:22 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112224849.6d683112@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox