From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] valgrind: fix musl compile
Date: Sat, 19 Dec 2015 14:22:23 +0100 [thread overview]
Message-ID: <20151219142223.2d0bb215@free-electrons.com> (raw)
In-Reply-To: <1446317942-18726-1-git-send-email-ps.report@gmx.net>
Dear Peter Seiderer,
On Sat, 31 Oct 2015 19:59:02 +0100, Peter Seiderer wrote:
> Add patch disabling glibc version check and adding some tweaks
> for musl support (based on OpenWRT patch [1]).
>
> Fixes ([2]):
> checking the glibc version... unsupported version
> configure: error: Valgrind requires glibc version 2.2 or later
>
> [1] https://dev.openwrt.org/browser/trunk/package/devel/valgrind/patches/200-musl_fix.patch?rev=46302
> [2] http://autobuild.buildroot.org/results/7b0/7b048ba58918f0a08498c61327fcf35a85a84837/build-end.log
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
You have been given a number of comments on this patch. Could you rework
to take into account the comments and send an updated version?
Note that you can also find some musl compatibility patches at
http://git.alpinelinux.org/cgit/aports/tree/main/valgrind/.
In the mean time, I'll mark your patch as Changes Requested in
patchwork.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-12-19 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 18:59 [Buildroot] [PATCH v1] valgrind: fix musl compile Peter Seiderer
2015-11-11 17:06 ` Romain Naour
2015-11-11 23:31 ` Arnout Vandecappelle
2015-11-12 21:48 ` Peter Seiderer
2015-12-19 13:22 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151219142223.2d0bb215@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox