From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] hidapi: new package
Date: Mon, 16 Nov 2015 20:07:24 +0200 [thread overview]
Message-ID: <20151116180724.GK9908@tarshish> (raw)
In-Reply-To: <1447692852-21669-1-git-send-email-Vincent.Riera@imgtec.com>
Hi Vincent,
On Mon, Nov 16, 2015 at 04:54:12PM +0000, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
[...]
> +HIDAPI_DEPENDENCIES = libusb
> +# When eudev is used as the udev provider, libgudev is automatically
> +# provided as it is part of eudev. However, when systemd is used as the
> +# udev provider, libgudev is not provided, and needs to be built
> +# separately. This is why we select the libgudev package only if systemd
> +# is used.
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
Should be 'ifeq ($(BR2_PACKAGE_LIBGUDEV),y)', in think, since all we need is
to have libgudev built before this package, regardless of systemd. With this
change the comment becomes redundant. The comment in Config.in should be
enough.
> +HIDAPI_DEPENDENCIES += libgudev
> +endif
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-11-16 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 16:54 [Buildroot] [PATCH] hidapi: new package Vicente Olivert Riera
2015-11-16 18:07 ` Baruch Siach [this message]
2015-11-17 10:11 ` Vicente Olivert Riera
2015-11-18 4:50 ` Baruch Siach
2015-11-18 8:22 ` Thomas Petazzoni
2015-11-18 8:45 ` Baruch Siach
2015-11-18 8:55 ` Thomas Petazzoni
2015-11-17 21:04 ` Thomas Petazzoni
2015-11-26 4:14 ` Alan Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116180724.GK9908@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox