Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] hidapi: new package
Date: Wed, 18 Nov 2015 09:22:10 +0100	[thread overview]
Message-ID: <20151118092210.30ff22d2@free-electrons.com> (raw)
In-Reply-To: <20151118045051.GO9908@tarshish>

Baruch,

On Wed, 18 Nov 2015 06:50:51 +0200, Baruch Siach wrote:

> > Of course we could use ifeq ($(BR2_PACKAGE_LIBGUDEV),y) here, but, for
> > consistency with Config.in, I use ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> > instead. See for instance the udisks package.
> 
> I think this is wrong. First, consistency with Config.in calls for using 
> BR2_PACKAGE_LIBGUDEV like we do with all other selects. But more
> importantly, IMO, we only use the <pkg>_DEPENDENCIES variable to set
> the build order which is conceptually independent of the underlying
> reason we need this dependency, systemd in this case. I think that
> all the other packages that Thomas mentioned should also test for
> BR2_PACKAGE_LIBGUDEV when setting <pkg>_DEPENDENCIES.

I am not as clear-cut as you are on what is the correct thing to do
here, but your reasoning seems reasonable to me. So we need to align
the existing packages to do this, and also to use BR2_INIT_SYSTEMD in
Config.in (udisks uses BR2_PACKAGE_SYSTEMD). Will you send some patches
or should I do so?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-11-18  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 16:54 [Buildroot] [PATCH] hidapi: new package Vicente Olivert Riera
2015-11-16 18:07 ` Baruch Siach
2015-11-17 10:11   ` Vicente Olivert Riera
2015-11-18  4:50     ` Baruch Siach
2015-11-18  8:22       ` Thomas Petazzoni [this message]
2015-11-18  8:45         ` Baruch Siach
2015-11-18  8:55           ` Thomas Petazzoni
2015-11-17 21:04 ` Thomas Petazzoni
2015-11-26  4:14 ` Alan Ott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151118092210.30ff22d2@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox