[Buildroot] [PATCH 04/21 RFC] core/legal-info: allow ignoring packages from the legal-info

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Yann, Luca,

On Mon, 16 Nov 2015 23:46:59 +0100, Yann E. MORIN wrote:
> It might be necessary to not even mention a package in the output of
> legal-info:
> 
>   - virtual package have virtually nothing to save in the legal-info
>     output;
> 
>   - for Buildroot itself, host-gcc-initial and host-gcc-final are not
>     real packages, they are just two different steps of the same
>     package, gcc;
> 
>   - for proprietary packages, it might not even be legal to even mention
>     them, being under NDA or some other such restrictive conditions.
> 
> Add the new 'IGNORE' keyword to the _REDISTRIBUTE package variable, so
> that the legal-info infra will simply completely ignore that package.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>

I understand the idea, but I'm not a big fan of a boolean variable that
is no longer a boolean variable.

So, let me question the current handling of <pkg>_REDISTRIBUTE = NO.
Does it make sense to mention such packages in the legal-info output,
since their source code is not saved anyway?

Shouldn't we simply change the behavior of <pkg>_REDISTRIBUTE = NO to
be that such packages are not listed at all in the legal-info output,
which would match what you're looking for for with this "IGNORE" thing ?

Luca, do you see any drawback in completely omitting REDISTRIBUTE = NO
packages from legal-info ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com