From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 05/21 RFC] core/pkg-virtual: ignore from legal-info output
Date: Tue, 17 Nov 2015 12:25:23 +0100 [thread overview]
Message-ID: <20151117122523.0d924b33@free-electrons.com> (raw)
In-Reply-To: <e3506e59aa801227a1e47ccace2ef664fdaf0eca.1447713615.git.yann.morin.1998@free.fr>
Yann,
On Mon, 16 Nov 2015 23:47:00 +0100, Yann E. MORIN wrote:
> Virtual packages really have nothing to save for legal-info, so we just
> ignore them.
>
> Following patches will always extract-and-aptch non-ignored packages, so
> we would potentially see spurious "extracting" and "patching" messages
> on the console, which would be a bit strange. Ignoring virtual packages
> will get us a cleaner log.
aptch -> patch. And the extract-and-patch can be just "extract and
patch".
It's also not really clear what you mean by "Following patches will
always extract and patch non-ignored packages". Aren't we already doing
that for legal-info ? (Note: I haven't looked at the following patches
yet, things might get clearer when I'll reach the next patches, but it
seems weird to not understand a commit log if you haven't read the next
patches).
Otherwise, I'm fine with the change, as soon as we reach an agreement
on PATCH 04/21.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-11-17 11:25 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 22:47 [Buildroot] [PATCH 0/21 RFC] core/legal-info: fixes, completness and enhancements (branch yem/legal-patch) Yann E. MORIN
2015-11-16 22:46 ` [Buildroot] [PATCH 01/21 RFC] package/libecore: do not build anything at patch time Yann E. MORIN
2015-11-17 11:16 ` Thomas Petazzoni
2015-11-17 12:20 ` Romain Naour
2015-11-17 20:16 ` Romain Naour
2015-11-17 16:03 ` Peter Korsgaard
2015-11-16 22:46 ` [Buildroot] [PATCH 02/21 RFC] core/legal-info: fix missing double-$ Yann E. MORIN
2015-11-17 11:19 ` Thomas Petazzoni
2015-11-17 16:03 ` Peter Korsgaard
2015-11-16 22:46 ` [Buildroot] [PATCH 03/21 RFC] package/linux-headers: add licensing information Yann E. MORIN
2015-11-17 11:19 ` Thomas Petazzoni
2015-11-17 16:04 ` Peter Korsgaard
2015-11-16 22:46 ` [Buildroot] [PATCH 04/21 RFC] core/legal-info: allow ignoring packages from the legal-info Yann E. MORIN
2015-11-17 11:22 ` Thomas Petazzoni
2015-11-17 17:35 ` Luca Ceresoli
2015-11-17 19:28 ` Yann E. MORIN
2015-11-17 20:14 ` Thomas Petazzoni
2015-11-17 21:26 ` Yann E. MORIN
2015-11-17 21:43 ` Arnout Vandecappelle
2015-11-17 21:48 ` Arnout Vandecappelle
2015-11-16 22:47 ` [Buildroot] [PATCH 05/21 RFC] core/pkg-virtual: ignore from legal-info output Yann E. MORIN
2015-11-17 11:25 ` Thomas Petazzoni [this message]
2015-11-17 19:35 ` Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 06/21 RFC] package/gcc: add licensing information Yann E. MORIN
2015-11-17 11:28 ` Thomas Petazzoni
2015-11-17 21:15 ` Yann E. MORIN
2015-11-17 21:25 ` Thomas Petazzoni
2015-11-17 21:40 ` Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 07/21 RFC] package/gcc: handle " Yann E. MORIN
2015-11-17 11:31 ` Thomas Petazzoni
2015-11-17 21:20 ` Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 08/21 RFC] package/gcc: add a patch for arc rather than using sed Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 09/21 RFC] package/gcc: properly extract and patch sources Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 10/21 RFC] package/gcc: make host-gcc a pure host package Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 11/21 RFC] package/gcc: make -initial and -final use sources from host-gcc Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 12/21 RFC] package/gcc: include the extensa overlay in the legal-info output Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 13/21 RFC] package/perl: include perl-cross " Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 14/21 RFC] core: add a global variable with already-unquoted global patch dir Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 15/21 RFC] core/pkg-generic: add macro to hardlink-or-copy Yann E. MORIN
2015-11-18 15:40 ` Luca Ceresoli
2015-11-16 22:47 ` [Buildroot] [PATCH 16/21 RFC] core/legal-info: use the macro to install source archives Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 17/21 RFC] core/legal-info: install source archives in their own sub-dir Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 18/21 RFC] core/legal-info: add package version to license directory Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 19/21 RFC] core/apply-patches: store full path of applied patches Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 20/21 RFC] core/legal-info: also save patches Yann E. MORIN
2015-11-16 22:47 ` [Buildroot] [PATCH 21/21 RFC] core/pkg-infra: ensure legal-info works in off-line mode Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117122523.0d924b33@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox