Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] sdl: overwrite libpth autodetection
Date: Thu, 19 Nov 2015 22:09:37 +0100	[thread overview]
Message-ID: <20151119220937.7d378b47@gmx.net> (raw)
In-Reply-To: <20151119210559.GR2203@tarshish>

Hello Baruch,

On Thu, 19 Nov 2015 23:05:59 +0200, Baruch Siach <baruch@tkos.co.il> wrote:

> Hi Peter,
> 
> On Thu, Nov 19, 2015 at 09:53:45PM +0100, Peter Seiderer wrote:
> > The sdl libpth autodetection gets confused in case a host
> > version is detected. Overwrite libpth autodection for the
> > target  build dependent on BR2_PACKAGE_LIBPTHSEM.
> > 
> > Fixes [1]:
> > 
> > checking for pthreads... no
> > checking for pth-config... /usr/bin/pth-config
> > checking pth... yes
> > [...]
> > ./src/SDL.c:33:17: fatal error: pth.h: No such file or directory
> >  #include <pth.h>
> > 
> > [1] http://autobuild.buildroot.net/results/733/73330e51b3c099d179004db0b9522ac13358b8f7
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  package/sdl/sdl.mk | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> > index 78eb4dd..3e3496c 100644
> > --- a/package/sdl/sdl.mk
> > +++ b/package/sdl/sdl.mk
> > @@ -58,6 +58,13 @@ ifneq ($(BR2_USE_MMU),y)
> >  SDL_CONF_OPTS += --enable-dga=no
> >  endif
> >  
> > +# overwrite autodection (prevents confusion with host libpth version)
> > +ifeq ($(BR2_PACKAGE_LIBPTHSEM),y)
> 
> Should probably also add 'SDL_DEPENDENCIES += libpthsem'. 

Ups..., yes your are right..., will send a v2 patch version...

Thanks for review...

Regards,
Peter

> 
> > +SDL_CONF_OPTS +=  --enable-pth
> > +else
> > +SDL_CONF_OPTS +=  --disable-pth
> > +endif
> > +
> >  ifeq ($(BR2_PACKAGE_TSLIB),y)
> >  SDL_DEPENDENCIES += tslib
> >  endif
> 
> baruch
> 

      reply	other threads:[~2015-11-19 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 20:53 [Buildroot] [PATCH v1] sdl: overwrite libpth autodetection Peter Seiderer
2015-11-19 21:05 ` Baruch Siach
2015-11-19 21:09   ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151119220937.7d378b47@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox