* [Buildroot] [PATCH v1] sdl: overwrite libpth autodetection
@ 2015-11-19 20:53 Peter Seiderer
2015-11-19 21:05 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Peter Seiderer @ 2015-11-19 20:53 UTC (permalink / raw)
To: buildroot
The sdl libpth autodetection gets confused in case a host
version is detected. Overwrite libpth autodection for the
target build dependent on BR2_PACKAGE_LIBPTHSEM.
Fixes [1]:
checking for pthreads... no
checking for pth-config... /usr/bin/pth-config
checking pth... yes
[...]
./src/SDL.c:33:17: fatal error: pth.h: No such file or directory
#include <pth.h>
[1] http://autobuild.buildroot.net/results/733/73330e51b3c099d179004db0b9522ac13358b8f7
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/sdl/sdl.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
index 78eb4dd..3e3496c 100644
--- a/package/sdl/sdl.mk
+++ b/package/sdl/sdl.mk
@@ -58,6 +58,13 @@ ifneq ($(BR2_USE_MMU),y)
SDL_CONF_OPTS += --enable-dga=no
endif
+# overwrite autodection (prevents confusion with host libpth version)
+ifeq ($(BR2_PACKAGE_LIBPTHSEM),y)
+SDL_CONF_OPTS += --enable-pth
+else
+SDL_CONF_OPTS += --disable-pth
+endif
+
ifeq ($(BR2_PACKAGE_TSLIB),y)
SDL_DEPENDENCIES += tslib
endif
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] sdl: overwrite libpth autodetection
2015-11-19 20:53 [Buildroot] [PATCH v1] sdl: overwrite libpth autodetection Peter Seiderer
@ 2015-11-19 21:05 ` Baruch Siach
2015-11-19 21:09 ` Peter Seiderer
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2015-11-19 21:05 UTC (permalink / raw)
To: buildroot
Hi Peter,
On Thu, Nov 19, 2015 at 09:53:45PM +0100, Peter Seiderer wrote:
> The sdl libpth autodetection gets confused in case a host
> version is detected. Overwrite libpth autodection for the
> target build dependent on BR2_PACKAGE_LIBPTHSEM.
>
> Fixes [1]:
>
> checking for pthreads... no
> checking for pth-config... /usr/bin/pth-config
> checking pth... yes
> [...]
> ./src/SDL.c:33:17: fatal error: pth.h: No such file or directory
> #include <pth.h>
>
> [1] http://autobuild.buildroot.net/results/733/73330e51b3c099d179004db0b9522ac13358b8f7
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/sdl/sdl.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> index 78eb4dd..3e3496c 100644
> --- a/package/sdl/sdl.mk
> +++ b/package/sdl/sdl.mk
> @@ -58,6 +58,13 @@ ifneq ($(BR2_USE_MMU),y)
> SDL_CONF_OPTS += --enable-dga=no
> endif
>
> +# overwrite autodection (prevents confusion with host libpth version)
> +ifeq ($(BR2_PACKAGE_LIBPTHSEM),y)
Should probably also add 'SDL_DEPENDENCIES += libpthsem'.
> +SDL_CONF_OPTS += --enable-pth
> +else
> +SDL_CONF_OPTS += --disable-pth
> +endif
> +
> ifeq ($(BR2_PACKAGE_TSLIB),y)
> SDL_DEPENDENCIES += tslib
> endif
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v1] sdl: overwrite libpth autodetection
2015-11-19 21:05 ` Baruch Siach
@ 2015-11-19 21:09 ` Peter Seiderer
0 siblings, 0 replies; 3+ messages in thread
From: Peter Seiderer @ 2015-11-19 21:09 UTC (permalink / raw)
To: buildroot
Hello Baruch,
On Thu, 19 Nov 2015 23:05:59 +0200, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Peter,
>
> On Thu, Nov 19, 2015 at 09:53:45PM +0100, Peter Seiderer wrote:
> > The sdl libpth autodetection gets confused in case a host
> > version is detected. Overwrite libpth autodection for the
> > target build dependent on BR2_PACKAGE_LIBPTHSEM.
> >
> > Fixes [1]:
> >
> > checking for pthreads... no
> > checking for pth-config... /usr/bin/pth-config
> > checking pth... yes
> > [...]
> > ./src/SDL.c:33:17: fatal error: pth.h: No such file or directory
> > #include <pth.h>
> >
> > [1] http://autobuild.buildroot.net/results/733/73330e51b3c099d179004db0b9522ac13358b8f7
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > package/sdl/sdl.mk | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> > index 78eb4dd..3e3496c 100644
> > --- a/package/sdl/sdl.mk
> > +++ b/package/sdl/sdl.mk
> > @@ -58,6 +58,13 @@ ifneq ($(BR2_USE_MMU),y)
> > SDL_CONF_OPTS += --enable-dga=no
> > endif
> >
> > +# overwrite autodection (prevents confusion with host libpth version)
> > +ifeq ($(BR2_PACKAGE_LIBPTHSEM),y)
>
> Should probably also add 'SDL_DEPENDENCIES += libpthsem'.
Ups..., yes your are right..., will send a v2 patch version...
Thanks for review...
Regards,
Peter
>
> > +SDL_CONF_OPTS += --enable-pth
> > +else
> > +SDL_CONF_OPTS += --disable-pth
> > +endif
> > +
> > ifeq ($(BR2_PACKAGE_TSLIB),y)
> > SDL_DEPENDENCIES += tslib
> > endif
>
> baruch
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-19 21:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-19 20:53 [Buildroot] [PATCH v1] sdl: overwrite libpth autodetection Peter Seiderer
2015-11-19 21:05 ` Baruch Siach
2015-11-19 21:09 ` Peter Seiderer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox