[Buildroot] [PATCH v2] package/gauche: fix build error on BR2_STATIC_LIBS

[Buildroot] [PATCH v2] package/gauche: fix build error on BR2_STATIC_LIBS

[Hiroshi Kawashima]

Building gauche depends on dynamic link, so add dependency on
!BR2_STATIC_LIBS.

Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
---
Changes:
    v1 -> v2: previous patch conflict with latest master, so send again.
---
 package/gauche/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/gauche/Config.in b/package/gauche/Config.in
index 54a0be2..fd0617a 100644
--- a/package/gauche/Config.in
+++ b/package/gauche/Config.in
@@ -13,6 +13,7 @@ config BR2_PACKAGE_GAUCHE
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_ARCH_HAS_ATOMICS
 	depends on BR2_PACKAGE_GAUCHE_ARCH_SUPPORTS
+	depends on !BR2_STATIC_LIBS
 	help
 	  Gauche is an R7RS Scheme implementation developed to be a
 	  handy script interpreter, which allows programmers and
@@ -23,8 +24,8 @@ config BR2_PACKAGE_GAUCHE
 
 	  http://practical-scheme.net/gauche/
 
-comment "gauche needs a toolchain w/ NPTL"
+comment "gauche needs a toolchain w/ NPTL, dynamic library"
 	depends on BR2_USE_MMU
 	depends on BR2_ARCH_HAS_ATOMICS
 	depends on BR2_PACKAGE_GAUCHE_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
============================================================
    Hiroshi Kawashima

[Buildroot] [PATCH v2] package/gauche: fix build error on BR2_STATIC_LIBS

[Thomas Petazzoni]

Dear Hiroshi Kawashima,

On Thu, 19 Nov 2015 19:03:41 +0900, Hiroshi Kawashima wrote:
> Building gauche depends on dynamic link, so add dependency on
> !BR2_STATIC_LIBS.
> 
> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>

Thanks for this new version, but it was unnecessary. It seems like we
misunderstood each other. In my reply to your previous version of this
patch I said:

  Applied to master, thanks. However, your patch didn't apply properly,
  I had to fix up some conflicts. If possible, please try to send
  patches that apply on top of the latest master.

So I did say it was applied to master, and only asked you, for your
*next* contributions, to make sure that they apply on top of master.

See:
http://git.buildroot.net/buildroot/commit/?id=e9b415ace06b416a5743c97e13f4fd7df9666d85.
Your patch has already been applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com