Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] support/dependencies: ensure we have 'file' on the host
@ 2015-11-27 20:02 Yann E. MORIN
  2015-11-27 21:19 ` Arnout Vandecappelle
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Yann E. MORIN @ 2015-11-27 20:02 UTC (permalink / raw)
  To: buildroot

When 'file' is missing on the host, libtool fails miserably. Packages
that use libtool will suddenly FTBFS, with cryptic error messages, like
missing libraries on the linker invocation.

We could ensure that autotools based packages now all depend on
host-file. But It itself is an autotools package, so it's again a
chicken-n-egg issue. And even non-autotools package may use libtool.

So, just require that 'file' is present on the host.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 support/dependencies/dependencies.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index 3146401..f14fb79 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -69,6 +69,12 @@ check_prog_host "which"
 # Verify that sed is installed
 check_prog_host "sed"
 
+# 'file' must be present, otherwise libtool fails in incomprehensible
+# ways. For example, bandwidthd would fail to link with -lz, even
+# though the library is there (and it's not a static/shared issue).
+# Adding the 'file' program on the system miraculously fixes the issue.
+check_prog_host "file"
+
 # Check make
 MAKE=$(which make 2> /dev/null)
 if [ -z "$MAKE" ] ; then
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-11-29 22:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-27 20:02 [Buildroot] [PATCH] support/dependencies: ensure we have 'file' on the host Yann E. MORIN
2015-11-27 21:19 ` Arnout Vandecappelle
2015-11-27 23:04   ` Yann E. MORIN
2015-11-27 23:34     ` Arnout Vandecappelle
2015-11-28 22:30       ` Yann E. MORIN
2015-11-28 20:30 ` Baruch Siach
2015-11-28 22:11   ` Yann E. MORIN
2015-11-29 22:04 ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox