Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Missing 'sys/queue.h' on musl
Date: Mon, 30 Nov 2015 17:32:02 +0100	[thread overview]
Message-ID: <20151130173202.4f4933cc@free-electrons.com> (raw)
In-Reply-To: <CANu7NGuKGNtVyiWqN=KW1kW5zQA35NLaFVE2JP4GoS0wh3vuqw@mail.gmail.com>

Dear Sergio Prado,

On Mon, 30 Nov 2015 13:07:36 -0200, Sergio Prado wrote:

> I have created a package called sys-queue that will only install queue.h on
> the staging dir.
> 
> Then to make musl generated toolchain depends on sys-queue, I added the
> following lines to toolchain/toolchain-buildroot/toolchain-buildroot.mk:
> 
> ifeq ($(BR2_TOOLCHAIN_BUILDROOT_MUSL),y)
> TOOLCHAIN_BUILDROOT_DEPENDENCIES += sys-queue
> endif
> 
> It worked like a charm. Is this the correct approach?

No, because this will only work for internal toolchains. So instead,
you need to put this dependency in two places:

 1/ In package/musl/musl.mk, where it should be an unconditional
    dependency.

 2/ In toolchain/toolchain-external/toolchain-external.mk, where it
    should be conditional on BR2_TOOLCHAIN_USES_MUSL.

> Also, I am struggling to find out a way to do the same thing on the
> external toolchain. Using the DEPENDENCIES approach, it will process the
> sys-queue package before the external toolchain package, and it is best to
> do it after. Any ideas?

Is it really a problem if it is processed before?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-11-30 16:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 17:31 [Buildroot] Missing 'sys/queue.h' on musl Sergio Prado
2015-11-28 17:49 ` Thomas Petazzoni
2015-11-28 18:18   ` Sergio Prado
2015-11-28 18:20     ` Thomas Petazzoni
2015-11-28 20:42       ` Sergio Prado
2015-11-29  8:28         ` Thomas Petazzoni
2015-11-29  9:53           ` Yann E. MORIN
2015-11-29 22:14             ` Arnout Vandecappelle
2015-11-29 22:33               ` Thomas Petazzoni
2015-11-30 10:16                 ` Sergio Prado
2015-11-30 10:54                 ` Peter Korsgaard
2015-11-30 15:07                   ` Sergio Prado
2015-11-30 16:32                     ` Thomas Petazzoni [this message]
2015-11-30 21:34                       ` Arnout Vandecappelle
2015-11-30 22:56                         ` Sergio Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130173202.4f4933cc@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox