Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Missing 'sys/queue.h' on musl
Date: Sun, 29 Nov 2015 23:33:38 +0100	[thread overview]
Message-ID: <20151129233338.261cf080@free-electrons.com> (raw)
In-Reply-To: <565B78D8.6070103@mind.be>

Hello,

On Sun, 29 Nov 2015 23:14:48 +0100, Arnout Vandecappelle wrote:

> > Adding such a package would be a Buildroot peculiarity, which I would
> > prefer we avoid.
> 
>  +1 to that.
> 
>  Also take into account that we only install it to staging, so there is really
> nothing to gain from installing it conditionally.
> 
>  The only question is whether to do it in the toolchain virtual package (which
> would be unusual to say the least), or duplicate it in the musl and external
> toolchain packages. I actually think the latter is the way to go.

That's all fine with me. It is a lot better than duplicating
sys/queue.h everywhere. It is kind of adding a patch on top of musl
that we would have to keep on our side forever, but since it's just a
separate header file, there's no maintenance cost, so I think it's fine.

Regarding doing it in the toolchain virtual package or duplicate in
musl and external toolchain packages, I don't have a strong opinion
either way, so if Arnout feels like doing the duplication is better
then so be it. Despite the duplication I also believe it is more
logical to have it in the musl and external toolchain packages, since
doing that in the toolchain virtual package would make that package no
longer purely virtual.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-11-29 22:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 17:31 [Buildroot] Missing 'sys/queue.h' on musl Sergio Prado
2015-11-28 17:49 ` Thomas Petazzoni
2015-11-28 18:18   ` Sergio Prado
2015-11-28 18:20     ` Thomas Petazzoni
2015-11-28 20:42       ` Sergio Prado
2015-11-29  8:28         ` Thomas Petazzoni
2015-11-29  9:53           ` Yann E. MORIN
2015-11-29 22:14             ` Arnout Vandecappelle
2015-11-29 22:33               ` Thomas Petazzoni [this message]
2015-11-30 10:16                 ` Sergio Prado
2015-11-30 10:54                 ` Peter Korsgaard
2015-11-30 15:07                   ` Sergio Prado
2015-11-30 16:32                     ` Thomas Petazzoni
2015-11-30 21:34                       ` Arnout Vandecappelle
2015-11-30 22:56                         ` Sergio Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151129233338.261cf080@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox