* [Buildroot] [PATCH 1/1] autofs: new package
@ 2015-11-22 13:48 Jonathan Ben-Avraham
2015-11-23 5:41 ` Baruch Siach
2015-11-30 21:26 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Jonathan Ben-Avraham @ 2015-11-22 13:48 UTC (permalink / raw)
To: buildroot
From: Jonathan Ben Avraham <yba@tkos.co.il>
Add the autofs package from kernel.org
Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>
---
package/Config.in | 1 +
package/autofs/Config.in | 16 ++++++++++++++++
package/autofs/autofs.hash | 2 ++
package/autofs/autofs.mk | 21 +++++++++++++++++++++
4 files changed, 40 insertions(+)
create mode 100644 package/autofs/Config.in
create mode 100644 package/autofs/autofs.hash
create mode 100644 package/autofs/autofs.mk
diff --git a/package/Config.in b/package/Config.in
index bdc3063..9e59352 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -149,6 +149,7 @@ endif
endmenu
menu "Filesystem and flash utilities"
+ source "package/autofs/Config.in"
source "package/btrfs-progs/Config.in"
source "package/cifs-utils/Config.in"
source "package/cpio/Config.in"
diff --git a/package/autofs/Config.in b/package/autofs/Config.in
new file mode 100644
index 0000000..2db185b
--- /dev/null
+++ b/package/autofs/Config.in
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_AUTOFS
+ bool "autofs"
+ select BR2_PACKAGE_NFS_UTILS # runtime
+ select BR2_PACKAGE_RPCBIND # runtime
+ depends on BR2_TOOLCHAIN_HAS_THREADS # rpcbind
+ depends on BR2_USE_MMU # nfs-utils, rpcbind
+ help
+ Based on the Debian autofs package description:
+ Autofs controls the operation of the automount daemons. The automount
+ daemons automatically mount filesystems when they are used and unmount
+ them after a period of inactivity based on a set of pre-configured
+ maps defined by default in /etc/auto.master. The kernel automounter
+ implements SunOS style automounter under Linux and requires a kernel
+ version of at least 2.6.17 and the autofs4 kernel module.
+
+ git://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git
diff --git a/package/autofs/autofs.hash b/package/autofs/autofs.hash
new file mode 100644
index 0000000..2d98375
--- /dev/null
+++ b/package/autofs/autofs.hash
@@ -0,0 +1,2 @@
+# From https://www.kernel.org/pub/linux/daemons/autofs/v5/sha256sums.asc
+sha256 e08ff0ef9ff365d87b6c33dca136d20e4e07675197a324f2816894cb437021c3 autofs-5.1.1.tar.xz
diff --git a/package/autofs/autofs.mk b/package/autofs/autofs.mk
new file mode 100644
index 0000000..0de6b97
--- /dev/null
+++ b/package/autofs/autofs.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# autofs
+#
+################################################################################
+
+AUTOFS_VERSION = 5.1.1
+AUTOFS_SOURCE = autofs-$(AUTOFS_VERSION).tar.xz
+AUTOFS_SITE = $(BR2_KERNEL_MIRROR)/linux/daemons/autofs/v5
+AUTOFS_LICENSE = GPLv2+
+AUTOFS_LICENSE_FILES = COPYING COPYRIGHT
+
+AUTOFS_CONF_OPTS = --disable-mount-locking \
+ --enable-ignore-busy \
+ --with-openldap=no \
+ --with-sasl=no \
+ --with-libtirpc=no
+
+AUTOFS_MAKE_ENV = DONTSTRIP=1
+
+$(eval $(autotools-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] autofs: new package
2015-11-22 13:48 [Buildroot] [PATCH 1/1] autofs: new package Jonathan Ben-Avraham
@ 2015-11-23 5:41 ` Baruch Siach
2015-11-23 6:00 ` Jonathan Ben Avraham
2015-11-30 21:26 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2015-11-23 5:41 UTC (permalink / raw)
To: buildroot
Hi Yonatan,
On Sun, Nov 22, 2015 at 03:48:20PM +0200, Jonathan Ben-Avraham wrote:
> +config BR2_PACKAGE_AUTOFS
> + bool "autofs"
> + select BR2_PACKAGE_NFS_UTILS # runtime
> + select BR2_PACKAGE_RPCBIND # runtime
> + depends on BR2_TOOLCHAIN_HAS_THREADS # rpcbind
> + depends on BR2_USE_MMU # nfs-utils, rpcbind
> + help
> + Based on the Debian autofs package description:
> + Autofs controls the operation of the automount daemons. The automount
> + daemons automatically mount filesystems when they are used and unmount
> + them after a period of inactivity based on a set of pre-configured
> + maps defined by default in /etc/auto.master. The kernel automounter
> + implements SunOS style automounter under Linux and requires a kernel
> + version of at least 2.6.17 and the autofs4 kernel module.
> +
> + git://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git
The browser friendly link
https://git.kernel.org/cgit/linux/storage/autofs/autofs.git/ would be better
here, I believe.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] autofs: new package
2015-11-23 5:41 ` Baruch Siach
@ 2015-11-23 6:00 ` Jonathan Ben Avraham
2015-11-23 6:27 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Ben Avraham @ 2015-11-23 6:00 UTC (permalink / raw)
To: buildroot
On Mon, 23 Nov 2015, Baruch Siach wrote:
> Date: Mon, 23 Nov 2015 07:41:01 +0200
> From: Baruch Siach <baruch@tkos.co.il>
> To: Jonathan Ben-Avraham <yba@tkos.co.il>
> Cc: buildroot at busybox.net
> Subject: Re: [Buildroot] [PATCH 1/1] autofs: new package
>
> Hi Yonatan,
>
> On Sun, Nov 22, 2015 at 03:48:20PM +0200, Jonathan Ben-Avraham wrote:
>> +config BR2_PACKAGE_AUTOFS
>> + bool "autofs"
>> + select BR2_PACKAGE_NFS_UTILS # runtime
>> + select BR2_PACKAGE_RPCBIND # runtime
>> + depends on BR2_TOOLCHAIN_HAS_THREADS # rpcbind
>> + depends on BR2_USE_MMU # nfs-utils, rpcbind
>> + help
>> + Based on the Debian autofs package description:
>> + Autofs controls the operation of the automount daemons. The automount
>> + daemons automatically mount filesystems when they are used and unmount
>> + them after a period of inactivity based on a set of pre-configured
>> + maps defined by default in /etc/auto.master. The kernel automounter
>> + implements SunOS style automounter under Linux and requires a kernel
>> + version of at least 2.6.17 and the autofs4 kernel module.
>> +
>> + git://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git
>
> The browser friendly link
> https://git.kernel.org/cgit/linux/storage/autofs/autofs.git/ would be better
> here, I believe.
Why? I always struggle to convert back from the browser URLs to plain git
URL's so that I can see the sources in vi on my machine and index them.
Why would anyone want to use an HTML browser to do this? Doesn't make
sense.
- yba
> baruch
>
>
--
9590 8E58 D30D 1660 C349 673D B205 4FC4 B8F5 B7F9 ~. .~ Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhm
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] autofs: new package
2015-11-23 6:00 ` Jonathan Ben Avraham
@ 2015-11-23 6:27 ` Baruch Siach
[not found] ` <alpine.DEB.2.11.1511230845330.26339@tanhuma.tkos.co.il>
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2015-11-23 6:27 UTC (permalink / raw)
To: buildroot
Hi Yonatan,
On Mon, Nov 23, 2015 at 08:00:32AM +0200, Jonathan Ben Avraham wrote:
> On Mon, 23 Nov 2015, Baruch Siach wrote:
> >On Sun, Nov 22, 2015 at 03:48:20PM +0200, Jonathan Ben-Avraham wrote:
> >>+config BR2_PACKAGE_AUTOFS
> >>+ bool "autofs"
> >>+ select BR2_PACKAGE_NFS_UTILS # runtime
> >>+ select BR2_PACKAGE_RPCBIND # runtime
> >>+ depends on BR2_TOOLCHAIN_HAS_THREADS # rpcbind
> >>+ depends on BR2_USE_MMU # nfs-utils, rpcbind
> >>+ help
> >>+ Based on the Debian autofs package description:
> >>+ Autofs controls the operation of the automount daemons. The automount
> >>+ daemons automatically mount filesystems when they are used and unmount
> >>+ them after a period of inactivity based on a set of pre-configured
> >>+ maps defined by default in /etc/auto.master. The kernel automounter
> >>+ implements SunOS style automounter under Linux and requires a kernel
> >>+ version of at least 2.6.17 and the autofs4 kernel module.
> >>+
> >>+ git://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git
> >
> >The browser friendly link
> >https://git.kernel.org/cgit/linux/storage/autofs/autofs.git/ would be better
> >here, I believe.
>
> Why? I always struggle to convert back from the browser URLs to plain git
> URL's so that I can see the sources in vi on my machine and index them. Why
> would anyone want to use an HTML browser to do this? Doesn't make sense.
Well, we usually put a link to the project homepage. In the absence of a
suitable homepage, we use a git repo link. You can find a git/vi friendly link
if you scroll down the git repo summary page. Converting the other way seems
to me quite a bit harder for the less git/vi literate.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] autofs: new package
2015-11-22 13:48 [Buildroot] [PATCH 1/1] autofs: new package Jonathan Ben-Avraham
2015-11-23 5:41 ` Baruch Siach
@ 2015-11-30 21:26 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-11-30 21:26 UTC (permalink / raw)
To: buildroot
Dear Jonathan Ben-Avraham,
On Sun, 22 Nov 2015 15:48:20 +0200, Jonathan Ben-Avraham wrote:
> From: Jonathan Ben Avraham <yba@tkos.co.il>
>
> Add the autofs package from kernel.org
>
> Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>
This package doesn't build when the toolchain doesn't have RPC support,
it fails due to <rpc/rpc.h> being unavailable. You can reproduce with
this configuration:
BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-basic-2015.11-rc1-71-g90d1299.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_3=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_AUTOFS=y
# BR2_TARGET_ROOTFS_TAR is not set
I've tried to add libtirpc support in it:
+ select BR2_PACKAGE_LIBTIRPC if !BR2_INET_RPC
in Config.in and
+ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
+AUTOFS_CONF_OPTS += --with-libtirpc
+AUTOFS_DEPENDENCIES += libtirpc
+else
+AUTOFS_CONF_OPTS += --without-libtirpc
+endif
in the .mk file, but it still doesn't find the headers because they are
located in <sysroot>/usr/include/tirpc/. The m4 code that checks for
libtirpc is wrong, as it hardcodes looking in /usr/include/tirpc:
AC_DEFUN([AF_CHECK_LIBTIRPC],
[
# save current flags
af_check_libtirpc_save_cflags="$CFLAGS"
af_check_libtirpc_save_ldflags="$LDFLAGS"
CFLAGS="$CFLAGS -I/usr/include/tirpc"
More comments below.
> diff --git a/package/autofs/Config.in b/package/autofs/Config.in
> new file mode 100644
> index 0000000..2db185b
> --- /dev/null
> +++ b/package/autofs/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_AUTOFS
> + bool "autofs"
> + select BR2_PACKAGE_NFS_UTILS # runtime
> + select BR2_PACKAGE_RPCBIND # runtime
> + depends on BR2_TOOLCHAIN_HAS_THREADS # rpcbind
> + depends on BR2_USE_MMU # nfs-utils, rpcbind
> + help
> + Based on the Debian autofs package description:
> + Autofs controls the operation of the automount daemons. The automount
> + daemons automatically mount filesystems when they are used and unmount
> + them after a period of inactivity based on a set of pre-configured
> + maps defined by default in /etc/auto.master. The kernel automounter
> + implements SunOS style automounter under Linux and requires a kernel
> + version of at least 2.6.17 and the autofs4 kernel module.
Lines are too long, please wrap at 72.
> + git://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git
As Baruch said, please make this link an http link. Yes, I've followed
your argumentation with Baruch, but I believe a http:// link is still
better.
> diff --git a/package/autofs/autofs.mk b/package/autofs/autofs.mk
> new file mode 100644
> index 0000000..0de6b97
> --- /dev/null
> +++ b/package/autofs/autofs.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# autofs
> +#
> +################################################################################
> +
> +AUTOFS_VERSION = 5.1.1
> +AUTOFS_SOURCE = autofs-$(AUTOFS_VERSION).tar.xz
> +AUTOFS_SITE = $(BR2_KERNEL_MIRROR)/linux/daemons/autofs/v5
> +AUTOFS_LICENSE = GPLv2+
> +AUTOFS_LICENSE_FILES = COPYING COPYRIGHT
> +
> +AUTOFS_CONF_OPTS = --disable-mount-locking \
> + --enable-ignore-busy \
> + --with-openldap=no \
> + --with-sasl=no \
> + --with-libtirpc=no
We prefer --without-<foo> rather than --with-<foo>=no.
So basically, your patch was almost ready to go, except for the build
issue on non-RPC capable toolchains.
Can you look into it and send an updated version?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-30 21:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-22 13:48 [Buildroot] [PATCH 1/1] autofs: new package Jonathan Ben-Avraham
2015-11-23 5:41 ` Baruch Siach
2015-11-23 6:00 ` Jonathan Ben Avraham
2015-11-23 6:27 ` Baruch Siach
[not found] ` <alpine.DEB.2.11.1511230845330.26339@tanhuma.tkos.co.il>
[not found] ` <20151123071348.GL2177@tarshish>
2015-11-23 7:22 ` Jonathan Ben Avraham
2015-11-30 21:26 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox