Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] manual: clarify policy when updating a package patch
Date: Wed, 2 Dec 2015 06:34:14 +0200	[thread overview]
Message-ID: <20151202043414.GI2193@tarshish> (raw)
In-Reply-To: <1449002515-27302-1-git-send-email-arnout@mind.be>

Hi Arnout,

On Tue, Dec 01, 2015 at 09:41:55PM +0100, Arnout Vandecappelle (Essensium/Mind) wrote:
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Renaud AUBIN <root@renaud.io>
> ---
>  docs/manual/patch-policy.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/docs/manual/patch-policy.txt b/docs/manual/patch-policy.txt
> index 6e27e71..bb859bd 100644
> --- a/docs/manual/patch-policy.txt
> +++ b/docs/manual/patch-policy.txt
> @@ -106,6 +106,10 @@ upstream SCM software to generate the patch set.
>  Otherwise, concatenate the header with the output of the
>  +diff -purN package-version.orig/ package-version/+ command.
>  
> +If you update an existing patch (e.g. when bumping the package version),
> +make sure the original author and existing Signed-off-by tags are not
> +removed.

Since not all patches we carry have an author (From:) header this text might 
be a little confusing. Maybe:

   ... make sure the original author (the 'From:' header, when the patch has 
   one) and existing Signed-off-by ...

It maybe also be worth a mention that not all existing patches have a sign-off 
tag.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      reply	other threads:[~2015-12-02  4:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 20:41 [Buildroot] [PATCH] manual: clarify policy when updating a package patch Arnout Vandecappelle
2015-12-02  4:34 ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202043414.GI2193@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox