* [Buildroot] [PATCH] manual: clarify policy when updating a package patch
@ 2015-12-01 20:41 Arnout Vandecappelle
2015-12-02 4:34 ` Baruch Siach
0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2015-12-01 20:41 UTC (permalink / raw)
To: buildroot
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Renaud AUBIN <root@renaud.io>
---
docs/manual/patch-policy.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/docs/manual/patch-policy.txt b/docs/manual/patch-policy.txt
index 6e27e71..bb859bd 100644
--- a/docs/manual/patch-policy.txt
+++ b/docs/manual/patch-policy.txt
@@ -106,6 +106,10 @@ upstream SCM software to generate the patch set.
Otherwise, concatenate the header with the output of the
+diff -purN package-version.orig/ package-version/+ command.
+If you update an existing patch (e.g. when bumping the package version),
+make sure the original author and existing Signed-off-by tags are not
+removed.
+
At the end, the patch should look like:
---------------
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] manual: clarify policy when updating a package patch
2015-12-01 20:41 [Buildroot] [PATCH] manual: clarify policy when updating a package patch Arnout Vandecappelle
@ 2015-12-02 4:34 ` Baruch Siach
0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2015-12-02 4:34 UTC (permalink / raw)
To: buildroot
Hi Arnout,
On Tue, Dec 01, 2015 at 09:41:55PM +0100, Arnout Vandecappelle (Essensium/Mind) wrote:
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Renaud AUBIN <root@renaud.io>
> ---
> docs/manual/patch-policy.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/docs/manual/patch-policy.txt b/docs/manual/patch-policy.txt
> index 6e27e71..bb859bd 100644
> --- a/docs/manual/patch-policy.txt
> +++ b/docs/manual/patch-policy.txt
> @@ -106,6 +106,10 @@ upstream SCM software to generate the patch set.
> Otherwise, concatenate the header with the output of the
> +diff -purN package-version.orig/ package-version/+ command.
>
> +If you update an existing patch (e.g. when bumping the package version),
> +make sure the original author and existing Signed-off-by tags are not
> +removed.
Since not all patches we carry have an author (From:) header this text might
be a little confusing. Maybe:
... make sure the original author (the 'From:' header, when the patch has
one) and existing Signed-off-by ...
It maybe also be worth a mention that not all existing patches have a sign-off
tag.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-02 4:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-01 20:41 [Buildroot] [PATCH] manual: clarify policy when updating a package patch Arnout Vandecappelle
2015-12-02 4:34 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox