[Buildroot] [PATCH 1/1] package/libhdhomerun: new package

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH 1/1] package/libhdhomerun: new package
@ 2015-12-13 10:58 Bernd Kuhls
  2015-12-13 11:33 ` Baruch Siach
  0 siblings, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2015-12-13 10:58 UTC (permalink / raw)
  To: buildroot

Needed for new kodi-pvr-hdhomerun package.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/Config.in                          |  1 +
 package/libhdhomerun/0001-dont-strip.patch | 18 ++++++++++++++++
 package/libhdhomerun/Config.in             | 12 +++++++++++
 package/libhdhomerun/libhdhomerun.hash     |  2 ++
 package/libhdhomerun/libhdhomerun.mk       | 33 ++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+)
 create mode 100644 package/libhdhomerun/0001-dont-strip.patch
 create mode 100644 package/libhdhomerun/Config.in
 create mode 100644 package/libhdhomerun/libhdhomerun.hash
 create mode 100644 package/libhdhomerun/libhdhomerun.mk

diff --git a/package/Config.in b/package/Config.in
index fd9863a..dfb89c3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -982,6 +982,7 @@ menu "Multimedia"
 	source "package/libfslcodec/Config.in"
 	source "package/libfslparser/Config.in"
 	source "package/libfslvpuwrap/Config.in"
+	source "package/libhdhomerun/Config.in"
 	source "package/libmatroska/Config.in"
 	source "package/libmms/Config.in"
 	source "package/libmpeg2/Config.in"
diff --git a/package/libhdhomerun/0001-dont-strip.patch b/package/libhdhomerun/0001-dont-strip.patch
new file mode 100644
index 0000000..17a9ff4
--- /dev/null
+++ b/package/libhdhomerun/0001-dont-strip.patch
@@ -0,0 +1,18 @@
+Disable strip in Makefile.
+
+Patch downloaded from Gentoo:
+https://gitweb.gentoo.org/repo/gentoo.git/tree/media-libs/libhdhomerun/files/dont-strip.patch
+
+Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+
+diff -Nur libhdhomerun/Makefile libhdhomerun.fix/Makefile
+--- libhdhomerun/Makefile	2012-08-30 15:46:27.000000000 -0500
++++ libhdhomerun.fix/Makefile	2013-03-24 14:47:08.740937164 -0500
+@@ -42,7 +42,6 @@
+ 
+ hdhomerun_config$(BINEXT) : hdhomerun_config.c $(LIBSRCS)
+ 	$(CC) $(CFLAGS) $+ $(LDFLAGS) -o $@
+-	$(STRIP) $@
+ 
+ libhdhomerun$(LIBEXT) : $(LIBSRCS)
+ 	$(CC) $(CFLAGS) -fPIC -DDLL_EXPORT $(SHARED) $+ $(LDFLAGS) -o $@
diff --git a/package/libhdhomerun/Config.in b/package/libhdhomerun/Config.in
new file mode 100644
index 0000000..a49527a
--- /dev/null
+++ b/package/libhdhomerun/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_LIBHDHOMERUN
+	bool "libhdhomerun"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_STATIC_LIBS
+	help
+	  HDHomeRun is a network-attached digital television tuner box,
+	  produced by the company SiliconDust USA, Inc.
+
+	  http://www.silicondust.com
+
+comment "libhdhomerun needs a toolchain w/ threads, dynamic library"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
diff --git a/package/libhdhomerun/libhdhomerun.hash b/package/libhdhomerun/libhdhomerun.hash
new file mode 100644
index 0000000..7897764
--- /dev/null
+++ b/package/libhdhomerun/libhdhomerun.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256	907dfbd1eb82aebd8b09e7c00c21a02433e6baaacf4a4f99aa2511b1d5244baf	libhdhomerun_20150826.tgz
diff --git a/package/libhdhomerun/libhdhomerun.mk b/package/libhdhomerun/libhdhomerun.mk
new file mode 100644
index 0000000..2dc3a99
--- /dev/null
+++ b/package/libhdhomerun/libhdhomerun.mk
@@ -0,0 +1,33 @@
+################################################################################
+#
+# libhdhomerun
+#
+################################################################################
+
+LIBHDHOMERUN_VERSION = 20150826
+LIBHDHOMERUN_SOURCE = libhdhomerun_$(LIBHDHOMERUN_VERSION).tgz
+LIBHDHOMERUN_SITE = http://download.silicondust.com/hdhomerun
+LIBHDHOMERUN_LICENSE = LGPLv2.1+
+LIBHDHOMERUN_LICENSE_FILES = lgpl.txt
+LIBHDHOMERUN_INSTALL_STAGING = YES
+
+define LIBHDHOMERUN_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		CROSS_COMPILE="$(TARGET_CROSS)" -C $(@D)
+endef
+
+define LIBHDHOMERUN_INSTALL_STAGING_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
+		$(STAGING_DIR)/usr/lib/libhdhomerun.so
+	$(INSTALL) -D -m 0644 $(@D)/*.h \
+		$(STAGING_DIR)/usr/include/
+endef
+
+define LIBHDHOMERUN_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/hdhomerun_config \
+		$(TARGET_DIR)/usr/bin/hdhomerun_config
+	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
+		$(TARGET_DIR)/usr/lib/libhdhomerun.so
+endef
+
+$(eval $(generic-package))
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/libhdhomerun: new package
  2015-12-13 10:58 [Buildroot] [PATCH 1/1] package/libhdhomerun: new package Bernd Kuhls
@ 2015-12-13 11:33 ` Baruch Siach
  2015-12-13 11:47   ` Bernd Kuhls
  0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2015-12-13 11:33 UTC (permalink / raw)
  To: buildroot

Hi Bernd,

On Sun, Dec 13, 2015 at 11:58:16AM +0100, Bernd Kuhls wrote:
> +define LIBHDHOMERUN_INSTALL_STAGING_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
> +		$(STAGING_DIR)/usr/lib/libhdhomerun.so
> +	$(INSTALL) -D -m 0644 $(@D)/*.h \
> +		$(STAGING_DIR)/usr/include/
> +endef
> +
> +define LIBHDHOMERUN_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/hdhomerun_config \
> +		$(TARGET_DIR)/usr/bin/hdhomerun_config

Are you sure this is not for staging?

> +	$(INSTALL) -D -m 0755 $(@D)/libhdhomerun.so \
> +		$(TARGET_DIR)/usr/lib/libhdhomerun.so
> +endef

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/libhdhomerun: new package
  2015-12-13 11:33 ` Baruch Siach
@ 2015-12-13 11:47   ` Bernd Kuhls
  2015-12-13 12:03     ` Baruch Siach
  0 siblings, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2015-12-13 11:47 UTC (permalink / raw)
  To: buildroot

Hi Baruch,

Am Sun, 13 Dec 2015 13:33:42 +0200 schrieb Baruch Siach:

> Hi Bernd,
> 
> On Sun, Dec 13, 2015 at 11:58:16AM +0100, Bernd Kuhls wrote:
>> +define LIBHDHOMERUN_INSTALL_STAGING_CMDS +	$(INSTALL) -D -m 0755
>> $(@D)/libhdhomerun.so \ +		$(STAGING_DIR)/usr/lib/
libhdhomerun.so +
>> $(INSTALL) -D -m 0644 $(@D)/*.h \ +		$(STAGING_DIR)/usr/
include/
>> +endef +
>> +define LIBHDHOMERUN_INSTALL_TARGET_CMDS +	$(INSTALL) -D -m 0755
>> $(@D)/hdhomerun_config \
>> +		$(TARGET_DIR)/usr/bin/hdhomerun_config
> 
> Are you sure this is not for staging?

yes, because it is not a script but a binary compiled for the target:

$ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
hdhomerun_config
/home/bernd/buildroot/br2_kodi16/output/target/usr/bin/hdhomerun_config: 
ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, 
interpreter /lib/ld64-uClibc.so.0, not stripped

I am not sure whether the file is really needed on the target or not but 
it is definitely not suited for staging.

Regards, Bernd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/libhdhomerun: new package
  2015-12-13 11:47   ` Bernd Kuhls
@ 2015-12-13 12:03     ` Baruch Siach
  2015-12-13 13:43       ` Bernd Kuhls
  0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2015-12-13 12:03 UTC (permalink / raw)
  To: buildroot

Hi Bernd,

On Sun, Dec 13, 2015 at 12:47:11PM +0100, Bernd Kuhls wrote:
> Am Sun, 13 Dec 2015 13:33:42 +0200 schrieb Baruch Siach:
> > On Sun, Dec 13, 2015 at 11:58:16AM +0100, Bernd Kuhls wrote:
> >> +define LIBHDHOMERUN_INSTALL_STAGING_CMDS +	$(INSTALL) -D -m 0755
> >> $(@D)/libhdhomerun.so \ +		$(STAGING_DIR)/usr/lib/
> libhdhomerun.so +
> >> $(INSTALL) -D -m 0644 $(@D)/*.h \ +		$(STAGING_DIR)/usr/
> include/
> >> +endef +
> >> +define LIBHDHOMERUN_INSTALL_TARGET_CMDS +	$(INSTALL) -D -m 0755
> >> $(@D)/hdhomerun_config \
> >> +		$(TARGET_DIR)/usr/bin/hdhomerun_config
> > 
> > Are you sure this is not for staging?
> 
> yes, because it is not a script but a binary compiled for the target:
> 
> $ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
> hdhomerun_config
> /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/hdhomerun_config: 
> ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, 
> interpreter /lib/ld64-uClibc.so.0, not stripped

This most likely matches your host. Is that your target as well?

> I am not sure whether the file is really needed on the target or not but it 
> is definitely not suited for staging.

Agreed. But is this file really intended for target use? Most library *_config 
files are only useful during build. What is the purpose of hdhomerun_config?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/libhdhomerun: new package
  2015-12-13 12:03     ` Baruch Siach
@ 2015-12-13 13:43       ` Bernd Kuhls
  2015-12-13 18:59         ` Baruch Siach
  0 siblings, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2015-12-13 13:43 UTC (permalink / raw)
  To: buildroot

Hi Baruch,

Am Sun, 13 Dec 2015 14:03:53 +0200 schrieb Baruch Siach:

> Hi Bernd,
> 
> On Sun, Dec 13, 2015 at 12:47:11PM +0100, Bernd Kuhls wrote:
>> Am Sun, 13 Dec 2015 13:33:42 +0200 schrieb Baruch Siach:
>> > 
>> > Are you sure this is not for staging?
>> 
>> yes, because it is not a script but a binary compiled for the target:
>> 
>> $ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
>> hdhomerun_config
>> /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
hdhomerun_config:
>> ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically
>> linked, interpreter /lib/ld64-uClibc.so.0, not stripped
> 
> This most likely matches your host. Is that your target as well?

coincidentally yes, here is the arm version:

$ file /home/bernd/buildroot/br2_kodi16/output/target/usr/bin/
hdhomerun_config
/home/bernd/buildroot/br2_kodi16/output/target/usr/bin/hdhomerun_config: 
ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), dynamically 
linked, interpreter /lib/ld-uClibc.so.0, not stripped

>> I am not sure whether the file is really needed on the target or not
>> but it is definitely not suited for staging.
> 
> Agreed. But is this file really intended for target use? Most library
> *_config files are only useful during build. What is the purpose of
> hdhomerun_config?

Honestly I do not know, so I sent v2 of my patch:
http://patchwork.ozlabs.org/patch/556182/
If someone misses hdhomerun_config a follow-up patch is needed ;)

Regards, Bernd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/libhdhomerun: new package
  2015-12-13 13:43       ` Bernd Kuhls
@ 2015-12-13 18:59         ` Baruch Siach
  0 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2015-12-13 18:59 UTC (permalink / raw)
  To: buildroot

Hi Bernd,

On Sun, Dec 13, 2015 at 02:43:10PM +0100, Bernd Kuhls wrote:
> Am Sun, 13 Dec 2015 14:03:53 +0200 schrieb Baruch Siach:
> > Agreed. But is this file really intended for target use? Most library
> > *_config files are only useful during build. What is the purpose of
> > hdhomerun_config?

Some digging shows that this is a configuration utility for the Silicon Dust 
HDHomeRun hardware. Debian ships it in a separate hdhomerun-config package.

> Honestly I do not know, so I sent v2 of my patch:
> http://patchwork.ozlabs.org/patch/556182/
> If someone misses hdhomerun_config a follow-up patch is needed ;)

Fair enough.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-12-13 18:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-13 10:58 [Buildroot] [PATCH 1/1] package/libhdhomerun: new package Bernd Kuhls
2015-12-13 11:33 ` Baruch Siach
2015-12-13 11:47   ` Bernd Kuhls
2015-12-13 12:03     ` Baruch Siach
2015-12-13 13:43       ` Bernd Kuhls
2015-12-13 18:59         ` Baruch Siach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox