* [Buildroot] [PATCH] package/netsniff: fix missing depend on statements
@ 2015-12-13 16:19 Samuel Martin
2015-12-13 17:23 ` Yann E. MORIN
2015-12-13 18:05 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Samuel Martin @ 2015-12-13 16:19 UTC (permalink / raw)
To: buildroot
Add missing architecture dependencies inherited from liburcu.
Fixes:
http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
package/netsniff-ng/Config.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/netsniff-ng/Config.in b/package/netsniff-ng/Config.in
index 8c48f39..65b2a0f 100644
--- a/package/netsniff-ng/Config.in
+++ b/package/netsniff-ng/Config.in
@@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
depends on BR2_TOOLCHAIN_USES_GLIBC
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
+ depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu
help
netsniff-ng is a free, performant Linux network analyzer and
networking toolkit. If you will, the Swiss army knife for
network packets.
comment "netsniff-ng needs an (e)glibc toolchain w/ threads"
+ depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"
+ depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854
--
2.6.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/netsniff: fix missing depend on statements
2015-12-13 16:19 [Buildroot] [PATCH] package/netsniff: fix missing depend on statements Samuel Martin
@ 2015-12-13 17:23 ` Yann E. MORIN
2015-12-13 18:05 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-12-13 17:23 UTC (permalink / raw)
To: buildroot
Samuel, All,
On 2015-12-13 17:19 +0100, Samuel Martin spake thusly:
> Add missing architecture dependencies inherited from liburcu.
>
> Fixes:
> http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/netsniff-ng/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/netsniff-ng/Config.in b/package/netsniff-ng/Config.in
> index 8c48f39..65b2a0f 100644
> --- a/package/netsniff-ng/Config.in
> +++ b/package/netsniff-ng/Config.in
> @@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
> depends on BR2_TOOLCHAIN_USES_GLIBC
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
> + depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu
> help
> netsniff-ng is a free, performant Linux network analyzer and
> networking toolkit. If you will, the Swiss army knife for
> network packets.
>
> comment "netsniff-ng needs an (e)glibc toolchain w/ threads"
> + depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
> depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854
>
> comment "netsniff-ng needs a toolchain not affected by GCC bug 58854"
> + depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
> depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854
> --
> 2.6.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/netsniff: fix missing depend on statements
2015-12-13 16:19 [Buildroot] [PATCH] package/netsniff: fix missing depend on statements Samuel Martin
2015-12-13 17:23 ` Yann E. MORIN
@ 2015-12-13 18:05 ` Thomas Petazzoni
2015-12-13 18:28 ` Samuel Martin
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-12-13 18:05 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Sun, 13 Dec 2015 17:19:37 +0100, Samuel Martin wrote:
> Add missing architecture dependencies inherited from liburcu.
>
> Fixes:
> http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/netsniff-ng/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/netsniff-ng/Config.in b/package/netsniff-ng/Config.in
> index 8c48f39..65b2a0f 100644
> --- a/package/netsniff-ng/Config.in
> +++ b/package/netsniff-ng/Config.in
> @@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
> depends on BR2_TOOLCHAIN_USES_GLIBC
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
> + depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu
The list of architecture dependencies from liburcu is already
duplicated in liburcu (two times), in lttng-libust (two times),
lttng-tools (two times) and now in netsniff (three times).
Isn't it time to switch to BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/netsniff: fix missing depend on statements
2015-12-13 18:05 ` Thomas Petazzoni
@ 2015-12-13 18:28 ` Samuel Martin
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Martin @ 2015-12-13 18:28 UTC (permalink / raw)
To: buildroot
On Sun, Dec 13, 2015 at 7:05 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Samuel Martin,
>
> On Sun, 13 Dec 2015 17:19:37 +0100, Samuel Martin wrote:
>> Add missing architecture dependencies inherited from liburcu.
>>
>> Fixes:
>> http://autobuild.buildroot.org/results/0a9/0a90d7c8f523b90b8a4ca6312ab4835547590fb2/
>>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>> ---
>> package/netsniff-ng/Config.in | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/package/netsniff-ng/Config.in b/package/netsniff-ng/Config.in
>> index 8c48f39..65b2a0f 100644
>> --- a/package/netsniff-ng/Config.in
>> +++ b/package/netsniff-ng/Config.in
>> @@ -11,14 +11,17 @@ config BR2_PACKAGE_NETSNIFF_NG
>> depends on BR2_TOOLCHAIN_USES_GLIBC
>> depends on BR2_TOOLCHAIN_HAS_THREADS
>> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu
>> + depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64 # liburcu
>
> The list of architecture dependencies from liburcu is already
> duplicated in liburcu (two times), in lttng-libust (two times),
> lttng-tools (two times) and now in netsniff (three times).
>
> Isn't it time to switch to BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS ?
Certainly!
On it.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
Samuel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-13 18:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-13 16:19 [Buildroot] [PATCH] package/netsniff: fix missing depend on statements Samuel Martin
2015-12-13 17:23 ` Yann E. MORIN
2015-12-13 18:05 ` Thomas Petazzoni
2015-12-13 18:28 ` Samuel Martin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox