Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support
@ 2015-12-14  6:32 Bernd Kuhls
  2015-12-14  6:32 ` [Buildroot] [PATCH v2 2/2] package/mesa3d-demos: remove copy-and-paste artifact from 0001-demos-optional-gl.patch Bernd Kuhls
  2015-12-15 22:14 ` [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2015-12-14  6:32 UTC (permalink / raw)
  To: buildroot

The only files enabled by glesv1 support are in src/egl/opengles1/

Quoting src/egl/opengles1/Makefile.am:

"# These programs aren't intended to be included with the normal distro."
"# They're not too interesting but they're good for testing."

Most of the files present in this directory contain

"#include <X11/Xlib.h>"

which breaks a wayland-only build because the build system does not take
care of the x11 dependency here. Since these files are "not too
interesting" anyway we just disable glesv1 support.

Fixes
http://autobuild.buildroot.net/results/b3e/b3ed3ee174a3ddce84bf64039eac39d4e6e75b71/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: fixed patch description, git does not like "#" in comments ;) (Thomas)
    split 0001-demos-optional-gl.patch into seperate patch

 package/mesa3d-demos/mesa3d-demos.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/mesa3d-demos/mesa3d-demos.mk b/package/mesa3d-demos/mesa3d-demos.mk
index 016095b..cfc5406 100644
--- a/package/mesa3d-demos/mesa3d-demos.mk
+++ b/package/mesa3d-demos/mesa3d-demos.mk
@@ -11,6 +11,8 @@ MESA3D_DEMOS_AUTORECONF = YES
 MESA3D_DEMOS_DEPENDENCIES = host-pkgconf
 MESA3D_DEMOS_LICENSE = MIT
 
+MESA3D_DEMOS_CONF_OPTS += --disable-gles1
+
 ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_HAS_LIBGL),yy)
 MESA3D_DEMOS_DEPENDENCIES += libgl libglew libglu xlib_libX11 xlib_libXext
 MESA3D_DEMOS_CONF_OPTS += --enable-gl --enable-x11
@@ -27,9 +29,9 @@ endif
 
 ifeq ($(BR2_PACKAGE_HAS_LIBGLES),y)
 MESA3D_DEMOS_DEPENDENCIES += libgles
-MESA3D_DEMOS_CONF_OPTS += --enable-gles1 --enable-gles2
+MESA3D_DEMOS_CONF_OPTS += --enable-gles2
 else
-MESA3D_DEMOS_CONF_OPTS += --disable-gles1 --disable-gles2
+MESA3D_DEMOS_CONF_OPTS += --disable-gles2
 endif
 
 ifeq ($(BR2_PACKAGE_HAS_LIBOPENVG),y)
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v2 2/2] package/mesa3d-demos: remove copy-and-paste artifact from 0001-demos-optional-gl.patch
  2015-12-14  6:32 [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support Bernd Kuhls
@ 2015-12-14  6:32 ` Bernd Kuhls
  2015-12-15 22:14 ` [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Bernd Kuhls @ 2015-12-14  6:32 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: split patch from previous patch regarding glesv1 (Thomas)

 package/mesa3d-demos/0001-demos-optional-gl.patch | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/package/mesa3d-demos/0001-demos-optional-gl.patch b/package/mesa3d-demos/0001-demos-optional-gl.patch
index 0415bbc..6470e9d 100644
--- a/package/mesa3d-demos/0001-demos-optional-gl.patch
+++ b/package/mesa3d-demos/0001-demos-optional-gl.patch
@@ -72,6 +72,3 @@ Index: mesa3d-demos-8.1.0/src/util/Makefile.am
  
  if HAVE_GLUT
  AM_CFLAGS += \
-diff -uNr mesa-demos-8.3.0.org/configure.ac mesa-demos-8.3.0/configure.ac
---- mesa-demos-8.3.0.org/configure.ac	2015-12-09 22:06:44.000000000 +0100
-+++ mesa-demos-8.3.0/configure.ac	2015-12-12 17:06:10.484295811 +0100
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support
  2015-12-14  6:32 [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support Bernd Kuhls
  2015-12-14  6:32 ` [Buildroot] [PATCH v2 2/2] package/mesa3d-demos: remove copy-and-paste artifact from 0001-demos-optional-gl.patch Bernd Kuhls
@ 2015-12-15 22:14 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-12-15 22:14 UTC (permalink / raw)
  To: buildroot

Dear Bernd Kuhls,

On Mon, 14 Dec 2015 07:32:55 +0100, Bernd Kuhls wrote:
> The only files enabled by glesv1 support are in src/egl/opengles1/
> 
> Quoting src/egl/opengles1/Makefile.am:
> 
> "# These programs aren't intended to be included with the normal distro."
> "# They're not too interesting but they're good for testing."
> 
> Most of the files present in this directory contain
> 
> "#include <X11/Xlib.h>"
> 
> which breaks a wayland-only build because the build system does not take
> care of the x11 dependency here. Since these files are "not too
> interesting" anyway we just disable glesv1 support.
> 
> Fixes
> http://autobuild.buildroot.net/results/b3e/b3ed3ee174a3ddce84bf64039eac39d4e6e75b71/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: fixed patch description, git does not like "#" in comments ;) (Thomas)
>     split 0001-demos-optional-gl.patch into seperate patch

Both applied. For the first patch, I had to adapt it slightly, since it
didn't apply directly on top of master.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-15 22:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14  6:32 [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support Bernd Kuhls
2015-12-14  6:32 ` [Buildroot] [PATCH v2 2/2] package/mesa3d-demos: remove copy-and-paste artifact from 0001-demos-optional-gl.patch Bernd Kuhls
2015-12-15 22:14 ` [Buildroot] [PATCH v2 1/2] package/mesa3d-demos: Disable glesv1 support Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox