Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Handle defconfig as .config in .gitignore and distclean.
Date: Sun, 27 Dec 2015 21:44:16 +0100	[thread overview]
Message-ID: <20151227204416.GK3483@free.fr> (raw)
In-Reply-To: <CABbD_XAgJWoQ5R6-01Enp37CP18i6fNgj6oCRB7uxvrkY4TmRA@mail.gmail.com>

K?roly, All,

I'm trying to review the oldest patches still pending, and here's it's
the turn of your patch. ;-)

On 2015-05-20 13:13 +0200, K?roly Kasza spake thusly:
> people are told to work with a clone of buildroot and adding defconfig
> >  to gitignore means that ther is a high chance of not adding it to git
> > and loosing it...
> 
> You are right in this context, but .config is also in .gitignore, which
> also shouldn't be there if a custom repo is used.
> I think .gitignore should be tuned to the git repo currently used -
> buildroot's own repo in the vanilla BR case.

Unlike Jeremy, I'm perfectly fine with defconfig in .gitignore. It's the
distclean part I'm more concerned with.

On the one hand, it does make sense to remove it like we do remove
.config. After all, the user is king, and if he wants to remove
everything, why should we keep it? ;-)

On the other hand, I would see defconfig as really the quintessence of
the configuration, which the user explicitly saved. They could get quite
surprised if we now remove that file.

So, I'm a bit skeptical either way: keep it or remove it, I am unsure.
Let's lean toward the safe side, and ket's just keep it, for users that
were used to that behaviour, OK?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-12-27 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  8:45 [Buildroot] [PATCH] Handle defconfig as .config in .gitignore and distclean kaszak at gmail.com
2015-05-20  9:04 ` Jeremy Rosen
2015-05-20 11:13   ` Károly Kasza
2015-12-27 20:44     ` Yann E. MORIN [this message]
2015-12-28  8:20       ` Thomas Petazzoni
2015-12-28 17:24         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151227204416.GK3483@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox