Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Handle defconfig as .config in .gitignore and distclean.
Date: Mon, 28 Dec 2015 18:24:19 +0100	[thread overview]
Message-ID: <20151228172419.GA3446@free.fr> (raw)
In-Reply-To: <20151228092019.5fb2af66@free-electrons.com>

Thomas, K?roly, All,

On 2015-12-28 09:20 +0100, Thomas Petazzoni spake thusly:
> On Sun, 27 Dec 2015 21:44:16 +0100, Yann E. MORIN wrote:
> 
> > Unlike Jeremy, I'm perfectly fine with defconfig in .gitignore. It's the
> > distclean part I'm more concerned with.
> > 
> > On the one hand, it does make sense to remove it like we do remove
> > .config. After all, the user is king, and if he wants to remove
> > everything, why should we keep it? ;-)
> > 
> > On the other hand, I would see defconfig as really the quintessence of
> > the configuration, which the user explicitly saved. They could get quite
> > surprised if we now remove that file.
> > 
> > So, I'm a bit skeptical either way: keep it or remove it, I am unsure.
> > Let's lean toward the safe side, and ket's just keep it, for users that
> > were used to that behaviour, OK?
> 
> Since the defconfig file name is configurable (by means of
> BR2_DEFCONFIG), I don't think we should do anything special with it. So
> I don't think it should be in .gitignore and I don't think we should
> remove it upon "make distclean".
> 
> If we were do "rm -f $(BR2_DEFCONFIG)" to always remove the user
> configured defconfig, then it would remove configs/<foo>_defconfig if
> you started from that defconfig and do a "make distclean". Not good.
> And we can't have user-configurable file names in .gitignore I believe.
> 
> So I'm personally in favor of keeping things as they are today, and
> therefore reject the patch proposed by K?roly.

That's fine with me. I'll mark it rejected, then.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-12-28 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  8:45 [Buildroot] [PATCH] Handle defconfig as .config in .gitignore and distclean kaszak at gmail.com
2015-05-20  9:04 ` Jeremy Rosen
2015-05-20 11:13   ` Károly Kasza
2015-12-27 20:44     ` Yann E. MORIN
2015-12-28  8:20       ` Thomas Petazzoni
2015-12-28 17:24         ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151228172419.GA3446@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox