[Buildroot] [PATCH 1/1 v1] yp-tools: new package

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Jonathan,

The patch title is wrong: it's a v2, not a v1. Also, there was no
changelog below the "---" sign to help understand what has changed.

On Wed, 23 Dec 2015 19:59:44 +0200, Jonathan Ben-Avraham wrote:
> From: Jonathan Ben Avraham <yba@tkos.co.il>
> 
> Adds the yp-tools package that provides various NIS (yp) utilities.
> Runtime tested on arch arm. Built on i586.
> 
> Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>

I tried to build this configuration:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2015.11-rc1-71-g90d1299.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_4_7=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_YP_TOOLS=y
# BR2_TARGET_ROOTFS_TAR is not set

and it fails to build with:

yp_get_default_domain.c:23:24: fatal error: rpcsvc/nis.h: No such file
or directory

> +YP_TOOLS_PRE_CONFIGURE_HOOKS += YP_TOOLS_LOCAL_MAPV4V6ADDR_H
> +
> +# mapv4v6addr.h isn't always available, depending on your build, but
> +# nis-hosts.c only needs it for a single, inline function.  So drop a copy
> +# here rather than playing games with the include path that would
> +# potentially lead to cross-compilation issues.
> +
> +define YP_TOOLS_LOCAL_MAPV4V6ADDR_H
> +	$(INSTALL) -D -m 0644 $(TOPDIR)/package/yp-tools/mapv4v6addr.h \
> +		$(STAGING_DIR)/usr/include/resolv/mapv4v6addr.h
> +endef

Instead of doing this "complicated" installation of a header file, just
patch nis-tools.c to not include <mapv4v6addr.h> and instead put a copy
of the needed function at the top of this file.

I would have changed it myself before applying, but since there is a
build failure, it's up to you to fix it :-)

Also, you have:

	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT

but you don't depend on the gettext package, so you don't have the
guarantee that it will be built before yp-tools.

Could you look into those issues and send an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com