Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 v1] yp-tools: new package
Date: Tue, 29 Dec 2015 13:51:04 +0100	[thread overview]
Message-ID: <20151229135104.3544d057@free-electrons.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1512291332270.647@tanhuma.tkos.co.il>

Jonathan,

On Tue, 29 Dec 2015 13:37:34 +0200 (IST), Jonathan Ben Avraham wrote:

> Do you mean a git-generated change log from the previous version of the 
> patch to the current version of the patch?

Git cannot generate such a changelog, only a human can describe the
changes between two iterations of a patch (or patch series).

See
https://buildroot.org/downloads/manual/manual.html#submitting-patches
for details, and especially the section "21.5.2. Patch revision
changelog".


> > and it fails to build with:
> >
> > yp_get_default_domain.c:23:24: fatal error: rpcsvc/nis.h: No such file
> > or directory
> 
> What would be a good set of configs to test before submitting patches?

Depends on what you want to test. From my point of view, testing with
at least
http://autobuild.buildroot.org/toolchains/configs/br-arm-full.config is
a strict minimum. It's a uClibc configuration for ARM, with all
toolchain features enabled. If your package doesn't build with this
one, it's really a no-go (and your package currently doesn't build with
this one).

Then, if you don't have any toolchain feature dependency, you may want
to try with
http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config,
which is the same as above, except that things like RPC, wchar, locales
and al. are disabled.

If you want to verify that your package builds for noMMU platforms, you
can use
http://autobuild.buildroot.org/toolchains/configs/bfin-linux-uclibc.config.

If you want to verify that your package builds without shared library
support, you can use:
http://autobuild.buildroot.org/toolchains/configs/br-arm-full-static.config.

If you want to verify that your package builds without thread support,
you can use:
http://autobuild.buildroot.org/toolchains/configs/br-arm-full-nothread.config.

If you want to verify that your package builds with the musl C library,
you can use:
http://autobuild.buildroot.org/toolchains/configs/br-arm-cortex-a9-musl.config.

If you want to verify that your package builds with gcc 5.x, you can
use:
http://autobuild.buildroot.org/toolchains/configs/br-arm-cortex-a9-glibc.config.

However, it is pointless to test *all* those combinations every time
you submit a package: the autobuilder infrastructure will do it for
you. However, building with the first one (ARM/uClibc/all features) is
definitely something that should be tested before submitting a patch.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-12-29 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 17:59 [Buildroot] [PATCH 1/1 v1] yp-tools: new package Jonathan Ben-Avraham
2015-12-28 21:58 ` Thomas Petazzoni
2015-12-29 11:37   ` Jonathan Ben Avraham
2015-12-29 12:51     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229135104.3544d057@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox