Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3] python-paho-mqtt: add new package
Date: Wed, 30 Dec 2015 15:56:00 +0100	[thread overview]
Message-ID: <20151230155600.3352bbba@free-electrons.com> (raw)
In-Reply-To: <1451463207-2630-1-git-send-email-zinosat@tiscali.it>

Dear Davide Viti,

On Wed, 30 Dec 2015 09:13:27 +0100, Davide Viti wrote:
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor didn't give you his Reviewed-by. It is not because someone
commented on your patch that this person is giving you his formal
Reviewed-by.

See
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L539
for the meaning of Reviewed-by.

And specifically, if someone has made comments, it indicates that your
patch wasn't fully correct, and therefore this person is *not* giving
you his Reviewed-by.

> Signed-off-by: Davide Viti <zinosat@tiscali.it>
> 
> v1 -> v2:
>  - Provide official md5 (suggested by Yegor Yefremov)
>  - Reword package description (suggested by Thomas Petazzoni)
>  - Use "distutils" setup type (suggested by Yegor Yefremov)
>  - Add "depends on BR2_PACKAGE_PYTHON" in Config.in
>  - Test with Python3 (suggested by Yegor Yefremov)
> 
> v2 -> v3:
>  - Remove dependency on BR2_PACKAGE_PYTHON since the package builds
>    fine against Python 3 (suggested by Yegor Yefremov)

Such changelog is very good, but should be place below the "---" sign...

> 
> ---

here.

If you don't do this, when I apply the patch, the changelog is kept in
the commit log, which we don't want.

I've fixed those two minor issues, and applied your patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-12-30 14:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30  8:13 [Buildroot] [PATCHv3] python-paho-mqtt: add new package Davide Viti
2015-12-30 14:56 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151230155600.3352bbba@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox