Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCHv3] python-paho-mqtt: add new package
@ 2015-12-30  8:13 Davide Viti
  2015-12-30 14:56 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Davide Viti @ 2015-12-30  8:13 UTC (permalink / raw)
  To: buildroot

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Davide Viti <zinosat@tiscali.it>

v1 -> v2:
 - Provide official md5 (suggested by Yegor Yefremov)
 - Reword package description (suggested by Thomas Petazzoni)
 - Use "distutils" setup type (suggested by Yegor Yefremov)
 - Add "depends on BR2_PACKAGE_PYTHON" in Config.in
 - Test with Python3 (suggested by Yegor Yefremov)

v2 -> v3:
 - Remove dependency on BR2_PACKAGE_PYTHON since the package builds
   fine against Python 3 (suggested by Yegor Yefremov)

---
 package/Config.in                              |  1 +
 package/python-paho-mqtt/Config.in             |  9 +++++++++
 package/python-paho-mqtt/python-paho-mqtt.hash |  3 +++
 package/python-paho-mqtt/python-paho-mqtt.mk   | 14 ++++++++++++++
 4 files changed, 27 insertions(+)
 create mode 100644 package/python-paho-mqtt/Config.in
 create mode 100644 package/python-paho-mqtt/python-paho-mqtt.hash
 create mode 100644 package/python-paho-mqtt/python-paho-mqtt.mk

diff --git a/package/Config.in b/package/Config.in
index dd44743..aab1958 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -659,6 +659,7 @@ menu "External python modules"
 	source "package/python-networkmanager/Config.in"
 	source "package/python-nfc/Config.in"
 	source "package/python-numpy/Config.in"
+	source "package/python-paho-mqtt/Config.in"
 	source "package/python-pam/Config.in"
 	source "package/python-posix-ipc/Config.in"
 	source "package/python-protobuf/Config.in"
diff --git a/package/python-paho-mqtt/Config.in b/package/python-paho-mqtt/Config.in
new file mode 100644
index 0000000..79d8b33
--- /dev/null
+++ b/package/python-paho-mqtt/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_PAHO_MQTT
+	bool "python-paho-mqtt"
+	help
+	  The Paho Python Client provides a client class with support
+	  for both MQTT v3.1 and v3.1.1 on Python 2.7 or 3.x. It also
+	  provides some helper functions to make publishing messages
+	  to an MQTT server very straightforward.
+
+	  https://pypi.python.org/pypi/paho-mqtt
diff --git a/package/python-paho-mqtt/python-paho-mqtt.hash b/package/python-paho-mqtt/python-paho-mqtt.hash
new file mode 100644
index 0000000..52729cc
--- /dev/null
+++ b/package/python-paho-mqtt/python-paho-mqtt.hash
@@ -0,0 +1,3 @@
+# md5 from https://pypi.python.org/pypi?:action=show_md5&digest=a6407b74eb5e5411e157be1de5c11366, sha256 locally computed
+md5     a6407b74eb5e5411e157be1de5c11366  paho-mqtt-1.1.tar.gz
+sha256  0f7a629efe6e3a2c61b59d3550aa9f2c4529b5689a65fde45e6f1ac36b9a261e  paho-mqtt-1.1.tar.gz
diff --git a/package/python-paho-mqtt/python-paho-mqtt.mk b/package/python-paho-mqtt/python-paho-mqtt.mk
new file mode 100644
index 0000000..01da2b3
--- /dev/null
+++ b/package/python-paho-mqtt/python-paho-mqtt.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-paho-mqtt
+#
+################################################################################
+
+PYTHON_PAHO_MQTT_VERSION = 1.1
+PYTHON_PAHO_MQTT_SOURCE = paho-mqtt-$(PYTHON_PAHO_MQTT_VERSION).tar.gz
+PYTHON_PAHO_MQTT_SITE = https://pypi.python.org/packages/source/p/paho-mqtt
+PYTHON_PAHO_MQTT_LICENSE = EPLv1.0 or EDLv1.0
+PYTHON_PAHO_MQTT_LICENSE_FILES = LICENSE.txt edl-v10 epl-v10
+PYTHON_PAHO_MQTT_SETUP_TYPE = distutils
+
+$(eval $(python-package))
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCHv3] python-paho-mqtt: add new package
  2015-12-30  8:13 [Buildroot] [PATCHv3] python-paho-mqtt: add new package Davide Viti
@ 2015-12-30 14:56 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-12-30 14:56 UTC (permalink / raw)
  To: buildroot

Dear Davide Viti,

On Wed, 30 Dec 2015 09:13:27 +0100, Davide Viti wrote:
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor didn't give you his Reviewed-by. It is not because someone
commented on your patch that this person is giving you his formal
Reviewed-by.

See
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L539
for the meaning of Reviewed-by.

And specifically, if someone has made comments, it indicates that your
patch wasn't fully correct, and therefore this person is *not* giving
you his Reviewed-by.

> Signed-off-by: Davide Viti <zinosat@tiscali.it>
> 
> v1 -> v2:
>  - Provide official md5 (suggested by Yegor Yefremov)
>  - Reword package description (suggested by Thomas Petazzoni)
>  - Use "distutils" setup type (suggested by Yegor Yefremov)
>  - Add "depends on BR2_PACKAGE_PYTHON" in Config.in
>  - Test with Python3 (suggested by Yegor Yefremov)
> 
> v2 -> v3:
>  - Remove dependency on BR2_PACKAGE_PYTHON since the package builds
>    fine against Python 3 (suggested by Yegor Yefremov)

Such changelog is very good, but should be place below the "---" sign...

> 
> ---

here.

If you don't do this, when I apply the patch, the changelog is kept in
the commit log, which we don't want.

I've fixed those two minor issues, and applied your patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-30 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30  8:13 [Buildroot] [PATCHv3] python-paho-mqtt: add new package Davide Viti
2015-12-30 14:56 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox