From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/tcl: move comment around, to keep proper indentation
Date: Wed, 30 Dec 2015 21:17:56 +0100 [thread overview]
Message-ID: <20151230211756.4023d5e8@free-electrons.com> (raw)
In-Reply-To: <877fjv21n1.fsf@dell.be.48ers.dk>
Peter,
On Wed, 30 Dec 2015 20:10:42 +0100, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>
> > commit: http://git.buildroot.net/buildroot/commit/?id=ac371770de69b5ee5f15eed7dd790558b8835d7d
> > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> > In Kconfig, when there is an item (like a comment) between a symbol and
> > its dependees, then the indentation is not in effect.
>
> > Move the symbol to the top of the file to guarantee the indentation in
> > menuconfig.
>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Thomas, it seems like you forgot to use the -s option to git am, please
> try to remember.
Hum, right. But in fact it is due to the fact that I did not "git am"
such patches. Yann sent them to the list, then immediately marked them
as RFC in Patchwork, so that they were no longer visible in the list of
pending patches in Patchwork.
So, rather than fetching them with patchwork, I simply "git
cherry-pick"ed them from Yann's Git repo. So the process to get those
patches was not the classical one, hence I forgot to add my SoB line.
Otherwise, I use my "git pwam" alias, which automatically adds my SoB
line, so I can't forget it.
That being said, this is not an excuse, so sorry for the mess. But it
explains why those 6 patches didn't have my SoB line.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-12-30 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 16:58 [Buildroot] [git commit] package/tcl: move comment around, to keep proper indentation Thomas Petazzoni
2015-12-30 19:10 ` Peter Korsgaard
2015-12-30 20:17 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151230211756.4023d5e8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox